Skip to content

fix: rethrow DeFindex errors in resolvePositions instead of returning partial data - #244

Merged
collinsezedike merged 1 commit into
mainfrom
fix/defindex-rethrow-error
Jun 25, 2026
Merged

collinsezedike merged 1 commit into
mainfrom
fix/defindex-rethrow-error

Conversation

@collinsezedike

@collinsezedike collinsezedike commented Jun 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Removes the try/catch that swallowed fetchDefindexPosition errors in resolvePositions, replacing it with a direct await
  • Previously a DeFindex RPC failure returned HTTP 200 with only Blend positions and no signal that data was missing; now the error propagates and the API route's existing try/catch returns 503
  • Updates the orchestration test to assert the error propagates instead of asserting it was swallowed

Test plan

  • pnpm lint && pnpm typecheck && pnpm test pass locally
  • pnpm --filter @meridian/stellar-sdk-helpers run test shows 80 passing
  • Manually verify that a DeFindex RPC failure returns 503 from the positions endpoint instead of a silent 200

Closes #234

@vercel

vercel Bot commented Jun 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
meridian Ready Ready Preview, Comment Jun 24, 2026 3:20pm

@collinsezedike
collinsezedike merged commit 34f563c into main Jun 25, 2026
5 checks passed
@collinsezedike
collinsezedike deleted the fix/defindex-rethrow-error branch June 25, 2026 15:52

This branch was successfully deployed

1 active deployment
Preview — 9b02a25f Deployed Jun 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] DeFindex errors silently swallowed in orchestration.ts returning partial data as HTTP 200

1 participant