-
Notifications
You must be signed in to change notification settings - Fork 32
Update deps and release v0.13.0 #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick but asking out of curiosity, was this your IDE changing these back to
'or is there a lint rule in the repo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you're referring to; there's no change from
"to'on these lines (that I see).If you're asking about the change on line 14, I'm not sure where that change came from, but it might've been me changing something manually and changing it back; by habit I'll use single quotes instead of double quotes for things. I don't think I have anything that is autoformatting or linting
pyproject.toml, unless I've forgotten something and am not finding it now.Looking at the file again now, I'm seeing that there is a mix of single and double quotes, and in my hunt for a TOML style guide to see if there's a recommendation, I see that single and double quotes are processed differently, which I didn't realize. I should probably change everything to be double-quoted, as I'm not intentionally avoiding the escaping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry.
There is this change on the line 14th, and I'm not sure why but I thought the same change on the dev dependency group too. Now checking it again, that change was limited to the
requires-pythonline.If that sounds okay, I can create a PR for a lightweight lint CI workflow and utilize https://pyproject-fmt.readthedocs.io/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in getting back to you. Life got in the way this week.
The way I do presubmit checking is a bit idiosyncratic (it's all stuffed into the //run script), so I decided to make this change myself: #105
I'm glad I did, because it gave me a chance to play with the package and also experience the auto-upgrading of package versions that'll currently happen when you make changes to the uv.lock file (which I'm not 100% wild about as noted in the PR).