Conversation
This updates the project dependencies to the latest set of stuff older than 30 days, and updates uv to not install packages released within the past 30 days by default. Also fixes a minor bug in the //run script.
| 'pylint==3.3.6; python_version >= "3.9"', | ||
| 'ruff==0.11.2', | ||
| 'twine==6.1.0', | ||
| 'build >= 1.2.2.post1; python_version < "3.9"', |
There was a problem hiding this comment.
Nitpick but asking out of curiosity, was this your IDE changing these back to ' or is there a lint rule in the repo?
There was a problem hiding this comment.
I'm not sure what you're referring to; there's no change from " to ' on these lines (that I see).
If you're asking about the change on line 14, I'm not sure where that change came from, but it might've been me changing something manually and changing it back; by habit I'll use single quotes instead of double quotes for things. I don't think I have anything that is autoformatting or linting pyproject.toml, unless I've forgotten something and am not finding it now.
Looking at the file again now, I'm seeing that there is a mix of single and double quotes, and in my hunt for a TOML style guide to see if there's a recommendation, I see that single and double quotes are processed differently, which I didn't realize. I should probably change everything to be double-quoted, as I'm not intentionally avoiding the escaping.
There was a problem hiding this comment.
Oh sorry.
There is this change on the line 14th, and I'm not sure why but I thought the same change on the dev dependency group too. Now checking it again, that change was limited to the requires-python line.
I should probably change everything to be double-quoted, as I'm not intentionally avoiding the escaping.
If that sounds okay, I can create a PR for a lightweight lint CI workflow and utilize https://pyproject-fmt.readthedocs.io/
There was a problem hiding this comment.
If that sounds okay, I can create a PR for a lightweight lint CI workflow
Sorry for the delay in getting back to you. Life got in the way this week.
The way I do presubmit checking is a bit idiosyncratic (it's all stuffed into the //run script), so I decided to make this change myself: #105
I'm glad I did, because it gave me a chance to play with the package and also experience the auto-upgrading of package versions that'll currently happen when you make changes to the uv.lock file (which I'm not 100% wild about as noted in the PR).
2 participants
No description provided.