Skip to content

Tweak dotnet-pgo to be flexible to changes from class to valuetype for application types #87355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidwrighton merged 1 commit into from
Jun 12, 2023
Merged

Tweak dotnet-pgo to be flexible to changes from class to valuetype for application types #87355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/coreclr/tools/dotnet-pgo/TypeRefTypeSystem/TypeRefTypeSystemType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ public void SetIsValueType(bool isValueType)
}
else
{
if (_isValueType.Value != isValueType)
{
throw new Exception($"Same type `{ToString()}` used as both ValueType and non-ValueType");
}
// Do nothing. We cannot choose a correct choice, and failing is also unhelpful, as dotnet-pgo is supposed
// to work with traces from the same app over time where a type may have transformed from class to struct
// or vice versa. With this approach, the first assembly on the commandline to push a type to be struct
// or class will reliably win.
}
}

Expand Down