Skip to content

Tweak dotnet-pgo to be flexible to changes from class to valuetype for application types#87355

Merged
davidwrighton merged 1 commit into
dotnet:mainfrom
davidwrighton:remove_dotnet_pgo_isvaluetype_failure
Jun 12, 2023
Merged

Tweak dotnet-pgo to be flexible to changes from class to valuetype for application types#87355
davidwrighton merged 1 commit into
dotnet:mainfrom
davidwrighton:remove_dotnet_pgo_isvaluetype_failure

Conversation

@davidwrighton

Copy link
Copy Markdown
Member

Fix #61604 by simply removing the possibility of throwing an exception in those cases. We'll now pick the first one.

@ghost ghost added the area-ReadyToRun label Jun 9, 2023
@ghost ghost assigned davidwrighton Jun 9, 2023
@davidwrighton davidwrighton requested a review from trylek June 9, 2023 23:55

@trylek trylek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwrighton davidwrighton merged commit c6fd07b into dotnet:main Jun 12, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"dotnet-pgo dump" throws "Same type X used as both ValueType and non-ValueType"

2 participants