Skip to content

[tests] Retain OutDir for ioslike tests#82313

Closed
mdh1418 wants to merge 3 commits into
dotnet:mainfrom
mdh1418:retain_outdir_ios_tests
Closed

[tests] Retain OutDir for ioslike tests#82313
mdh1418 wants to merge 3 commits into
dotnet:mainfrom
mdh1418:retain_outdir_ios_tests

Conversation

@mdh1418

@mdh1418 mdh1418 commented Feb 17, 2023

Copy link
Copy Markdown
Member

$(OutDir) was removed in the ioslike tests build for the purpose of saving space, however some projects that include references will need assemblies in the $(OutDir) directory for the CoreCompile target. In the libraries tests, there is a workaround for this. This PR examines whether or not the $(OutDir) needs to be removed, using a metric of <100MB remaining when it is not removed to determine that it should continue to be removed.

@ghost

ghost commented Feb 17, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

$(OutDir) was removed in the ioslike tests build for the purpose of saving space, however some projects that include references will need assemblies in the $(OutDir) directory for the CoreCompile target. In the libraries tests, there is a workaround for this. This PR examines whether or not the $(OutDir) needs to be removed, using a metric of <100MB remaining when it is not removed to determine that it should continue to be removed.

Author: mdh1418
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@mdh1418

mdh1418 commented Feb 17, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-ioslike, runtime-maccatalyst

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@mdh1418

mdh1418 commented Mar 1, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-ioslike, runtime-maccatalyst

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@mdh1418

mdh1418 commented Mar 1, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-ioslike, runtime-maccatalyst

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@mdh1418

mdh1418 commented Mar 1, 2023

Copy link
Copy Markdown
Member Author
Filesystem       Size   Used  Avail Capacity iused      ifree %iused  Mounted on
/dev/disk1s1    380Gi  212Gi  152Gi    59% 5115518 3977424882    0%   /System/Volumes/Data

Across 6 runs of runtime-ioslike not from this PR, the average disk usage (Change in Avail Column between before build and after build)
tvOS: 12.166... Gi (56% -> 60% capacity)
iOS: 8 Gi (56% -> 58% capacity)

Across the 2 runs of runtime-ioslike from this PR, the average disk usage
tvOS: 42.5 Gi. (56% -> 68% capacity)
iOS: 9.5 Gi (56% -> 59% capacity)

tvOS lanes are impacted more because they build 197 workitems, whereas iOS lanes build just 4 workitems, so the tvOS capacity change is the metric to focus on.

@mdh1418 mdh1418 force-pushed the retain_outdir_ios_tests branch from 40f374a to f8ce0b9 Compare March 2, 2023 16:24
@mdh1418

mdh1418 commented Mar 2, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-ioslike, runtime-ioslikesimulator, runtime-maccatalyst

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@mdh1418

mdh1418 commented Mar 2, 2023

Copy link
Copy Markdown
Member Author

Looks like osx.1200.amd64.open has issues, will rerun the startuphook functional test again after the problem is resolved to verify that the original issue is resolved.

@mdh1418

mdh1418 commented Mar 17, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-ioslike, runtime-ioslikesimulator, runtime-maccatalyst

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@mdh1418 mdh1418 closed this Apr 7, 2023
@mdh1418 mdh1418 deleted the retain_outdir_ios_tests branch April 7, 2023 19:57
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants