Skip to content

[wasm] Skip System.Net.WebClient test suite#38857

Merged
akoeplinger merged 2 commits into
dotnet:masterfrom
MaximLipnin:wasm_WebClient
Jul 7, 2020
Merged

[wasm] Skip System.Net.WebClient test suite#38857
akoeplinger merged 2 commits into
dotnet:masterfrom
MaximLipnin:wasm_WebClient

Conversation

@MaximLipnin

@MaximLipnin MaximLipnin commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

Part of #38422.

Actually System.Net.WebClient test suite crashes with the error described in #38807. But since WebClient class is not recommended for new development, I just skipped the respective tests on WASM.
Besides that, I updated System.Net.WebClient with throwing PNSE on wasm.

@ghost

ghost commented Jul 7, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@akoeplinger

akoeplinger commented Jul 7, 2020

Copy link
Copy Markdown
Member

Looks good but I think we should also add PNSE for System.Net.WebClient and point people to HttpClient.

@stephentoub

Copy link
Copy Markdown
Member

Looks good but I think we should also add PNSE for System.Net.WebClient and point people to HttpClient.

The async APIs on WebClient should still work, right? It's just the sync ones that won't?

(I don't have a strong opinion here; if we want to PNSE the whole assembly because it's legacy and not recommended for new use, ok.)

@akoeplinger

akoeplinger commented Jul 7, 2020

Copy link
Copy Markdown
Member

@stephentoub yeah that would probably work but I just checked and WebClient never worked in the mono/mono-based WASM so I think we should be fine with marking it PNSE here.

@MaximLipnin could you please add that? With this message: System.Net.WebClient is not supported on this platform. Use System.Net.Http.HttpClient instead.

@stephentoub

Copy link
Copy Markdown
Member

yeah that would probably work but I just checked and WebClient never worked in the mono/mono-based WASM so I think we should be fine with marking it PNSE here.

Ok

@akoeplinger akoeplinger merged commit 8f25c04 into dotnet:master Jul 7, 2020
@MaximLipnin MaximLipnin deleted the wasm_WebClient branch July 7, 2020 20:25
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants