Skip to content

Make browser peer for windows_nt and unix#37944

Merged
akoeplinger merged 50 commits into
dotnet:masterfrom
Anipik:browser
Jul 8, 2020
Merged

Make browser peer for windows_nt and unix#37944
akoeplinger merged 50 commits into
dotnet:masterfrom
Anipik:browser

Conversation

@Anipik

@Anipik Anipik commented Jun 16, 2020 •
edited by akoeplinger
Loading

Copy link
Copy Markdown
Contributor

Fixes #38559

Contributes to #37439

@ghost

ghost commented Jun 16, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@jaredpar jaredpar mentioned this pull request Jun 16, 2020
Closed
@Anipik Anipik requested a review from marek-safar as a code owner June 16, 2020 19:57
@ericstj ericstj requested review from lewing and vargaz June 16, 2020 22:05
ericstj
ericstj reviewed Jun 16, 2020
View reviewed changes
Comment thread eng/targetframeworksuffix.props Outdated
@Anipik Anipik changed the title [Donot Review]make browser peer for windows_nt and unix Make browser peer for windows_nt and unix Jun 17, 2020
@Anipik

Anipik commented Jun 18, 2020

Copy link
Copy Markdown
Contributor Author

cc @ViktorHofer @safern

@Anipik

Anipik commented Jun 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@ericstj @marek-safar can you review this one ?

ericstj
ericstj reviewed Jun 18, 2020
View reviewed changes
Comment thread src/libraries/Microsoft.Win32.Registry/src/Microsoft.Win32.Registry.csproj Outdated
ericstj
ericstj reviewed Jun 18, 2020
View reviewed changes
Comment thread src/libraries/System.Data.Odbc/src/System.Data.Odbc.csproj Outdated
ericstj
ericstj reviewed Jun 18, 2020
View reviewed changes

@ericstj ericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some of these cases we should see if we can represent netcoreapp-Browser;netcoreapp-Unix;netcoreapp-Windows_NT as netcoreapp;netcoreapp-Windows_NT instead (especially in the cases where there is no DLLImport).

There seem to be a few cases where cross-compilation is resulting because of our config system, and not due to any real ifdefs/conditional compilation (EG: anything project referencing System.Private.Uri/System.Runtime, System.Private.Xml). This is similar to the case we relaxed for System.Private.CoreLib. I wonder if we should relax it in these cases, use the vertical-defined configuration of the project reference, and remove the cross-compilation.

Comment thread src/libraries/System.DirectoryServices.Protocols/src/System.DirectoryServices.Protocols.csproj Outdated
Comment thread src/libraries/System.Drawing.Common/src/System.Drawing.Common.csproj Outdated
Comment thread src/libraries/System.IO.Ports/src/System.IO.Ports.csproj Outdated
Comment thread src/libraries/System.Linq.Expressions/src/System.Linq.Expressions.csproj Outdated
Comment thread src/libraries/System.Private.Xml.Linq/src/System.Private.Xml.Linq.csproj Outdated
Comment thread src/libraries/System.Runtime.InteropServices/src/System.Runtime.InteropServices.csproj Outdated
Comment thread src/libraries/System.Runtime/src/System.Runtime.csproj Outdated
Comment thread ...braries/System.Security.Cryptography.OpenSsl/src/System.Security.Cryptography.OpenSsl.csproj Outdated
Comment thread src/libraries/System.Security.Principal.Windows/src/System.Security.Principal.Windows.csproj Outdated
Comment thread src/libraries/System.Xml.ReaderWriter/src/System.Xml.ReaderWriter.csproj Outdated
marek-safar
marek-safar reviewed Jun 18, 2020
View reviewed changes
Comment thread eng/targetframeworksuffix.props Outdated
marek-safar
marek-safar reviewed Jun 18, 2020
View reviewed changes
Comment thread src/libraries/Microsoft.Win32.Primitives/src/Microsoft.Win32.Primitives.csproj Outdated
marek-safar
marek-safar reviewed Jun 18, 2020
View reviewed changes
Comment thread src/libraries/System.Console/src/System.Console.csproj Outdated
marek-safar
marek-safar reviewed Jun 18, 2020
View reviewed changes
Comment thread src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj Outdated
marek-safar
marek-safar reviewed Jun 18, 2020
View reviewed changes
Comment thread src/libraries/System.Diagnostics.StackTrace/src/System.Diagnostics.StackTrace.csproj Outdated
marek-safar
marek-safar reviewed Jun 18, 2020
View reviewed changes
Comment thread src/libraries/System.IO.Compression.Brotli/src/System.IO.Compression.Brotli.csproj Outdated
marek-safar
marek-safar reviewed Jun 18, 2020
View reviewed changes
Comment thread src/libraries/System.IO.FileSystem.Watcher/src/System.IO.FileSystem.Watcher.csproj Outdated
marek-safar
marek-safar reviewed Jun 24, 2020
View reviewed changes
Comment thread src/libraries/System.Console/src/System.Console.csproj Outdated
safern
safern reviewed Jun 24, 2020
View reviewed changes
Comment thread src/libraries/Microsoft.Win32.Registry/src/Microsoft.Win32.Registry.csproj Outdated
ViktorHofer
ViktorHofer reviewed Jul 6, 2020
View reviewed changes
Comment thread src/libraries/Microsoft.Win32.Registry/src/Microsoft.Win32.Registry.csproj
ViktorHofer
ViktorHofer reviewed Jul 6, 2020
View reviewed changes
Comment thread src/libraries/System.Data.Odbc/ref/System.Data.Odbc.ODBC32.cs Outdated
ViktorHofer
ViktorHofer reviewed Jul 6, 2020
View reviewed changes
Comment thread src/libraries/System.Data.Odbc/ref/System.Data.Odbc.cs
@ViktorHofer

ViktorHofer commented Jul 7, 2020

Copy link
Copy Markdown
Member

I'm not sure if all the test --> src configurations are right but we can otherwise fix them in a follow-up PR. Spot checked. Thanks

@Anipik

Anipik commented Jul 8, 2020

Copy link
Copy Markdown
Contributor Author

@akoeplinger can you review this one ?
i can address the caching change in a follow up pr as it might break something else. I will like to get this one in to avoid merge conflicts.

akoeplinger
akoeplinger approved these changes Jul 8, 2020
View reviewed changes

@akoeplinger akoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@akoeplinger

akoeplinger commented Jul 8, 2020

Copy link
Copy Markdown
Member

The pending runtime (CoreCLR GCC Product Build Linux x64 checked) is actually green on AzDO: https://dev.azure.com/dnceng/public/_build/results?buildId=720121&view=results

@akoeplinger akoeplinger merged commit 5ce04cc into dotnet:master Jul 8, 2020
@akoeplinger akoeplinger mentioned this pull request Jul 8, 2020
Merged
akoeplinger added a commit to akoeplinger/runtime that referenced this pull request Jul 8, 2020
@akoeplinger
Add iOS/tvOS/Android to AdditionalBuildTargetFrameworks
f473918 
Saw these missing while reviewing dotnet#37944.
As far as I can see this is only used when building inside VS but still good to add for consistency.
@akoeplinger akoeplinger mentioned this pull request Jul 8, 2020
Merged
akoeplinger added a commit that referenced this pull request Jul 8, 2020
@akoeplinger
Add iOS/tvOS/Android to AdditionalBuildTargetFrameworks (#38922)
edbb5c8 
Saw these missing while reviewing #37944.
As far as I can see this is only used when building inside VS but still good to add for consistency.
jkotas
jkotas reviewed Jul 8, 2020
View reviewed changes
Comment thread src/libraries/Microsoft.Win32.Primitives/src/Microsoft.Win32.Primitives.csproj
jkotas
jkotas reviewed Jul 8, 2020
View reviewed changes
Comment thread src/libraries/Microsoft.Win32.Primitives/src/Microsoft.Win32.Primitives.csproj
jkotas
jkotas reviewed Jul 8, 2020
View reviewed changes
Comment thread src/libraries/System.Data.Odbc/ref/System.Data.Odbc.ODBC32.cs
public static class ODBC32
{
[System.Runtime.CompilerServices.TypeForwardedFrom("System.Data, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
public enum RETCODE : int

@jkotas jkotas Jul 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this about? This needs a better comment at least.

@Anipik Anipik Jul 9, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the comment in #38968. there is some more info on decision here #37944 (comment)

jkotas
jkotas reviewed Jul 8, 2020
View reviewed changes
Comment thread src/libraries/System.Net.Http/src/System.Net.Http.csproj
jkotas
jkotas reviewed Jul 8, 2020
View reviewed changes
Comment thread src/libraries/System.Net.Http/src/System.Net.Http.csproj
@Anipik

Anipik commented Jul 8, 2020

Copy link
Copy Markdown
Contributor Author

There are going to be follow up prs for this work, i will address the feedback in the next one

This was referenced Jul 8, 2020
Closed
Merged
@akoeplinger akoeplinger mentioned this pull request Jul 10, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safar marek-safar marek-safar left review comments
@akoeplinger akoeplinger akoeplinger approved these changes
@danmoseley danmoseley danmoseley left review comments
@jkotas jkotas jkotas left review comments
@eerhardt eerhardt eerhardt left review comments
@ericstj ericstj ericstj left review comments
@safern safern safern left review comments
@ViktorHofer ViktorHofer ViktorHofer approved these changes
@vargaz vargaz Awaiting requested review from vargaz
@lewing lewing Awaiting requested review from lewing
@EgorBo EgorBo Awaiting requested review from EgorBo
@steveisok steveisok Awaiting requested review from steveisok

Assignees

No one assigned

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Browser Implementation For various assemblies