Fix .NET 11 rc1 SDK crash on RHEL8 arm64 - #133887
Merged
Merged
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/d6c20da4-66f0-474a-ad18-fc49264d3711 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
jkotas
approved these changes
Sep 14, 2026
jkotas
approved these changes
Sep 14, 2026
jkotas
marked this pull request as ready for review
September 14, 2026 23:14
jkotas
changed the title
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
@MichalStrehovsky PTLA |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Fixes the NativeAOT ARM64 thunk crash on systems with 64 KiB pages.
Changes:
- Uses a PC-relative literal load for the common-stub pointer.
- Adds range and alignment validation.
File summaries
| File | Description |
|---|---|
src/coreclr/nativeaot/Runtime/ThunksMapping.cpp |
Corrects ARM64 thunk target loading. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
MichalStrehovsky
approved these changes
Sep 15, 2026
Member
|
@jkoritzinsky Could you please signoff as well? Two sign-offs are not enough for this one... |
Contributor
|
IIRC when I was looking at #131709, I noticed some places in the GC that seemed to assume that |
Member
That's tracked by #133743 . You can comment on that there. |
jkoritzinsky
approved these changes
Sep 17, 2026
Member
|
/backport to release/11.0 |
Contributor
|
Started backporting to |
4 tasks
JulieLeeMSFT
pushed a commit
that referenced
this pull request
Sep 17, 2026
Backport of #133887 to release/11.0 /cc @jkotas @Copilot ## Customer Impact - [x] Customer reported - [ ] Found internally NativeAOT compiled .NET SDK components crash on RHEL. The Arm64 instruction encoding used for NativeAOT marshalled delegate thunks did not work on RHEL that uses 64kB pages by default. This was found by running NativeAOT compiled SDK components on RHEL. ## Regression - [ ] Yes - [x] No ## Testing The fix was validated on RHEL. #133944 opened on improving the test coverage that would allow us to find this issue earlier. ## Risk Low Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
This was referenced Sep 18, 2026
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 18, 2026
Fixes dotnet#133675 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133675