[release/10.0-preview3] JIT: Don't use checked bounds in assertprop

[github-actions]

Backport of #113638 to release/10.0-preview3

Please accept a bug-fix for a bug that sneaked into Preview3 - nobody hit it yet (except for jitstress pipeline in Main), but I suspect it might show up (some conditions folded as true/false when they shouldn't).

/cc @EgorBo

Customer Impact

• Customer reported
• Found internally

A new optimization in 10.0 P3 could fold conditions based on the mechanism that is used by Bounds Check Elimination (BCE). That mechanism contained a pre-existing "potential" bug (we're not sure) that in the worst case could remove a bounds check where it shouldn't (but we suspect it doesn't happen today). The bug manifested itself as real test failures #113049 and #113052 when we started to use this mechanism outside of BCE recently. It may result in taking conditional branches that should not be taken (e.g. unexpected exception is thrown).

Regression

• Yes
• No

The regression was introduced in 10.0 P3

Testing

jitstress. The fix basically disables some recently introduced optimizations.

Risk

Low

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[EgorBo]

PTAL @jakobbotsch cc @dotnet/jit-contrib @jeffschwMSFT

[jeffschwMSFT]

lgtm. please add details to the customer impact that highlight was code patterns may run into an issue. we will take for consideration in 10 P3

[carlossanlop]

Please ping me when it's ready to merge, preview branch has restricted merge permissions.

[carlossanlop]

/ba-g Failure is a test timeout in Collections. does not seem related to the issue being fixed here:

===========================================================================================================
/private/tmp/helix/working/A9D8097B/w/A7DC090B/e /private/tmp/helix/working/A9D8097B/w/A7DC090B/e
  Discovering: System.Collections.Concurrent.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Collections.Concurrent.Tests (found 901 of 909 test cases)
  Starting:    System.Collections.Concurrent.Tests (parallel test collections = on [12 threads], stop on fail = off)
['System.Collections.Concurrent.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]