JIT: Don't use checked bounds in assertprop#113638
Merged
Merged
Conversation
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
/azp run runtime-coreclr jitstress-random, runtime-coreclr libraries-jitstress-random |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
PTAL @jakobbotsch @dotnet/jit-contrib We (Jakob) believe the current logic in MergeAssertion may not be correct (see #110315 (comment)) but it's probably not an issue when it's used only by RangeCheck phase because it relies on other things (SSA-based GetRangeCheck, DoesOverflow). But it is a real issue when we use this logic for actual foldings in global assert prop Diffs - regressions, but a lot smaller than the initial size wins when we started to use this logic for actual foldings recently. |
jakobbotsch
approved these changes
Mar 18, 2025
Member
Author
|
/backport to release/10.0-preview3 |
Contributor
|
Started backporting to release/10.0-preview3: https://github.com/dotnet/runtime/actions/runs/13928629482 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113049
Fixes #113052