JSON Console Logger shouldn't require logging scopes to implement IReadOnlyCollection<KeyValuePair<string, object>>

[shirhatti]

Initially posted in dotnet/diagnostics#1905

@maryamariyan Do you know why the JSON logger requires IReadOnlyCollection<KeyValuePair<string, object>> for scope data? Looking at other loggers, they are perfectly content with IEnumerable<KeyValuePair<string, object>>? If this wasn't intentional, we should fix this in the logger.

runtime/src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs

Line 112 in f9a8abc

if (scope is IReadOnlyCollection<KeyValuePair<string, object>> scopes)

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Initially posted in dotnet/diagnostics#1905

@maryamariyan Do you know why the JSON logger requires IReadOnlyCollection<KeyValuePair<string, object>> for scope data? Looking at other loggers, they are perfectly content with IEnumerable<KeyValuePair<string, object>>? If this wasn't intentional, we should fix this in the logger.

runtime/src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs

Line 112 in f9a8abc

if (scope is IReadOnlyCollection<KeyValuePair<string, object>> scopes)

Author:	shirhatti
Assignees:	-
Labels:	area-Extensions-Logging
Milestone:	-

[wiktork]

Related to #33486

[ericstj]

This looks like a simple bug to fix. The usage here doesn't require IReadOnlyCollection.

[daveMueller]

Hi, I haven't contributed to this repo before, but I would like to start. Can I give it a try?

[maryamariyan]

@daveMueller sure.