Update log scope to be more compatible with JSON console logger.

[jander-msft]

The JSON console logger checks if the log scope implements IReadOnlyCollection<KeyValuePair<string, object>> and then falls back to calling ToString. Add the IReadOnlyCollection<KeyValuePair<string, object>> implementation to better suit the formatted output.

[shirhatti]

@maryamariyan Do you know why the JSON logger requires IReadOnlyCollection<KeyValuePair<string, object>> for scope data? Looking at other loggers, they are perfectly content with IEnumerable<KeyValuePair<string, object>>? If this wasn't intentional, we should fix this in the logger.

[jander-msft]

@maryamariyan Do you know why the JSON logger requires IReadOnlyCollection<KeyValuePair<string, object>> for scope data? Looking at other loggers, they are perfectly content with IEnumerable<KeyValuePair<string, object>>? If this wasn't intentional, we should fix this in the logger.

FYI, here's the code checking for IReadOnlyCollection<>: https://github.com/dotnet/runtime/blob/f9a8abc8a5d9981e25f898181e734dc77c7e15e4/src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs#L112

[maryamariyan]

@maryamariyan Do you know why the JSON logger requires IReadOnlyCollection<KeyValuePair<string, object>> for scope data? Looking at other loggers, they are perfectly content with IEnumerable<KeyValuePair<string, object>>? If this wasn't intentional, we should fix this in the logger.

I don't think there was a specific reason for having IReadOnlyCollection as opposed to IEnumerable. I'll investigate to find out. @shirhatti could you please open an issue on dotnet/runtime to track this?

[shirhatti]

Thanks! I just filed an issue