Skip to content

Add concrete interface collection codec snapshots #10106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 2 commits into from
May 16, 2026
Merged

Add concrete interface collection codec snapshots #10106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa3d164
Add concrete interface collection codec snapshots
ReubenBond May 15, 2026
0324e6f
Merge branch 'main' into followup-interface-codec-snapshots
ReubenBond May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions test/Orleans.Serialization.UnitTests/InterfaceCollectionCodecTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,44 @@ public Task DictionaryInterfaceFallback_Formatted_MatchesSnapshot()
[Fact]
public Task ReadOnlyDictionaryInterfaceFallback_Formatted_MatchesSnapshot()
=> VerifyFallbackBitStream<IReadOnlyDictionary<string, int>>(new UnknownDictionary<string, int>(new Dictionary<string, int> { ["a"] = 1, ["b"] = 2 }), ReadOnlyDictionaryCodecAlias);

[Fact]
public Task EnumerableInterfaceConcreteList_Formatted_MatchesSnapshot()
=> VerifyConcreteRuntimeBitStream<IEnumerable<int>>(new List<int> { 2, 4, 6 }, EnumerableCodecAlias);

[Fact]
public Task ReadOnlyCollectionInterfaceConcreteList_Formatted_MatchesSnapshot()
=> VerifyConcreteRuntimeBitStream<IReadOnlyCollection<int>>(new List<int> { 2, 4, 6 }, ReadOnlyCollectionCodecAlias);

[Fact]
public Task ReadOnlyListInterfaceConcreteList_Formatted_MatchesSnapshot()
=> VerifyConcreteRuntimeBitStream<IReadOnlyList<int>>(new List<int> { 2, 4, 6 }, ReadOnlyListCodecAlias);

[Fact]
public Task CollectionInterfaceConcreteList_Formatted_MatchesSnapshot()
=> VerifyConcreteRuntimeBitStream<ICollection<int>>(new List<int> { 2, 4, 6 }, CollectionCodecAlias);

[Fact]
public Task ListInterfaceConcreteList_Formatted_MatchesSnapshot()
=> VerifyConcreteRuntimeBitStream<IList<int>>(new List<int> { 2, 4, 6 }, ListCodecAlias);

[Fact]
public Task SetInterfaceConcreteHashSet_Formatted_MatchesSnapshot()
=> VerifyConcreteRuntimeBitStream<ISet<string>>(new HashSet<string> { "a", "b" }, SetCodecAlias);

#if NET5_0_OR_GREATER
[Fact]
public Task ReadOnlySetInterfaceConcreteHashSet_Formatted_MatchesSnapshot()
=> VerifyConcreteRuntimeBitStream<IReadOnlySet<string>>(new HashSet<string> { "a", "b" }, ReadOnlySetCodecAlias);
#endif

[Fact]
public Task DictionaryInterfaceConcreteDictionary_Formatted_MatchesSnapshot()
=> VerifyConcreteRuntimeBitStream<IDictionary<string, int>>(new Dictionary<string, int> { ["a"] = 1, ["b"] = 2 }, DictionaryCodecAlias);

[Fact]
public Task ReadOnlyDictionaryInterfaceConcreteDictionary_Formatted_MatchesSnapshot()
=> VerifyConcreteRuntimeBitStream<IReadOnlyDictionary<string, int>>(new Dictionary<string, int> { ["a"] = 1, ["b"] = 2 }, ReadOnlyDictionaryCodecAlias);
#endif

private static T RoundTrip<T>(T value)
Expand All @@ -407,6 +445,17 @@ private static Task VerifyFallbackBitStream<T>(T value, string codecAlias)
return Verify(formatted, extension: "txt").UseDirectory("snapshots");
}

private static Task VerifyConcreteRuntimeBitStream<T>(T value, params string[] fallbackCodecAliases)
{
var formatted = FormatSerializedPayload(value);
foreach (var codecAlias in fallbackCodecAliases)
{
Assert.DoesNotContain($"TypeName \"{codecAlias}", formatted);
}

return Verify(formatted, extension: "txt").UseDirectory("snapshots");
}

private static string FormatSerializedPayload<T>(T value)
{
using var serviceProvider = new ServiceCollection().AddSerializer().BuildServiceProvider();
Expand Down
6 changes: 6 additions & 0 deletions ...ionRegressionTests.CollectionInterfaceConcreteList_Formatted_MatchesSnapshot.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
0x002F [#1 TagDelimited Id: 0 SchemaType: Encoded RuntimeType: System.Collections.Generic.List`1[System.Int32] (name: Encoded "TypeName "System.Collections.Generic.List`1[[int]]" (hash 77903B0D)" (System.Collections.Generic.List`1[[System.Int32]]))] Value: {
0x0030 [#2 VarInt Id: 0 SchemaType: Expected] Value: 3 (0x3)
0x0032 [#3 VarInt Id: 1 SchemaType: Expected] Value: 4 (0x4)
0x0034 [#4 VarInt Id: 1 SchemaType: Expected] Value: 8 (0x8)
0x0036 [#5 VarInt Id: 1 SchemaType: Expected] Value: 12 (0xC)
0x0038 }
7 changes: 7 additions & 0 deletions ...ressionTests.DictionaryInterfaceConcreteDictionary_Formatted_MatchesSnapshot.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
0x003E [#1 TagDelimited Id: 0 SchemaType: Encoded RuntimeType: System.Collections.Generic.Dictionary`2[System.String,System.Int32] (name: Encoded "TypeName "System.Collections.Generic.Dictionary`2[[string],[int]]" (hash ABFDFCFE)" (System.Collections.Generic.Dictionary`2[[System.String],[System.Int32]]))] Value: {
0x003F [#2 VarInt Id: 1 SchemaType: Expected] Value: 2 (0x2)
0x0041 [#3 LengthPrefixed Id: 2 SchemaType: Expected] Value: (length: 1b) ["a"]
0x0044 [#4 VarInt Id: 2 SchemaType: Expected] Value: 2 (0x2)
0x0046 [#5 LengthPrefixed Id: 2 SchemaType: Expected] Value: (length: 1b) ["b"]
0x0049 [#6 VarInt Id: 2 SchemaType: Expected] Value: 4 (0x4)
0x004B }
6 changes: 6 additions & 0 deletions ...ionRegressionTests.EnumerableInterfaceConcreteList_Formatted_MatchesSnapshot.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
0x002F [#1 TagDelimited Id: 0 SchemaType: Encoded RuntimeType: System.Collections.Generic.List`1[System.Int32] (name: Encoded "TypeName "System.Collections.Generic.List`1[[int]]" (hash 77903B0D)" (System.Collections.Generic.List`1[[System.Int32]]))] Value: {
0x0030 [#2 VarInt Id: 0 SchemaType: Expected] Value: 3 (0x3)
0x0032 [#3 VarInt Id: 1 SchemaType: Expected] Value: 4 (0x4)
0x0034 [#4 VarInt Id: 1 SchemaType: Expected] Value: 8 (0x8)
0x0036 [#5 VarInt Id: 1 SchemaType: Expected] Value: 12 (0xC)
0x0038 }
6 changes: 6 additions & 0 deletions ...ollectionRegressionTests.ListInterfaceConcreteList_Formatted_MatchesSnapshot.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
0x002F [#1 TagDelimited Id: 0 SchemaType: Encoded RuntimeType: System.Collections.Generic.List`1[System.Int32] (name: Encoded "TypeName "System.Collections.Generic.List`1[[int]]" (hash 77903B0D)" (System.Collections.Generic.List`1[[System.Int32]]))] Value: {
0x0030 [#2 VarInt Id: 0 SchemaType: Expected] Value: 3 (0x3)
0x0032 [#3 VarInt Id: 1 SchemaType: Expected] Value: 4 (0x4)
0x0034 [#4 VarInt Id: 1 SchemaType: Expected] Value: 8 (0x8)
0x0036 [#5 VarInt Id: 1 SchemaType: Expected] Value: 12 (0xC)
0x0038 }
6 changes: 6 additions & 0 deletions ...ssionTests.ReadOnlyCollectionInterfaceConcreteList_Formatted_MatchesSnapshot.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
0x002F [#1 TagDelimited Id: 0 SchemaType: Encoded RuntimeType: System.Collections.Generic.List`1[System.Int32] (name: Encoded "TypeName "System.Collections.Generic.List`1[[int]]" (hash 77903B0D)" (System.Collections.Generic.List`1[[System.Int32]]))] Value: {
0x0030 [#2 VarInt Id: 0 SchemaType: Expected] Value: 3 (0x3)
0x0032 [#3 VarInt Id: 1 SchemaType: Expected] Value: 4 (0x4)
0x0034 [#4 VarInt Id: 1 SchemaType: Expected] Value: 8 (0x8)
0x0036 [#5 VarInt Id: 1 SchemaType: Expected] Value: 12 (0xC)
0x0038 }
7 changes: 7 additions & 0 deletions ...ests.ReadOnlyDictionaryInterfaceConcreteDictionary_Formatted_MatchesSnapshot.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
0x003E [#1 TagDelimited Id: 0 SchemaType: Encoded RuntimeType: System.Collections.Generic.Dictionary`2[System.String,System.Int32] (name: Encoded "TypeName "System.Collections.Generic.Dictionary`2[[string],[int]]" (hash ABFDFCFE)" (System.Collections.Generic.Dictionary`2[[System.String],[System.Int32]]))] Value: {
0x003F [#2 VarInt Id: 1 SchemaType: Expected] Value: 2 (0x2)
0x0041 [#3 LengthPrefixed Id: 2 SchemaType: Expected] Value: (length: 1b) ["a"]
0x0044 [#4 VarInt Id: 2 SchemaType: Expected] Value: 2 (0x2)
0x0046 [#5 LengthPrefixed Id: 2 SchemaType: Expected] Value: (length: 1b) ["b"]
0x0049 [#6 VarInt Id: 2 SchemaType: Expected] Value: 4 (0x4)
0x004B }
6 changes: 6 additions & 0 deletions ...nRegressionTests.ReadOnlyListInterfaceConcreteList_Formatted_MatchesSnapshot.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
0x002F [#1 TagDelimited Id: 0 SchemaType: Encoded RuntimeType: System.Collections.Generic.List`1[System.Int32] (name: Encoded "TypeName "System.Collections.Generic.List`1[[int]]" (hash 77903B0D)" (System.Collections.Generic.List`1[[System.Int32]]))] Value: {
0x0030 [#2 VarInt Id: 0 SchemaType: Expected] Value: 3 (0x3)
0x0032 [#3 VarInt Id: 1 SchemaType: Expected] Value: 4 (0x4)
0x0034 [#4 VarInt Id: 1 SchemaType: Expected] Value: 8 (0x8)
0x0036 [#5 VarInt Id: 1 SchemaType: Expected] Value: 12 (0xC)
0x0038 }
5 changes: 5 additions & 0 deletions ...egressionTests.ReadOnlySetInterfaceConcreteHashSet_Formatted_MatchesSnapshot.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
0x0035 [#1 TagDelimited Id: 0 SchemaType: Encoded RuntimeType: System.Collections.Generic.HashSet`1[System.String] (name: Encoded "TypeName "System.Collections.Generic.HashSet`1[[string]]" (hash DCA1FD98)" (System.Collections.Generic.HashSet`1[[System.String]]))] Value: {
0x0036 [#2 VarInt Id: 1 SchemaType: Expected] Value: 2 (0x2)
0x0038 [#3 LengthPrefixed Id: 2 SchemaType: Expected] Value: (length: 1b) ["a"]
0x003B [#4 LengthPrefixed Id: 2 SchemaType: Expected] Value: (length: 1b) ["b"]
0x003E }
5 changes: 5 additions & 0 deletions ...lectionRegressionTests.SetInterfaceConcreteHashSet_Formatted_MatchesSnapshot.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
0x0035 [#1 TagDelimited Id: 0 SchemaType: Encoded RuntimeType: System.Collections.Generic.HashSet`1[System.String] (name: Encoded "TypeName "System.Collections.Generic.HashSet`1[[string]]" (hash DCA1FD98)" (System.Collections.Generic.HashSet`1[[System.String]]))] Value: {
0x0036 [#2 VarInt Id: 1 SchemaType: Expected] Value: 2 (0x2)
0x0038 [#3 LengthPrefixed Id: 2 SchemaType: Expected] Value: (length: 1b) ["a"]
0x003B [#4 LengthPrefixed Id: 2 SchemaType: Expected] Value: (length: 1b) ["b"]
0x003E }
Loading