Add concrete interface collection codec snapshots#10106
Merged
ReubenBond merged 2 commits intoMay 16, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ReubenBond
force-pushed
the
followup-interface-codec-snapshots
branch
from
8275af1 to
aa3d164
Compare
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
The original interface collection codec PR was merged before the final concrete runtime codec snapshot coverage landed in the merge commit.
Solution
This follow-up adds focused BitStreamFormatter snapshot tests which serialize concrete
List<T>,HashSet<T>, andDictionary<TKey,TValue>instances through interface-typed serializers. The tests assert that interface fallback codec aliases are not used when a concrete runtime codec exists, and the snapshots capture the concrete runtime codec payloads reviewers should expect.Microsoft Reviewers: Open in CodeFlow