Skip to content

[inflight/candidate] Revert Fix Android app bar inset background coloring#35856

Merged
kubaflo merged 1 commit into
dotnet:inflight/candidatefrom
HarishwaranVijayakumar:revert/pr-35601
Jun 10, 2026
Merged

[inflight/candidate] Revert Fix Android app bar inset background coloring#35856
kubaflo merged 1 commit into
dotnet:inflight/candidatefrom
HarishwaranVijayakumar:revert/pr-35601

Conversation

@HarishwaranVijayakumar

Copy link
Copy Markdown
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

The following Android UI tests fail due to changes introduced by #35601:

  • TestIssue9419
  • ReusingNavigationPageDoesntBreakLayout
  • NavigationPageFeatureTests

These failures were observed in the candidate PR build and require further analysis.

Reason

PR #35601 introduces AppBarLayout background sync logic that interferes with existing navigation page layout behavior. Reverting to unblock the candidate branch while further investigation is conducted.

A more comprehensive solution is being pursued in #35463 ("Make Android system chrome follow MAUI bar colors"), which takes a window-level approach rather than modifying AppBarLayout directly.

Changes

  • Removed AppBarLayout background sync logic (TryUpdateAppBarBackground, CloneDrawable, AppBarBackgroundState) from ToolbarExtensions.cs
  • Removed GetPlatformAppBarLayout and AssertAppBarTopInsetUsesColor test helpers
  • Removed BarBackgroundColorColorsEdgeToEdgeTopInsetArea (NavigationPage) and ShellBackgroundColorsEdgeToEdgeTopInsetArea (Shell) tests

@NirmalKumarYuvaraj NirmalKumarYuvaraj added platform/android community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jun 10, 2026
@sheiksyedm sheiksyedm marked this pull request as ready for review June 10, 2026 15:52
@sheiksyedm sheiksyedm requested a review from kubaflo June 10, 2026 15:52
@kubaflo kubaflo merged commit a7395a2 into dotnet:inflight/candidate Jun 10, 2026
7 of 16 checks passed
@github-actions github-actions Bot added this to the .NET 10.0 SR8 milestone Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-controls-navigationpage community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants