Fix Android app bar inset background coloring by ne0rrmatrix · Pull Request #35601 · dotnet/maui

ne0rrmatrix · 2026-05-25T03:57:24Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Fixes #35568

Summary

sync the Android AppBarLayout background and status bar foreground with the MAUI toolbar background
retry the AppBar sync after the toolbar is attached so the real native parent AppBar gets updated
add Android device regression tests covering the edge-to-edge top inset area for both NavigationPage and Shell

Testing

dotnet build src/Controls/tests/DeviceTests/Controls.DeviceTests.csproj -c Release -f net10.0-android /p:TreatWarningsAsErrors=false /p:AndroidPackageFormat=apk
adb -s emulator-5554 shell am instrument -w -r -e TestFilter "Category=NavigationPage" com.microsoft.maui.controls.devicetests/com.microsoft.maui.controls.devicetests.TestInstrumentation
adb -s emulator-5554 shell am instrument -w -r -e TestFilter "Category=Shell" com.microsoft.maui.controls.devicetests/com.microsoft.maui.controls.devicetests.TestInstrumentation

> [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## What Restrict the agentic-labeler to apply **exactly one `area-*` label** per item, while still allowing multiple `platform/*` labels. ## Why Backfilling the 26 items affected by the `max:1` bug (fixed in dotnet#35540) revealed that the labeler occasionally applies multiple `area-*` labels for ambiguous cases: - **dotnet#35501** got both `area-layout` and `area-safearea` - **dotnet#35490** got both `area-navigation` and `area-controls-tabbedpage` The intended behavior is exactly one best-fit `area-*` per item (a label-quota distinction not expressible via `safe-outputs.add-labels.max:` — that field counts total labels, not labels per prefix). The fix has to live in the agent's instructions. ## Changes ### `.github/skills/agentic-labeler/SKILL.md` - Scope section: "Exactly one `area-*`" / "One or more `platform/*`". - Area rules section: renamed heading, changed "pick one or more" → "apply exactly one". - New **tie-breaking heuristics** for the area-* selection: - Specific control beats generic area (`area-controls-tabbedpage` over `area-navigation`) - Sub-area beats parent area (`area-safearea` over `area-layout`) - Subject-matter focus beats incidental touch - When genuinely tied, prefer the user-visible feature - Mixed-PR rule clarified: infra-primary PRs get only `area-infrastructure` (no second product area). ### `.github/workflows/agentic-labeler.md` - Added explicit reinforcement in the workflow prompt: "Apply exactly one `area-*` label … and one or more `platform/*` labels". - Fixed two stale `max: 1` comments left over from dotnet#35540 (the cap is now `max: 10`). ### `.github/workflows/agentic-labeler.lock.yml` - Regenerated via `gh aw compile`. Diff is frontmatter-hash + heredoc rotations only — no semantic change to the compiled config. ## Validation - Reviewed all 21 existing eval scenarios in `tests/eval.yaml` — none assert multiple `area-*` labels, so no test updates needed. - The `max: 10` cap in `safe-outputs` is preserved as a blast-radius safeguard (one area + several platforms still fit comfortably). ## Follow-ups (not in this PR) If accuracy of the "one area" rule drops below ~95% in eval runs, consider adding a deterministic post-step that strips extra `area-*` labels per a known precedence list (Option B from the design discussion). Co-authored-by: bot <bot@test> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

## Description Extends the `maui-copilot` DevDiv pipeline (pipeline 27723) with a 3-stage architecture that runs real UI tests on platform-pool agents and reports results directly in the AI summary PR comment. ### Pipeline Workflow ``` ┌─────────────────────────────────────────────────────────┐ │ Stage 1: ReviewPR │ │ │ │ STEP 1: Branch Setup (checkout + cherry-pick PR) │ │ STEP 2: Detect UI Test Categories │ │ STEP 3: Run Detected UI Tests (in-process, fast) │ │ STEP 4: Regression Cross-Reference │ │ STEP 5: Gate — verify tests fail/pass before/after fix │ │ STEP 6: Code Review — deep analysis via Copilot agent │ │ │ │ Outputs → CopilotLogs artifact + detectedCategories │ └──────────────────────┬──────────────────────────────────┘ │ ┌──────────────────────▼──────────────────────────────────┐ │ Stage 2: RunDeepUITests (platform-pool agent) │ │ │ │ iOS: AcesShared Tahoe + iOS 26.4 │ │ Android: ubuntu-22.04 + KVM + AVD │ │ │ │ Runs BuildAndRunHostApp.ps1 per detected category │ │ Outputs → drop-deep-uitests artifact (TRX + diffs) │ └──────────────────────┬──────────────────────────────────┘ │ ┌──────────────────────▼──────────────────────────────────┐ │ Stage 3: PostResults │ │ │ │ 1. Download CopilotLogs (review content files) │ │ 2. Download drop-deep-uitests (TRX results) │ │ 3. Merge deep results into uitests/content.md │ │ 4. Post full AI Summary comment on PR │ │ 5. Apply labels (s/agent-reviewed, etc.) │ │ │ │ One comment with everything — no patching needed │ └─────────────────────────────────────────────────────────┘ ``` ### What's New **Deep UI Test Execution (Stage 2)** - Runs detected UI test categories on proper platform-pool agents (not in-process on Linux) - **iOS**: AcesShared Tahoe agents with iOS 26.4 simulator, iPhone 11 Pro (matching `ios-26` baselines from PR dotnet#35061) - **Android**: ubuntu-22.04 with KVM, AVD boot with `-partition-size 2048`, `ignoreHiddenApiPolicyError` capability - TRX results + snapshot-diff PNGs published as `drop-deep-uitests` artifact **Unified Comment Posting (Stage 3)** - Comment posting and label application deferred to Stage 3 (after deep tests complete) - Single AI summary comment includes ALL results: code review + deep test results - Nested collapsible `<details>` for failed tests with full error + stack trace - Dynamic section title: `🧪 UI Tests — CollectionView, TabbedPage` - Artifact download link for snapshot-diff PNGs **Android Emulator Improvements** - AVD boot step with proper partition size, ADB key pre-authorization, boot wait - `DEVICE_UDID` pass-through prevents double emulator boot - Disk cleanup on hosted ubuntu agents (frees ~22GB) - KVM enablement + `appium:ignoreHiddenApiPolicyError` for API 30 **iOS Simulator Improvements** - Tahoe pool demand ensures macOS 26.x agents - Explicit iOS 26.4 download via latest Xcode - Auto-creates iPhone 11 Pro for baseline resolution match ### Validation Tested across 30+ pipeline iterations on 6 PRs: | PR | iOS | Android | |---|---|---| | 35358 (ViewBaseTests) | **112/112 ALL PASS** ✅ | **118/119 PASS** ✅ | | 35359 (TabbedPage) | 44/50 (1 real failure) | 74/75 (1 real failure) | | 35356 (CollectionView) | **415/417 PASS** ✅ | 593/619 (26 real failures) | --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@PureWeen

…35589) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! Backport of dotnet#35460 to `main`. /cc @PureWeen Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com>

github-actions · 2026-05-25T03:57:32Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35601

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35601"

dotnet-policy-service · 2026-05-25T03:57:49Z

Hey there @@ne0rrmatrix! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

kubaflo · 2026-05-26T09:41:35Z

/review -b feature/refactor-copilot-yml

kubaflo · 2026-05-26T18:35:42Z

/review -b feature/refactor-copilot-yml

MauiBot · 2026-05-26T22:54:10Z

🤖 AI Summary

👋 @ne0rrmatrix — new AI review results are available. Please review the latest session below.

📊 Review Session — afede3d · Fix Android app bar inset background coloring · 2026-05-26 22:54 UTC

🚦 Gate — Test Before & After Fix