[iOS / Mac] Fix CollectionView.ScrollTo(index) silently failing whenIsGrouped="True" by Dhivya-SF4094 · Pull Request #35609 · dotnet/maui

Dhivya-SF4094 · 2026-05-25T14:19:04Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details:

When a CollectionView has IsGrouped="True", calling ScrollTo(index) should scroll to the item at that position. This works correctly on Android, but on iOS, MacCatalyst, and Windows scrolled not at all.

Root Cause:

When ScrollTo(index) is called with no explicit group (GroupIndex == -1), both iOS paths fell through to:
return NSIndexPath.Create(0, args.Index); // always section 0
For a grouped CollectionView with multiple sections, any flat index that exceeded the count of section 0 produced an invalid NSIndexPath — UICollectionView.ScrollToItem silently did nothing.
Additionally, IsIndexPathValid in the Items1 handler (ItemsViewHandler.iOS.cs) lacked a null guard. Since ConvertFlatIndexToGroupedIndexPath returns null for out-of-range indices, this could cause a NullReferenceException.

Description of change:

Added ConvertFlatIndexToGroupedIndexPath to both ItemsViewHandler.iOS.cs and ItemsViewHandler2.iOS.cs :
Activated only when groupable.IsGrouped == true.
Bounds-checks flat index against itemsSource.ItemCount before walking groups
Iterates IItemsViewSource.ItemCountInGroup(section) to resolve the NSIndexPath(section, item). Returns null for out-of-range indices (safely handled by
Also added indexPath is null || guard to IsIndexPathValid (Items1) to NullReferenceException on out-of-range scroll requests.

Validated the behaviour in the following platforms

Android
Windows
iOS
Mac

Fixes

Fixes #35326

Screenshots

Before	After
35326_BeforeFix.mov	35326_AfterFix.mov

…ouped="True"

github-actions · 2026-05-25T14:19:15Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35609

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35609"

kubaflo · 2026-05-26T09:40:09Z

/review -b feature/refactor-copilot-yml

MauiBot

Expert Review — 1 findings

See inline comments for details.

Dhivya-SF4094 · 2026-06-01T13:38:19Z

Analyzed the AI summary, confirmed the legitimate concern, and applied the appropriate resolution.

kubaflo · 2026-06-01T13:45:20Z

/review -b feature/enhanced-reviewer

MauiBot

Expert Review — 1 findings

See inline comments for details.

MauiBot · 2026-06-01T14:53:53Z

+
+	public override string Issue => "CollectionView.ScrollTo(index) doesn't work correctly when IsGrouped=\"True\" on iOS and MacCatalyst";
+
+	[Test]


[major] Regression prevention - This UI test is discovered when the CollectionView category runs on every compiled test platform, but the PR fix only changes the iOS/MacCatalyst handlers and the issue page metadata scopes the scenario to iOS/MacCatalyst. _IssuesUITest does not use PlatformAffected to skip NUnit test discovery, so please explicitly scope this test to iOS/MacCatalyst (or fix/validate the behavior on Windows too) to avoid adding a latent non-iOS UI test failure.

MauiBot

AI Review Summary

@Dhivya-SF4094 — new AI review results are available based on this last commit: dc5a553.
Updated Test To request a fresh review after new comments or commits, comment /review rerun.

Review Sessions — click to expand

Gate — Test Before & After Fix

Gate Result: ✅ PASSED

Platform: IOS · Base: main · Merge base: b0ea772f

Test	Without Fix (expect FAIL)	With Fix (expect PASS)
🖥️ Issue35326 `Issue35326`	✅ FAIL — 355s	✅ PASS — 125s

🔴 Without fix — 🖥️ Issue35326: FAIL ✅ · 355s

  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 721 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 700 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 5.01 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Foldable/src/Controls.Foldable.csproj (in 6.6 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj (in 6.63 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Xaml/Controls.Xaml.csproj (in 6.62 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 6.62 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj (in 6.64 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 6.64 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Maps/src/Controls.Maps.csproj (in 6.69 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/maps/src/Maps.csproj (in 5.98 sec).
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-ios26.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-ios26.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-ios26.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Maps.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Controls.Foldable -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Foldable.dll
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Xaml.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-ios26.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Maps.dll
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-ios/iossimulator-arm64/Controls.TestCases.HostApp.dll
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.

Build succeeded.

/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
    1 Warning(s)
    0 Error(s)

Time Elapsed 00:03:07.69
  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/CustomAttributes/Controls.CustomAttributes.csproj (in 721 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 721 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/VisualTestUtils/VisualTestUtils.csproj (in 721 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 722 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 729 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Core/UITest.Core.csproj (in 1 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 823 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 845 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.NUnit/UITest.NUnit.csproj (in 1.27 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Appium/UITest.Appium.csproj (in 2.93 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Analyzers/UITest.Analyzers.csproj (in 3.88 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/VisualTestUtils.MagickNet/VisualTestUtils.MagickNet.csproj (in 6.41 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.iOS.Tests/Controls.TestCases.iOS.Tests.csproj (in 7.21 sec).
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Controls.CustomAttributes -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  VisualTestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  VisualTestUtils.MagickNet -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  UITest.NUnit -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  UITest.Appium -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  UITest.Analyzers -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.iOS.Tests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.07]   Discovering: Controls.TestCases.iOS.Tests
[xUnit.net 00:00:00.21]   Discovered:  Controls.TestCases.iOS.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 6/1/2026 7:08:28 AM FixtureSetup for Issue35326(iOS)
>>>>> 6/1/2026 7:08:33 AM GroupedCollectionViewScrollToIndexScrollsToCorrectItem Start
>>>>> 6/1/2026 7:08:49 AM GroupedCollectionViewScrollToIndexScrollsToCorrectItem Stop
>>>>> 6/1/2026 7:08:49 AM Log types: syslog, crashlog, performance, safariConsole, safariNetwork, server
  Failed GroupedCollectionViewScrollToIndexScrollsToCorrectItem [17 s]
  Error Message:
   System.TimeoutException : Timed out waiting for element...
  Stack Trace:
     at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
   at Microsoft.Maui.TestCases.Tests.Issues.Issue35326.GroupedCollectionViewScrollToIndexScrollsToCorrectItem() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue35326.cs:line 23
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

NUnit Adapter 4.5.0.0: Test execution complete
Results File: /Users/cloudtest/vss/_work/1/s/CustomAgentLogsTmp/UITests/TestResults/Issue35326.trx

Test Run Failed.
Total tests: 1
     Failed: 1
 Total time: 1.7540 Minutes
>>> TRX_RESULT_FILE: /Users/cloudtest/vss/_work/1/s/CustomAgentLogsTmp/UITests/TestResults/Issue35326.trx

🟢 With fix — 🖥️ Issue35326: PASS ✅ · 125s

  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 437 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 454 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 409 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 505 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 525 ms).
  6 of 11 projects are up-to-date for restore.
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-ios26.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-ios26.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-ios26.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Maps.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Microsoft.AspNetCore.Components.WebView.Maui -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-ios26.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Maps.dll
  Controls.Foldable -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Foldable.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Xaml.dll
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-ios/iossimulator-arm64/Controls.TestCases.HostApp.dll
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.

Build succeeded.

/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
    1 Warning(s)
    0 Error(s)

Time Elapsed 00:01:03.94
  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 417 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 422 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 357 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 446 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 466 ms).
  8 of 13 projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Controls.CustomAttributes -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.80-ci+azdo.14247964
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  VisualTestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  UITest.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  VisualTestUtils.MagickNet -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.NUnit -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  UITest.Appium -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  UITest.Analyzers -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.iOS.Tests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.06]   Discovering: Controls.TestCases.iOS.Tests
[xUnit.net 00:00:00.20]   Discovered:  Controls.TestCases.iOS.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 6/1/2026 7:10:51 AM FixtureSetup for Issue35326(iOS)
>>>>> 6/1/2026 7:10:56 AM GroupedCollectionViewScrollToIndexScrollsToCorrectItem Start
>>>>> 6/1/2026 7:10:58 AM GroupedCollectionViewScrollToIndexScrollsToCorrectItem Stop
  Passed GroupedCollectionViewScrollToIndexScrollsToCorrectItem [2 s]
NUnit Adapter 4.5.0.0: Test execution complete
Results File: /Users/cloudtest/vss/_work/1/s/CustomAgentLogsTmp/UITests/TestResults/Issue35326.trx

Test Run Successful.
Total tests: 1
     Passed: 1
 Total time: 26.7576 Seconds
>>> TRX_RESULT_FILE: /Users/cloudtest/vss/_work/1/s/CustomAgentLogsTmp/UITests/TestResults/Issue35326.trx

📁 Fix files reverted (3 files)

eng/pipelines/ci-copilot.yml
src/Controls/src/Core/Handlers/Items/ItemsViewHandler.iOS.cs
src/Controls/src/Core/Handlers/Items2/ItemsViewHandler2.iOS.cs

UI Tests — CollectionView

Detected UI test categories: CollectionView

✅ Deep UI tests — 416 passed, 0 failed across 1 category on platform-pool agent (replaces in-process counts above).

🧪 UI Test Execution Results (deep, platform pool)

Category	Tests	Snapshot diffs
`CollectionView`	416/418 ✓	—
📎 Download `drop-deep-uitests` artifact (TRX + snapshot diffs)

Pre-Flight — Context & Validation

Issue: #35326 - CollectionView.ScrollTo(index) doesn't work correctly when IsGrouped="True" on iOS and MacCatalyst
PR: #35609 - Fix grouped CollectionView ScrollTo(index) on iOS/MacCatalyst
Platforms Affected: iOS, MacCatalyst
Files Changed: 2 implementation, 2 test

Key Findings

The bug is an iOS UICollectionView index-path semantics mismatch: grouped CollectionView.ScrollTo(index) supplies a flat item index, but native scrolling requires section/item coordinates.
The PR fix correctly converts a flat grouped index to NSIndexPath(section,item), but duplicates the same conversion loop in both Items and Items2 handlers.
Test coverage is UI/Appium-based through Issue35326 and targets the CollectionView category.
GitHub CLI API access was unavailable in this environment, so pre-flight used the checked-out PR branch, local diff, commit metadata, and repository files.

Code Review Summary

Verdict: LGTM
Confidence: high
Errors: 0 | Warnings: 1 | Suggestions: 1

Key code review findings:
Duplicate grouped flat-index conversion exists in both `ItemsViewHandler.iOS.cs` and `ItemsViewHandler2.iOS.cs`; centralizing would reduce Items/Items2 divergence risk.-

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #35609	Convert grouped flat index to inside both iOS handlers	PASSED (Gate, prior step)	4 files	Original PR fix; functionally sound but duplicates conversion logic

Code Review — Deep Analysis

Code PR #35609Review

Independent Assessment

What this changes: The iOS and Items2 iOS CollectionView handlers translate ScrollTo(index) calls on grouped CollectionView instances from a flat item index into the native NSIndexPath(section,item) required by UICollectionView.ScrollToItem. The PR also adds a UI regression page and Appium test for issue 35326.

Inferred motivation: On iOS/MacCatalyst, ScrollTo(index) with IsGrouped=true previously treated the flat index as an item in section 0, so indexes beyond the first group did not scroll to the expected grouped item.

Reconciliation with PR Narrative

Author claims: Issue 35326 reports that grouped CollectionView.ScrollTo(index) does not work correctly on iOS/MacCatalyst. The PR fixes grouped flat-index scrolling and adds an end-to-end UI test.
Agreement/disagreement: The local diff matches the claimed issue and addresses the iOS section/item mapping problem. The added test exercises the reported endpoint scenario, ScrollTo(49) on 5 groups of 10 items.

Findings

Conversion logic is duplicated between Items and Items2 handlersWarning ####
The same flat-index-to-grouped-index-path loop is implemented in both src/Controls/src/Core/Handlers/Items/ItemsViewHandler.iOS.cs and src/Controls/src/Core/Handlers/Items2/ItemsViewHandler2.iOS.cs. The logic is correct for the added test, but duplication between legacy Items and Items2 handlers increases the chance of future divergence.

The UI test covers index 0 and index 49 for uniform groups. Additional lower-level or UI coverage for group-boundary indexes (for example 10), uneven group sizes, and empty groups would further protect the index math.####

Failure Modes

Negative or out-of-range flat indexes must not crash; the PR returns null and the existing validity check prevents scrolling.
Boundary flat indexes must map to the first item of the next group rather than the last item of the previous group.
Explicit grouped calls with groupIndex >= 0 must retain existing behavior and not be remapped.

Blast Radius

Low-to-medium. The implementation is scoped to iOS/MacCatalyst CollectionView/CarouselView handler ScrollToRequested handling for grouped views with GroupIndex == -1; ungrouped scrolling and item-based scrolling remain unchanged.

Verdict: LGTM

Confidence: high
Summary: The PR fix is functionally sound for the reported bug. The main improvement opportunity is maintainability: centralize the shared index conversion rather than duplicating it in both iOS handler implementations.

Fix — Analysis & Comparison

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix	Centralize grouped flat-index conversion in internal `IndexPathHelpers.GetIndexPathForFlatIndex`, then call it from both iOS handlers	PASS	3 files	Better than PR fix: same behavior, less duplication, no public API change
PR	PR #35609	Duplicate grouped flat-index conversion locally in both iOS handlers	PASSED (Gate)	4 files	Original PR; functionally sound but less maintainable

Cross-Pollination

Model	Round	New Ideas?	Details
maui-expert-reviewer	1	Yes	Proposed centralizing conversion in `IndexPathHelpers` or moving resolution into controllers/source abstractions; recommended helper/controller approaches as lowest risk.
maui-expert-reviewer	refinement	Yes	After RS0016 failure, confirmed helper should remain internal to avoid public API surface changes.

Exhausted: No - stopped because candidate #1 passed targeted iOS validation and is demonstrably better than the PR's duplicated implementation.
Selected Fix: Candidate #1 - preserves PR behavior and passing Issue35326 coverage while reducing Items/Items2 divergence risk.

Report — Final Recommendation

Comparative Report - PR #35609

Candidates Compared

Rank	Candidate	Regression Result	Assessment
1	`pr-plus-reviewer`	PASS inherited from PR gate on iOS; no iOS runtime behavior change	Best available candidate. It keeps the functionally correct PR fix and applies the expert reviewer's actionable feedback by scoping the new UI test to iOS/MacCatalyst, avoiding latent non-iOS test exposure.
2	`try-fix-1`	PASS (`dotnet build ... net10.0-ios26.0`; `BuildAndRunHostApp.ps1 -Platform ios -TestFilter ...Issue35326`)	Strong implementation candidate. It centralizes the grouped flat-index conversion in `IndexPathHelpers`, reducing duplication between Items and Items2, but it does not address the expert reviewer's test-platform scoping finding.
3	`pr`	PASS (gate: tests fail without fix and pass with fix)	Functionally correct for the reported iOS/MacCatalyst bug, but it duplicates conversion logic in both handler implementations and leaves the shared UI test discoverable outside the fixed platform scope.

Analysis

The raw PR fix correctly handles the root cause: for grouped iOS/MacCatalyst CollectionView scrolling, a flat MAUI index must be mapped to the native NSIndexPath(section, item). The gate already proved the regression test fails without the PR fix and passes with it.

try-fix-1 is the cleanest handler implementation because it factors the conversion into an internal IndexPathHelpers.GetIndexPathForFlatIndex helper and uses it from both Items and Items2. It also passed targeted iOS validation. However, the expert review of the PR surfaced a separate release-readiness problem in the added shared UI test: the test is not platform-scoped even though the fix is iOS/MacCatalyst-specific. Since try-fix-1 did not include that correction, it remains behind pr-plus-reviewer.

pr-plus-reviewer is the only candidate that incorporates the expert reviewer's actionable feedback while preserving the already-passing iOS behavior. Its remaining weakness is the duplicate conversion logic in the handlers, but that is a maintainability concern rather than a correctness or CI-scope risk. A future ideal patch would combine try-fix-1's shared helper with pr-plus-reviewer's platform-scoped test, but that combined patch is not one of the available STEP 5a candidates.

Winner

pr-plus-reviewer wins because it preserves the verified PR fix and addresses the highest-severity expert reviewer finding. No candidate with a failed regression result was ranked above a passing candidate.

Future Action — review latest findings

No alternative fix was selected for this run. Review the session findings and CI results before merging.

…sGrouped="True" (#35609)  > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details: When a CollectionView has IsGrouped="True", calling ScrollTo(index) should scroll to the item at that position. This works correctly on Android, but on iOS, MacCatalyst, and Windows scrolled not at all. ### Root Cause: - When ScrollTo(index) is called with no explicit group (GroupIndex == -1), both iOS paths fell through to: return NSIndexPath.Create(0, args.Index); // always section 0 - For a grouped CollectionView with multiple sections, any flat index that exceeded the count of section 0 produced an invalid NSIndexPath — UICollectionView.ScrollToItem silently did nothing. - Additionally, IsIndexPathValid in the Items1 handler (ItemsViewHandler.iOS.cs) lacked a null guard. Since ConvertFlatIndexToGroupedIndexPath returns null for out-of-range indices, this could cause a NullReferenceException. ### Description of change: - Added ConvertFlatIndexToGroupedIndexPath to both ItemsViewHandler.iOS.cs and ItemsViewHandler2.iOS.cs : - Activated only when groupable.IsGrouped == true. - Bounds-checks flat index against itemsSource.ItemCount before walking groups - Iterates IItemsViewSource.ItemCountInGroup(section) to resolve the NSIndexPath(section, item). Returns null for out-of-range indices (safely handled by - Also added indexPath is null || guard to IsIndexPathValid (Items1) to NullReferenceException on out-of-range scroll requests. ### Validated the behaviour in the following platforms - [ ] Android - [ ] Windows - [x] iOS - [x] Mac ### Fixes Fixes #35326 ### Screenshots | Before | After | |---------|--------| | <video src="https://github.com/user-attachments/assets/846e050f-c2fa-4bf1-a952-789c9e8466ea"> | <video src="https://github.com/user-attachments/assets/d379b495-6fbc-47f1-8e57-36fc472a81ed"> |

Extracts the manual SR7 release-readiness analysis into a deterministic, repeatable workflow: * New skill at .github/skills/release-readiness/ — single PowerShell script (Get-ReleaseReadiness.ps1) that surveys an SR branch, extracts source PRs from commits (including 'Backport of #NNNN' bodies), computes CI status from public + internal AzDO pipelines, and classifies regression issues into nine buckets (in-sr-active, rejected-from-sr, no-fix-yet, merged-on-main-no-backport, etc.). * New agent at .github/agents/release-readiness-agent.agent.md — delegating wrapper that resolves the SR branch, runs the script, and enriches 'rejected-from-sr' candidates with WorkIQ context (chat history, PR review feedback). PowerShell can't invoke MCP, so the script identifies WHICH PRs need enrichment and the agent does it. * methodology.md documents the three gotchas the analysis must handle: cherry-pick number swap (SR backports get new PR numbers), empty closedByPullRequestsReferences (must walk timeline cross-references), and forward-flow / non-main merges (PRs can land in inflight/current only, bypassing main — verified against real example #35609). * 15 tests (12 unit + 3 E2E) all pass. E2E validates against SR7 known-answer set: #35313 in-sr-active, #35344 in-sr-active (via follow-on fix #35664), #35326 out-of-scope (no regressed-in-* label), #35771 no-fix-yet. Registered in .github/copilot-instructions.md alongside existing agents and skills. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

> [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Summary Adds a deterministic, evidence-backed release-readiness skill that produces a single "Is `release/X.Y.Zxx-srN` (or preview) ready to ship?" report for .NET MAUI release branches — both **Servicing Releases (SR)** and **Previews**, in both **in-flight** and **candidate** (pre-cut) modes. Supersedes #35754. ## What it does `Get-ReleaseReadiness.ps1` walks the SR branch, classifies open `regressed-in-*` issues against branch contents, computes the source-PR list (handling cherry-pick number swaps + non-main forward-flow), and rolls up an "is this ready to ship?" verdict with a **Blocking** summary hoisted to the top of the report. Posts/refreshes a single `[Release Readiness]` GitHub tracking issue per release lane (idempotent via a semantic hash marker — only reposts when something meaningfully changed). See **[issue #35876 (SR8)](#35876 for a live example. ## Ship-readiness checks A release captain sees these surface as 🟢 READY / 🟡 WATCH / 🔴 BLOCKED / ⚪ UNKNOWN rows. All BLOCKED rows roll up into the **Blocking** summary at the top. | Check | Catches | |-------|---------| | **Versions.props bump** | SR cycle hasn't been bumped on the SR branch | | **Versions.props servicing flip** | `PreReleaseVersionLabel=servicing` + `StabilizePackageVersion=true` not applied — branch silently builds prerelease packages | | **Bug template lists SR version** | Users can't file bugs against the new version | | **Main bumped to next SR cycle** | Post-SR-cut PRs on main would falsely claim to ship in the SR being shipped | | **BAR default-channel mapping** | SR branch not wired to `.NET <band> SDK` in BAR — caught the real SR8 outage | | **BAR build for SR HEAD** | No published build at the SR HEAD commit | | **Milestone for current cycle** | Fixed issues have nowhere to land | | **Milestone for next cycle** | Open issues can't roll forward when current ships | | **Stale open milestones** | Already-shipped releases accumulating untriaged issues (scoped to same major + same cycle type, 7-day grace) | | **CI Failure Scanner signals** | Fresh ci-scan issues filed in the last 24h | | **Known Build Errors** | Open KBE issues that may explain background CI noise | Each check that needs external tooling (darc, gh, milestone API) degrades to **UNKNOWN** with the exact verification command embedded — the report never silently skips. ## Expected ship date Header line surfaces the deadline. Cadence is patch-aware: - `PatchVersion` ends in 0 (`80`, `90`, `100`…) or `0` (previews) → 2nd Tuesday of the month - Anything else (`81`, `82`, `91`…) → **ASAP** hotfix, no cadence ## Custom agent `.github/agents/release-readiness-agent.agent.md` wraps the skill — handles regression-label confirmation, runs the script, then uses **WorkIQ** + **maestro MCP** to: - Patch UNKNOWN BAR rows live (e.g. when darc isn't on CI's PATH) - Add narrative context for `rejected-from-sr` PRs (chat history, review feedback) - Present the final READY / Conditionally Ready / Not Ready verdict with citations ## Testing ```bash pwsh .github/skills/release-readiness/tests/Test-ReleaseReadiness.ps1 # 447 pass / 0 fail ``` Dogfooded live against SR7 + SR8 + the .NET 11 preview lane. Caught real-world bugs: - **SR8** missing from BAR default-channel mappings (verified via `maestro_default_channels` MCP) - `.NET 10 SR6` + `.NET 10 SR7` milestones open with 76 + 63 open issues, past due - `.github/ISSUE_TEMPLATE/bug-report.yml` missing `10.0.80` entry ## Methodology gotchas (documented in `references/methodology.md`) 1. **Cherry-pick number swap** — SR backports get NEW PR numbers; can't naively grep source PR numbers 2. **Timeline cross-references** — `closedByPullRequestsReferences` returns empty for most MAUI issues; must walk `gh api .../issues/N/timeline` cross-referenced events 3. **Forward-flow / non-main merges** — a fix can merge into `inflight/current` only, not `main` (real example: PR #35609) ## Files - `.github/skills/release-readiness/SKILL.md` — skill entry point + reference docs - `.github/skills/release-readiness/scripts/Get-ReleaseReadiness.ps1` — main orchestrator (deterministic, no MCP) - `.github/skills/release-readiness/tests/Test-ReleaseReadiness.ps1` — 447-assertion test suite - `.github/skills/release-readiness/references/methodology.md` — gotchas and patterns - `.github/agents/release-readiness-agent.agent.md` — MCP-enriched agent wrapping the skill --------- Co-authored-by: bot <bot@test> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: VSC Agent <vsc-agent@example.com>

Dhivya-SF4094 and others added 6 commits May 7, 2026 16:10

Fixed CollectionView.ScrollTo(index) doesn't work correctly when IsGr…

ce00358

…ouped="True"

Updated fix for windows

71234eb

Updated test

7d7260d

Removed windows fix

e3345c2

Added fix for CollectionView1

05f411a

Updated ItemsViewHandler.iOS

aff97ba

dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label May 25, 2026

github-actions Bot added area-controls-collectionview CollectionView, CarouselView, IndicatorView platform/ios platform/macos macOS / Mac Catalyst labels May 25, 2026

sheiksyedm marked this pull request as ready for review May 26, 2026 06:54

This was referenced May 26, 2026

[PR Review Queue] 2026-05-26 #35619

Open

[PR Review Queue] 2026-05-26 PureWeen/maui#76

Open

MauiBot reviewed May 26, 2026

View reviewed changes

Comment thread src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue35326.cs

MauiBot added s/agent-fix-win AI found a better alternative fix than the PR s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) labels May 26, 2026

This comment has been minimized.

Sign in to view

Updated Test

dc5a553

MauiBot reviewed Jun 1, 2026

View reviewed changes

kubaflo approved these changes Jun 1, 2026

View reviewed changes

kubaflo changed the base branch from main to inflight/current June 1, 2026 18:11

kubaflo merged commit 8e47cad into dotnet:inflight/current Jun 1, 2026
33 checks passed

github-actions Bot added this to the .NET 10.0 SR8 milestone Jun 1, 2026

github-actions Bot mentioned this pull request Jun 2, 2026

[repo-status] Daily Status — June 2, 2026 #35698

Closed

PureWeen mentioned this pull request Jun 8, 2026

Release readiness skill — SR + Preview (supersedes #35754) #35807

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS / Mac] Fix CollectionView.ScrollTo(index) silently failing whenIsGrouped="True"#35609

[iOS / Mac] Fix CollectionView.ScrollTo(index) silently failing whenIsGrouped="True"#35609
kubaflo merged 7 commits into
dotnet:inflight/currentfrom
Dhivya-SF4094:fix-35326

Dhivya-SF4094 commented May 25, 2026

Uh oh!

github-actions Bot commented May 25, 2026 •

edited

Loading

Uh oh!

kubaflo commented May 26, 2026

Uh oh!

MauiBot left a comment

Uh oh!

Uh oh!

This comment has been minimized.

Dhivya-SF4094 commented Jun 1, 2026

Uh oh!

kubaflo commented Jun 1, 2026

Uh oh!

MauiBot left a comment

Uh oh!

MauiBot Jun 1, 2026

Uh oh!

MauiBot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		public override string Issue => "CollectionView.ScrollTo(index) doesn't work correctly when IsGrouped=\"True\" on iOS and MacCatalyst";

		[Test]

Conversation

Dhivya-SF4094 commented May 25, 2026

Issue Details:

Root Cause:

Description of change:

Validated the behaviour in the following platforms

Fixes

Screenshots

Uh oh!

github-actions Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubaflo commented May 26, 2026

Uh oh!

MauiBot left a comment

Choose a reason for hiding this comment

Expert Review — 1 findings

Uh oh!

Uh oh!

This comment has been minimized.

Dhivya-SF4094 commented Jun 1, 2026

Uh oh!

kubaflo commented Jun 1, 2026

Uh oh!

MauiBot left a comment

Choose a reason for hiding this comment

Expert Review — 1 findings

Uh oh!

MauiBot Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

MauiBot left a comment

Choose a reason for hiding this comment

AI Review Summary

Gate Result: ✅ PASSED

🧪 UI Test Execution Results (deep, platform pool)

Key Findings

Code Review Summary

Key code review findings: Duplicate grouped flat-index conversion exists in both ItemsViewHandler.iOS.cs and ItemsViewHandler2.iOS.cs; centralizing would reduce Items/Items2 divergence risk.-

Fix Candidates

Code PR #35609Review

Independent Assessment

Reconciliation with PR Narrative

Findings

Failure Modes

Blast Radius

Verdict: LGTM

Fix Candidates

Cross-Pollination

Comparative Report - PR #35609

Candidates Compared

Analysis

Winner

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented May 25, 2026 •

edited

Loading

Key code review findings:
Duplicate grouped flat-index conversion exists in both `ItemsViewHandler.iOS.cs` and `ItemsViewHandler2.iOS.cs`; centralizing would reduce Items/Items2 divergence risk.-