Skip to content

[iOS & Mac] Fix for SearchHandler retains previous page state when switching top tabs#34735

Merged
kubaflo merged 5 commits into
dotnet:inflight/currentfrom
BagavathiPerumal:fix-34693
Apr 3, 2026
Merged

[iOS & Mac] Fix for SearchHandler retains previous page state when switching top tabs#34735
kubaflo merged 5 commits into
dotnet:inflight/currentfrom
BagavathiPerumal:fix-34693

Conversation

@BagavathiPerumal

Copy link
Copy Markdown
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

When navigating between top-level Shell tabs, the SearchHandler does not update to match the currently selected page. Instead, the SearchHandler from the previously selected tab remains visible and active, showing outdated placeholder text, stale search results, and incorrect interaction state.

This issue occurs specifically on iOS and MacCatalyst and is caused by a regression introduced in a recent Shell lifecycle update. The page lifecycle events (Appearing / Disappearing) no longer fire in the correct order, preventing the toolbar from refreshing when a new ShellContent becomes active. As a result, the SearchHandler associated with the new page is never applied.

Root Cause

The issue occurs on iOS and macCatalyst because a recent Shell lifecycle update moved the _tracker.Page assignment to run before the navigation animation completes. As a result, the old page’s Disappearing event was unsubscribed prematurely, preventing it from firing. This left _isVisiblePage stuck in the true state.

When the new page appeared, SetAppeared() exited early due to the stale _isVisiblePage value, causing UpdateShellToMyPage() to never execute. This disrupted the normal Shell page lifecycle and prevented the toolbar from updating. As a result, the SearchHandler, TitleView, and ToolbarItems from the previous tab remained visible instead of being replaced with the new page’s toolbar state.

Regression PR: #33195

Description of Change

The fix restores the correct lifecycle state by invoking SetDisappeared() at the beginning of the if (oldPage != null) block in OnPageSet. This call is additionally guarded with if (newPage != null) to ensure it does not run during Dispose, where Page is set to null and cleanup is handled separately.

When a tab switch assigns _tracker.Page before the animation completes, the call to SetDisappeared() explicitly resets _isVisiblePage to false and unsubscribes Toolbar.PropertyChanged for the outgoing page. After that, the subsequent CheckAppeared() detects that Shell.CurrentPage == newPage and triggers SetAppeared(). With _isVisiblePage now correctly reset, SetAppeared() runs its full logic: updating the SearchHandler, TitleView, and ToolbarItems for the incoming page and re-subscribing to Toolbar.PropertyChanged.

SetDisappeared() is already protected by if (!_isVisiblePage) return;, so it becomes a no-op for normal lifecycle flows where the page already disappeared correctly. No other navigation behavior is affected: push/pop navigation creates a new tracker for each page (meaning oldPage is always null), and app foreground/background cycles do not pass through OnPageSet at all.

Validated the behavior in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Issues Fixed

Fixes #34693

Output ScreenShot

Before After
34693-BeforeFix.mov
34693-AfterFix.mov

PureWeen and others added 4 commits March 25, 2026 09:44
…otnet#34548)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

## Description

Adds a [gh-aw (GitHub Agentic
Workflows)](https://github.github.com/gh-aw/introduction/overview/)
workflow that automatically evaluates test quality on PRs using the
`evaluate-pr-tests` skill.

### What it does

When a PR adds or modifies test files, this workflow:
1. **Checks out the PR branch** (including fork PRs) in a pre-agent step
2. **Runs the `evaluate-pr-tests` skill** via Copilot CLI in a sandboxed
container
3. **Posts the evaluation report** as a PR comment using gh-aw
safe-outputs

### Triggers

| Trigger | When | Fork PR support |
|---------|------|-----------------|
| `pull_request` | Automatic on test file changes (`src/**/tests/**`) |
❌ Blocked by `pre_activation` gate |
| `workflow_dispatch` | Manual — enter PR number | ✅ Works for all PRs |
| `issue_comment` (`/evaluate-tests`) | Comment on PR | ⚠️ Same-repo
only (see Known Limitations) |

### Security model

| Layer | Implementation |
|-------|---------------|
| **gh-aw sandbox** | Agent runs in container with scrubbed credentials,
network firewall |
| **Safe outputs** | Max 1 PR comment per run, content-limited |
| **Checkout without execution** | `steps:` checks out PR code but never
executes workspace scripts |
| **Base branch restoration** | `.github/skills/`,
`.github/instructions/`, `.github/copilot-instructions.md` restored from
base branch after checkout |
| **Fork PR activation gate** | `pull_request` events blocked for forks
via `head.repo.id == repository_id` |
| **Pinned actions** | SHA-pinned `actions/checkout`,
`actions/github-script`, etc. |
| **Minimal permissions** | Each job declares only what it needs |
| **Concurrency** | One evaluation per PR, cancels in-progress |
| **Threat detection** | gh-aw built-in threat detection analyzes agent
output |

### Files added/modified

- `.github/workflows/copilot-evaluate-tests.md` — gh-aw workflow source
- `.github/workflows/copilot-evaluate-tests.lock.yml` — Compiled
workflow (auto-generated by `gh aw compile`)
- `.github/skills/evaluate-pr-tests/scripts/Gather-TestContext.ps1` —
Test context gathering script (binary-safe file download, path traversal
protection)
- `.github/instructions/gh-aw-workflows.instructions.md` — Copilot
instructions for gh-aw development

### Known Limitations

**Fork PR evaluation via `/evaluate-tests` comment is not supported in
v1.** The gh-aw platform inserts a `checkout_pr_branch.cjs` step after
all user steps, which may overwrite base-branch skill files restored for
fork PRs. This is a known gh-aw platform limitation — user steps always
run before platform-generated steps, with no way to insert steps after.

**Workaround:** Use `workflow_dispatch` (Actions UI → "Run workflow" →
enter PR number) to evaluate fork PRs. This trigger bypasses the
platform checkout step entirely and works correctly.

**Related upstream issues:**
- [github/gh-aw#18481](github/gh-aw#18481) —
"Using gh-aw in forks of repositories"
- [github/gh-aw#18518](github/gh-aw#18518) —
Fork detection and warning in `gh aw init`
- [github/gh-aw#18520](github/gh-aw#18520) —
Fork context hint in failure messages
- [github/gh-aw#18521](github/gh-aw#18521) —
Fork support documentation

### Fixes

- Fixes dotnet#34602

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jakub Florkowski <kubaflo123@gmail.com>
## Summary

Enables the copilot-evaluate-tests gh-aw workflow to run on fork PRs by
adding `forks: ["*"]` to the `pull_request` trigger and removing the
fork guard from `Checkout-GhAwPr.ps1`.

## Changes

1. **copilot-evaluate-tests.md**: Added `forks: ["*"]` to opt out of
gh-aw auto-injected fork activation guard. Scoped `Checkout-GhAwPr.ps1`
step to `workflow_dispatch` only (redundant for other triggers since
platform handles checkout).

2. **copilot-evaluate-tests.lock.yml**: Recompiled via `gh aw compile` —
fork guard removed from activation `if:` conditions.

3. **Checkout-GhAwPr.ps1**: Removed the `isCrossRepository` fork guard.
Updated header docs and restore comments to accurately describe behavior
for all trigger×fork combinations (including corrected step ordering).

4. **gh-aw-workflows.instructions.md**: Updated all stale references to
the removed fork guard. Documented `forks: ["*"]` opt-in, clarified
residual risk model for fork PRs, and updated troubleshooting table.

## Security Model

Fork PRs are safe because:
- Agent runs in **sandboxed container** with all credentials scrubbed
- Output limited to **1 comment** via `safe-outputs: add-comment: max:
1`
- Agent **prompt comes from base branch** (`runtime-import`) — forks
cannot alter instructions
- Pre-flight check catches missing `SKILL.md` if fork isn't rebased on
`main`
- No workspace code is executed with `GITHUB_TOKEN` (checkout without
execution)

## Testing

- ✅ `workflow_dispatch` tested against fork PR dotnet#34621
- ✅ Lock.yml statically verified — fork guard removed from `if:`
conditions
- ⏳ `pull_request` trigger on fork PRs can only be verified post-merge
(GitHub Actions reads lock.yml from default branch)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…taType is compiled (dotnet#34717)

## Description

Adds regression tests for dotnet#34713 verifying the XAML source generator
correctly handles bindings with `Converter={StaticResource ...}` inside
`x:DataType` scopes.

Closes dotnet#34713

## Investigation

After thorough investigation of the source generator pipeline
(`KnownMarkups.cs`, `CompiledBindingMarkup.cs`, `NodeSGExtensions.cs`):

### When converter IS in page resources (compile-time resolution ✅)

`GetResourceNode()` walks the XAML tree, finds the converter resource,
and `ProvideValueForStaticResourceExtension` returns the variable
directly — **no runtime `ProvideValue` call**. The converter is
referenced at compile time.

### When converter is NOT in page resources (runtime resolution ✅)

`GetResourceNode()` returns null → falls through to `IsValueProvider` →
generates `StaticResourceExtension.ProvideValue(serviceProvider)`. The
`SimpleValueTargetProvider` provides the full parent chain, and
`TryGetApplicationLevelResource` checks `Application.Current.Resources`.
The binding IS still compiled into a `TypedBinding` — only the converter
resolution is deferred.

### Verified on both `main` and `net11.0`

All tests pass on both branches.

## Tests added

| Test | What it verifies |
|------|-----------------|
| `SourceGenResolvesConverterAtCompileTime_ImplicitResources` |
Converter in implicit `<Resources>` → compile-time resolution, no
`ProvideValue` |
| `SourceGenResolvesConverterAtCompileTime_ExplicitResourceDictionary` |
Converter in explicit `<ResourceDictionary>` → compile-time resolution,
no `ProvideValue` |
| `SourceGenCompilesBindingWithConverterToTypedBinding` | Converter NOT
in page resources → still compiled to `TypedBinding`, no raw `Binding`
fallback |
| `BindingWithConverterFromAppResourcesWorksCorrectly` × 3 | Runtime
behavior correct for all inflators (Runtime, XamlC, SourceGen) |

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…age state when switching Shell top tabs on iOS and macCatalyst.
@github-actions

github-actions Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34735

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34735"

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Mar 30, 2026
@MauiBot

MauiBot commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

🚦 Gate - Test Before and After Fix

📊 Expand Full Gatef4d22ef · fix-34693-Made code changes to fix SearchHandler retaining previous page state when switching Shell top tabs on iOS and macCatalyst.

Gate Result: ✅ PASSED

Platform: IOS · Base: main · Merge base: 720a9d4a

Test Without Fix (expect FAIL) With Fix (expect PASS)
🖥️ Issue34693 Issue34693 ✅ FAIL — 199s ✅ PASS — 84s
🔴 Without fix — 🖥️ Issue34693: FAIL ✅ · 199s
  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 501 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 501 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 4.82 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Foldable/src/Controls.Foldable.csproj (in 5.87 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj (in 5.88 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj (in 5.88 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 5.88 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Xaml/Controls.Xaml.csproj (in 5.88 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 5.89 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Maps/src/Controls.Maps.csproj (in 5.9 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/maps/src/Maps.csproj (in 5.91 sec).
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-ios26.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-ios26.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-ios26.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Maps.dll
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Controls.Foldable -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Foldable.dll
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Xaml.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-ios26.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Maps.dll
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-ios/iossimulator-arm64/Controls.TestCases.HostApp.dll
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.

Build succeeded.

/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
    1 Warning(s)
    0 Error(s)

Time Elapsed 00:01:39.42
  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/CustomAttributes/Controls.CustomAttributes.csproj (in 765 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Core/UITest.Core.csproj (in 757 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 757 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 766 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/VisualTestUtils/VisualTestUtils.csproj (in 2 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 814 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 850 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 304 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.NUnit/UITest.NUnit.csproj (in 1.46 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Appium/UITest.Appium.csproj (in 1.83 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Analyzers/UITest.Analyzers.csproj (in 2.33 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/VisualTestUtils.MagickNet/VisualTestUtils.MagickNet.csproj (in 2.8 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.iOS.Tests/Controls.TestCases.iOS.Tests.csproj (in 2.82 sec).
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Controls.CustomAttributes -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  UITest.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  VisualTestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  UITest.NUnit -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  VisualTestUtils.MagickNet -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.Appium -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  UITest.Analyzers -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.iOS.Tests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.05]   Discovering: Controls.TestCases.iOS.Tests
[xUnit.net 00:00:00.13]   Discovered:  Controls.TestCases.iOS.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 3/30/2026 3:25:24 PM FixtureSetup for Issue34693(iOS)
>>>>> 3/30/2026 3:25:28 PM ShouldUpdateSearchViewOnPageNavigation Start
>>>>> 3/30/2026 3:25:29 PM ShouldUpdateSearchViewOnPageNavigation Stop
>>>>> 3/30/2026 3:25:29 PM Log types: syslog, crashlog, performance, safariConsole, safariNetwork, server
  Failed ShouldUpdateSearchViewOnPageNavigation [1 s]
  Error Message:
     SearchHandler should show DogsPage placeholder after tab switch
Assert.That(placeholderText, Does.Contain("dog").IgnoreCase)
  Expected: String containing "dog", ignoring case
  But was:  "Enter cat's name"

  Stack Trace:
     at Microsoft.Maui.TestCases.Tests.Issues.Issue34693.ShouldUpdateSearchViewOnPageNavigation() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34693.cs:line 24

1)    at Microsoft.Maui.TestCases.Tests.Issues.Issue34693.ShouldUpdateSearchViewOnPageNavigation() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34693.cs:line 24


NUnit Adapter 4.5.0.0: Test execution complete

Test Run Failed.
Total tests: 1
     Failed: 1
 Total time: 59.1681 Seconds

🟢 With fix — 🖥️ Issue34693: PASS ✅ · 84s
  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 322 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 329 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 333 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 369 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 383 ms).
  6 of 11 projects are up-to-date for restore.
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-ios26.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-ios26.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-ios26.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Maps.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Controls.Foldable -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Foldable.dll
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Xaml.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-ios26.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Maps.dll
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-ios/iossimulator-arm64/Controls.TestCases.HostApp.dll
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.

Build succeeded.

/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
    1 Warning(s)
    0 Error(s)

Time Elapsed 00:00:43.29
  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 338 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 323 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 302 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 357 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 378 ms).
  8 of 13 projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Controls.CustomAttributes -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13692691
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  UITest.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  VisualTestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  UITest.Appium -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  VisualTestUtils.MagickNet -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.NUnit -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  UITest.Analyzers -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.iOS.Tests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.03]   Discovering: Controls.TestCases.iOS.Tests
[xUnit.net 00:00:00.12]   Discovered:  Controls.TestCases.iOS.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 3/30/2026 3:26:48 PM FixtureSetup for Issue34693(iOS)
>>>>> 3/30/2026 3:26:53 PM ShouldUpdateSearchViewOnPageNavigation Start
>>>>> 3/30/2026 3:26:54 PM ShouldUpdateSearchViewOnPageNavigation Stop
  Passed ShouldUpdateSearchViewOnPageNavigation [1 s]
NUnit Adapter 4.5.0.0: Test execution complete

Test Run Successful.
Total tests: 1
     Passed: 1
 Total time: 17.0075 Seconds

📁 Fix files reverted (2 files)
  • eng/pipelines/ci-copilot.yml
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs

@MauiBot

MauiBot commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

🤖 AI Summary

📊 Expand Full Reviewf4d22ef · fix-34693-Made code changes to fix SearchHandler retaining previous page state when switching Shell top tabs on iOS and macCatalyst.
🔍 Pre-Flight — Context & Validation

Issue: #34693 - [Shell][iOS & Mac] SearchHandler retains previous page state when switching top tabs
PR: #34735 - [iOS & Mac] Fix for SearchHandler retains previous page state when switching top tabs
Platforms Affected: iOS, MacCatalyst
Files Changed: 1 implementation, 2 test

Key Findings

  • Regression from PR [iOS] Fix Shell NavBarIsVisible updates when switching ShellContent #33195: Moved _tracker.Page assignment before navigation animation completes, causing oldPage.Disappearing to be unsubscribed before it fires. This left _isVisiblePage stuck as true.
  • Impact: When new page's tracker calls SetAppeared(), it returns early because _isVisiblePage is already true, so UpdateShellToMyPage() never runs — SearchHandler, TitleView, ToolbarItems are not updated.
  • Fix: In OnPageSet(), call SetDisappeared() before unsubscribing old page events, guarded by if (newPage is not null) to skip during Dispose.
  • SetDisappeared() is idempotent: Protected by if (!_isVisiblePage) return;, so it's a no-op in normal flows where the page already disappeared correctly.
  • Test uses #if IOS || MACCATALYST at file level (not ideal per guidelines, but works for platform-scoped tests).
  • No inline review comments from maintainers found.
  • Milestone: .NET 10 SR7 (labeled on the issue).
  • Gate: ✅ PASSED — test FAILS without fix (shows "Enter cat's name" when on DogsPage), PASSES with fix.

Fix Candidates

# Source Approach Test Result Files Changed Notes
PR PR #34735 Call SetDisappeared() at start of if (oldPage is not null) block in OnPageSet, guarded by if (newPage is not null) ✅ PASSED (Gate) ShellPageRendererTracker.cs Minimal, idempotent, targeted fix

🔧 Fix — Analysis & Comparison

Fix Candidates

# Source Approach Test Result Files Changed Notes
1 try-fix (claude-opus-4.6) Force in when is already PASS 1 file (+11/-1) Bypasses guard instead of resetting state; modifies CheckAppeared() behavior
2 try-fix (claude-sonnet-4.6) Track field; exits early only when PASS 1 file (+17/-7) Self-contained state machine; more complex, extra field needed
3 try-fix (gpt-5.3-codex) Reset in property setter when page changes PASS 1 file (+1/-0) Minimal 1-line change; semantically weaker (conflates page assignment with appearance)
4 try-fix (gpt-5.4, gemini unavailable) Defer old-page Disappearing unsubscription until event fires via HashSet PASS 1 file (+22/-2) Preserves real lifecycle but most complex
PR PR #34735 Call at start of block in , guarded by PASSED (Gate) 1 file (+9/-0) Minimal, semantically correct, idempotent

Cross-Pollination

Model Round New Ideas? Details
claude-opus-4.6 2 NO NEW IDEAS All viable fix surfaces covered across 5 attempts

Exhausted: Yes
Selected Fix: PR # The PR's fix is the cleanest and most semantically correct: calling SetDisappeared() is accurate (the page IS disappearing, the event just didn't fire), it's idempotent (no-op in normal flows), minimal (+9 lines), well-guarded for Dispose, and well-commented. All 4 try-fix alternatives passed but are either more complex (attempts 2, 4), modify a wider surface (attempt 1), or are semantically weaker (attempt 3).34735


📋 Report — Final Recommendation

✅ Final Recommendation: APPROVE

Phase Status

Phase Status Notes
Pre-Flight ✅ COMPLETE Issue #34693, iOS/MacCatalyst regression from PR #33195
Gate ✅ PASSED iOS — test FAILs without fix, PASSes with fix
Try-Fix ✅ COMPLETE 4 attempts, 4 passing; Selected Fix: PR
Report ✅ COMPLETE

Summary

PR #34735 fixes a regression on iOS/MacCatalyst where the Shell SearchHandler (and TitleView/ToolbarItems) failed to update when switching between top-level tabs. The fix is a 9-line surgical change to ShellPageRendererTracker.cs. Gate verified the fix works. Four independent try-fix attempts all passed with alternative approaches, confirming the bug is real and fixable — and all alternatives were more complex or semantically weaker than the PR's approach.

Root Cause

A regression in PR #33195 moved _tracker.Page assignment before the navigation animation completes. This caused OnPageSet to unsubscribe oldPage.Disappearing before it fires, leaving _isVisiblePage stuck as true. When the new page's tracker calls CheckAppeared()SetAppeared(), the early-exit guard (if (_isVisiblePage) return;) prevents UpdateShellToMyPage() from running, so the old tab's SearchHandler/TitleView/ToolbarItems remain visible.

Fix Quality

The PR's fix is well-designed:

  • Semantically correct: Calling SetDisappeared() accurately reflects the state — the page IS disappearing (the event just didn't fire due to timing).
  • Idempotent: SetDisappeared() has its own if (!_isVisiblePage) return; guard, making it a no-op in normal flows where Disappearing already fired correctly.
  • Safely scoped: The if (newPage is not null) guard prevents the call during Dispose (when Page is set to null and cleanup is handled separately).
  • Minimal: Only 9 lines added in one targeted location.
  • Well-commented: The added comments clearly explain the timing issue and why the fix is needed.

Concerns:

  • The test file uses a top-level #if IOS || MACCATALYST preprocessor directive rather than restricting via test categories (per UI test guidelines). This is a minor style issue — the test still works correctly and is appropriately scoped.
  • The test _34693CatsPage constructor has inconsistent indentation (mixed tabs/spaces in the ItemTemplate grid setup). Minor cosmetic issue.
  • The HostApp page class uses FlyoutBehavior = Flyout and FlyoutHeaderBehavior settings that are not necessary for the tab-switching scenario being tested. These are harmless but add noise.

Try-Fix comparison: All 4 alternative approaches passed tests, confirming multiple valid solutions exist. The PR's approach is preferred because it targets the exact point of failure (the lifecycle gap in OnPageSet) and correctly restores state semantics rather than working around them.


@MauiBot MauiBot added s/agent-approved AI agent recommends approval - PR fix is correct and optimal s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) labels Mar 30, 2026
@BagavathiPerumal

Copy link
Copy Markdown
Contributor Author

🤖 AI Summary

📊 Expand Full Reviewf4d22ef · fix-34693-Made code changes to fix SearchHandler retaining previous page state when switching Shell top tabs on iOS and macCatalyst.
🔍 Pre-Flight — Context & Validation
Issue: #34693 - [Shell][iOS & Mac] SearchHandler retains previous page state when switching top tabs PR: #34735 - [iOS & Mac] Fix for SearchHandler retains previous page state when switching top tabs Platforms Affected: iOS, MacCatalyst Files Changed: 1 implementation, 2 test

Key Findings

  • Regression from PR [iOS] Fix Shell NavBarIsVisible updates when switching ShellContent #33195: Moved _tracker.Page assignment before navigation animation completes, causing oldPage.Disappearing to be unsubscribed before it fires. This left _isVisiblePage stuck as true.
  • Impact: When new page's tracker calls SetAppeared(), it returns early because _isVisiblePage is already true, so UpdateShellToMyPage() never runs — SearchHandler, TitleView, ToolbarItems are not updated.
  • Fix: In OnPageSet(), call SetDisappeared() before unsubscribing old page events, guarded by if (newPage is not null) to skip during Dispose.
  • SetDisappeared() is idempotent: Protected by if (!_isVisiblePage) return;, so it's a no-op in normal flows where the page already disappeared correctly.
  • Test uses #if IOS || MACCATALYST at file level (not ideal per guidelines, but works for platform-scoped tests).
  • No inline review comments from maintainers found.
  • Milestone: .NET 10 SR7 (labeled on the issue).
  • Gate: ✅ PASSED — test FAILS without fix (shows "Enter cat's name" when on DogsPage), PASSES with fix.

Fix Candidates

Source Approach Test Result Files Changed Notes

PR PR #34735 Call SetDisappeared() at start of if (oldPage is not null) block in OnPageSet, guarded by if (newPage is not null) ✅ PASSED (Gate) ShellPageRendererTracker.cs Minimal, idempotent, targeted fix
🔧 Fix — Analysis & Comparison

Fix Candidates

Source Approach Test Result Files Changed Notes

1 try-fix (claude-opus-4.6) Force in when is already PASS 1 file (+11/-1) Bypasses guard instead of resetting state; modifies CheckAppeared() behavior
2 try-fix (claude-sonnet-4.6) Track field; exits early only when PASS 1 file (+17/-7) Self-contained state machine; more complex, extra field needed
3 try-fix (gpt-5.3-codex) Reset in property setter when page changes PASS 1 file (+1/-0) Minimal 1-line change; semantically weaker (conflates page assignment with appearance)
4 try-fix (gpt-5.4, gemini unavailable) Defer old-page Disappearing unsubscription until event fires via HashSet PASS 1 file (+22/-2) Preserves real lifecycle but most complex
PR PR #34735 Call at start of block in , guarded by PASSED (Gate) 1 file (+9/-0) Minimal, semantically correct, idempotent

Cross-Pollination

Model Round New Ideas? Details
claude-opus-4.6 2 NO NEW IDEAS All viable fix surfaces covered across 5 attempts
Exhausted: Yes Selected Fix: PR # The PR's fix is the cleanest and most semantically correct: calling SetDisappeared() is accurate (the page IS disappearing, the event just didn't fire), it's idempotent (no-op in normal flows), minimal (+9 lines), well-guarded for Dispose, and well-commented. All 4 try-fix alternatives passed but are either more complex (attempts 2, 4), modify a wider surface (attempt 1), or are semantically weaker (attempt 3).34735

📋 Report — Final Recommendation

✅ Final Recommendation: APPROVE

Phase Status

Phase Status Notes
Pre-Flight ✅ COMPLETE Issue #34693, iOS/MacCatalyst regression from PR #33195
Gate ✅ PASSED iOS — test FAILs without fix, PASSes with fix
Try-Fix ✅ COMPLETE 4 attempts, 4 passing; Selected Fix: PR
Report ✅ COMPLETE

Summary

PR #34735 fixes a regression on iOS/MacCatalyst where the Shell SearchHandler (and TitleView/ToolbarItems) failed to update when switching between top-level tabs. The fix is a 9-line surgical change to ShellPageRendererTracker.cs. Gate verified the fix works. Four independent try-fix attempts all passed with alternative approaches, confirming the bug is real and fixable — and all alternatives were more complex or semantically weaker than the PR's approach.

Root Cause

A regression in PR #33195 moved _tracker.Page assignment before the navigation animation completes. This caused OnPageSet to unsubscribe oldPage.Disappearing before it fires, leaving _isVisiblePage stuck as true. When the new page's tracker calls CheckAppeared()SetAppeared(), the early-exit guard (if (_isVisiblePage) return;) prevents UpdateShellToMyPage() from running, so the old tab's SearchHandler/TitleView/ToolbarItems remain visible.

Fix Quality

The PR's fix is well-designed:

  • Semantically correct: Calling SetDisappeared() accurately reflects the state — the page IS disappearing (the event just didn't fire due to timing).
  • Idempotent: SetDisappeared() has its own if (!_isVisiblePage) return; guard, making it a no-op in normal flows where Disappearing already fired correctly.
  • Safely scoped: The if (newPage is not null) guard prevents the call during Dispose (when Page is set to null and cleanup is handled separately).
  • Minimal: Only 9 lines added in one targeted location.
  • Well-commented: The added comments clearly explain the timing issue and why the fix is needed.

Concerns:

  • The test file uses a top-level #if IOS || MACCATALYST preprocessor directive rather than restricting via test categories (per UI test guidelines). This is a minor style issue — the test still works correctly and is appropriately scoped.
  • The test _34693CatsPage constructor has inconsistent indentation (mixed tabs/spaces in the ItemTemplate grid setup). Minor cosmetic issue.
  • The HostApp page class uses FlyoutBehavior = Flyout and FlyoutHeaderBehavior settings that are not necessary for the tab-switching scenario being tested. These are harmless but add noise.

Try-Fix comparison: All 4 alternative approaches passed tests, confirming multiple valid solutions exist. The PR's approach is preferred because it targets the exact point of failure (the lifecycle gap in OnPageSet) and correctly restores state semantics rather than working around them.

I’ve updated the changes based on the AI summary. Please find the details below:

  • The test file uses a top-level #if IOS || MACCATALYST directive instead of test categories. This follows the pattern used in previous testcases and does not affect test execution, so this change can be safely ignored.
  • Corrected the inconsistent indentation in the _34693CatsPage constructor’s ItemTemplate section based on the AI suggestion.
  • Removed the unnecessary FlyoutBehavior and FlyoutHeaderBehavior properties from the HostApp page to reduce noise and keep the test minimal.

@sheiksyedm sheiksyedm marked this pull request as ready for review April 1, 2026 15:16
Copilot AI review requested due to automatic review settings April 1, 2026 15:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an iOS/MacCatalyst Shell lifecycle regression where switching top tabs can leave the previous page’s toolbar state (notably SearchHandler) active, causing stale placeholder/results and incorrect interaction state.

Changes:

  • Updates ShellPageRendererTracker (iOS compatibility handler) to explicitly reset the visible-page lifecycle state during page switches so the incoming page’s toolbar state is applied.
  • Adds a HostApp repro Shell with two top tabs (Cats/Dogs) each providing a different SearchHandler placeholder.
  • Adds an iOS/MacCatalyst UI test to validate the SearchHandler placeholder updates after tab switching.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs Resets tracker lifecycle state on page switches so toolbar/SearchHandler refreshes for the newly selected tab.
src/Controls/tests/TestCases.HostApp/Issues/Issue34693.cs Adds a minimal Shell top-tab repro with per-tab SearchHandler placeholders to exercise the regression.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34693.cs Adds a targeted iOS/MacCatalyst UITest asserting the SearchField placeholder reflects the newly selected tab.

Comment on lines +18 to +24
App.WaitForElement("MainPageButton");
App.TapTab("DogsPage");

// Verify the SearchHandler updated to show the DogsPage placeholder
var searchHandler = App.GetShellSearchHandler();
var placeholderText = searchHandler.GetText();
Assert.That(placeholderText, Does.Contain("dog").IgnoreCase,

Copilot AI Apr 1, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After tapping the tab, the test immediately reads the SearchField text. TapTab only waits for the tab element to be present before tapping; it doesn’t guarantee the new page/toolbar state has finished updating. This can make the assertion flaky (especially on iOS/macCatalyst during the transition). Consider waiting for a DogsPage-specific element (e.g., DogPageButton) or waiting until the SearchField text/placeholder contains the expected value before asserting.

Copilot uses AI. Check for mistakes.
@kubaflo kubaflo added the s/agent-fix-implemented PR author implemented the agent suggested fix label Apr 3, 2026
@kubaflo kubaflo changed the base branch from main to inflight/current April 3, 2026 13:46
@kubaflo kubaflo merged commit 1b536ad into dotnet:inflight/current Apr 3, 2026
36 of 46 checks passed
PureWeen pushed a commit that referenced this pull request Apr 8, 2026
…itching top tabs (#34735)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!


<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Issue Details

When navigating between top-level Shell tabs, the SearchHandler does not
update to match the currently selected page. Instead, the SearchHandler
from the previously selected tab remains visible and active, showing
outdated placeholder text, stale search results, and incorrect
interaction state.

This issue occurs specifically on iOS and MacCatalyst and is caused by a
regression introduced in a recent Shell lifecycle update. The page
lifecycle events (Appearing / Disappearing) no longer fire in the
correct order, preventing the toolbar from refreshing when a new
ShellContent becomes active. As a result, the SearchHandler associated
with the new page is never applied.

### Root Cause

The issue occurs on iOS and macCatalyst because a recent Shell lifecycle
update moved the _tracker.Page assignment to run before the navigation
animation completes. As a result, the old page’s Disappearing event was
unsubscribed prematurely, preventing it from firing. This
left _isVisiblePage stuck in the true state.

When the new page appeared, SetAppeared() exited early due to the
stale _isVisiblePage value, causing UpdateShellToMyPage() to never
execute. This disrupted the normal Shell page lifecycle and prevented
the toolbar from updating. As a result, the SearchHandler, TitleView,
and ToolbarItems from the previous tab remained visible instead of being
replaced with the new page’s toolbar state.

**Regression PR:** #33195

### Description of Change

The fix restores the correct lifecycle state by invoking
SetDisappeared() at the beginning of the if (oldPage != null) block in
OnPageSet. This call is additionally guarded with if (newPage != null)
to ensure it does not run during Dispose, where Page is set to null and
cleanup is handled separately.
 
When a tab switch assigns _tracker.Page before the animation completes,
the call to SetDisappeared() explicitly resets _isVisiblePage to false
and unsubscribes Toolbar.PropertyChanged for the outgoing page. After
that, the subsequent CheckAppeared() detects that Shell.CurrentPage ==
newPage and triggers SetAppeared(). With _isVisiblePage now correctly
reset, SetAppeared() runs its full logic: updating the SearchHandler,
TitleView, and ToolbarItems for the incoming page and re-subscribing to
Toolbar.PropertyChanged.
 
SetDisappeared() is already protected by if (!_isVisiblePage) return;,
so it becomes a no-op for normal lifecycle flows where the page already
disappeared correctly. No other navigation behavior is affected:
push/pop navigation creates a new tracker for each page (meaning oldPage
is always null), and app foreground/background cycles do not pass
through OnPageSet at all.

Validated the behavior in the following platforms
 
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac
 
### Issues Fixed
  
Fixes #34693

### Output  ScreenShot

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/43966d7f-ff6f-45b0-be04-a540a03c00fe"
>| <video
src="https://github.com/user-attachments/assets/c6936dde-f766-40cf-a37b-24cc3b738486">|

---------
devanathan-vaithiyanathan pushed a commit to devanathan-vaithiyanathan/maui that referenced this pull request Apr 9, 2026
…itching top tabs (dotnet#34735)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!


<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Issue Details

When navigating between top-level Shell tabs, the SearchHandler does not
update to match the currently selected page. Instead, the SearchHandler
from the previously selected tab remains visible and active, showing
outdated placeholder text, stale search results, and incorrect
interaction state.

This issue occurs specifically on iOS and MacCatalyst and is caused by a
regression introduced in a recent Shell lifecycle update. The page
lifecycle events (Appearing / Disappearing) no longer fire in the
correct order, preventing the toolbar from refreshing when a new
ShellContent becomes active. As a result, the SearchHandler associated
with the new page is never applied.

### Root Cause

The issue occurs on iOS and macCatalyst because a recent Shell lifecycle
update moved the _tracker.Page assignment to run before the navigation
animation completes. As a result, the old page’s Disappearing event was
unsubscribed prematurely, preventing it from firing. This
left _isVisiblePage stuck in the true state.

When the new page appeared, SetAppeared() exited early due to the
stale _isVisiblePage value, causing UpdateShellToMyPage() to never
execute. This disrupted the normal Shell page lifecycle and prevented
the toolbar from updating. As a result, the SearchHandler, TitleView,
and ToolbarItems from the previous tab remained visible instead of being
replaced with the new page’s toolbar state.

**Regression PR:** dotnet#33195

### Description of Change

The fix restores the correct lifecycle state by invoking
SetDisappeared() at the beginning of the if (oldPage != null) block in
OnPageSet. This call is additionally guarded with if (newPage != null)
to ensure it does not run during Dispose, where Page is set to null and
cleanup is handled separately.
 
When a tab switch assigns _tracker.Page before the animation completes,
the call to SetDisappeared() explicitly resets _isVisiblePage to false
and unsubscribes Toolbar.PropertyChanged for the outgoing page. After
that, the subsequent CheckAppeared() detects that Shell.CurrentPage ==
newPage and triggers SetAppeared(). With _isVisiblePage now correctly
reset, SetAppeared() runs its full logic: updating the SearchHandler,
TitleView, and ToolbarItems for the incoming page and re-subscribing to
Toolbar.PropertyChanged.
 
SetDisappeared() is already protected by if (!_isVisiblePage) return;,
so it becomes a no-op for normal lifecycle flows where the page already
disappeared correctly. No other navigation behavior is affected:
push/pop navigation creates a new tracker for each page (meaning oldPage
is always null), and app foreground/background cycles do not pass
through OnPageSet at all.

Validated the behavior in the following platforms
 
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac
 
### Issues Fixed
  
Fixes dotnet#34693

### Output  ScreenShot

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/43966d7f-ff6f-45b0-be04-a540a03c00fe"
>| <video
src="https://github.com/user-attachments/assets/c6936dde-f766-40cf-a37b-24cc3b738486">|

---------
PureWeen pushed a commit that referenced this pull request Apr 14, 2026
…itching top tabs (#34735)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!


<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Issue Details

When navigating between top-level Shell tabs, the SearchHandler does not
update to match the currently selected page. Instead, the SearchHandler
from the previously selected tab remains visible and active, showing
outdated placeholder text, stale search results, and incorrect
interaction state.

This issue occurs specifically on iOS and MacCatalyst and is caused by a
regression introduced in a recent Shell lifecycle update. The page
lifecycle events (Appearing / Disappearing) no longer fire in the
correct order, preventing the toolbar from refreshing when a new
ShellContent becomes active. As a result, the SearchHandler associated
with the new page is never applied.

### Root Cause

The issue occurs on iOS and macCatalyst because a recent Shell lifecycle
update moved the _tracker.Page assignment to run before the navigation
animation completes. As a result, the old page’s Disappearing event was
unsubscribed prematurely, preventing it from firing. This
left _isVisiblePage stuck in the true state.

When the new page appeared, SetAppeared() exited early due to the
stale _isVisiblePage value, causing UpdateShellToMyPage() to never
execute. This disrupted the normal Shell page lifecycle and prevented
the toolbar from updating. As a result, the SearchHandler, TitleView,
and ToolbarItems from the previous tab remained visible instead of being
replaced with the new page’s toolbar state.

**Regression PR:** #33195

### Description of Change

The fix restores the correct lifecycle state by invoking
SetDisappeared() at the beginning of the if (oldPage != null) block in
OnPageSet. This call is additionally guarded with if (newPage != null)
to ensure it does not run during Dispose, where Page is set to null and
cleanup is handled separately.
 
When a tab switch assigns _tracker.Page before the animation completes,
the call to SetDisappeared() explicitly resets _isVisiblePage to false
and unsubscribes Toolbar.PropertyChanged for the outgoing page. After
that, the subsequent CheckAppeared() detects that Shell.CurrentPage ==
newPage and triggers SetAppeared(). With _isVisiblePage now correctly
reset, SetAppeared() runs its full logic: updating the SearchHandler,
TitleView, and ToolbarItems for the incoming page and re-subscribing to
Toolbar.PropertyChanged.
 
SetDisappeared() is already protected by if (!_isVisiblePage) return;,
so it becomes a no-op for normal lifecycle flows where the page already
disappeared correctly. No other navigation behavior is affected:
push/pop navigation creates a new tracker for each page (meaning oldPage
is always null), and app foreground/background cycles do not pass
through OnPageSet at all.

Validated the behavior in the following platforms
 
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac
 
### Issues Fixed
  
Fixes #34693

### Output  ScreenShot

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/43966d7f-ff6f-45b0-be04-a540a03c00fe"
>| <video
src="https://github.com/user-attachments/assets/c6936dde-f766-40cf-a37b-24cc3b738486">|

---------
@PureWeen PureWeen mentioned this pull request Apr 14, 2026
devanathan-vaithiyanathan pushed a commit to Tamilarasan-Paranthaman/maui that referenced this pull request Apr 21, 2026
…itching top tabs (dotnet#34735)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!


<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Issue Details

When navigating between top-level Shell tabs, the SearchHandler does not
update to match the currently selected page. Instead, the SearchHandler
from the previously selected tab remains visible and active, showing
outdated placeholder text, stale search results, and incorrect
interaction state.

This issue occurs specifically on iOS and MacCatalyst and is caused by a
regression introduced in a recent Shell lifecycle update. The page
lifecycle events (Appearing / Disappearing) no longer fire in the
correct order, preventing the toolbar from refreshing when a new
ShellContent becomes active. As a result, the SearchHandler associated
with the new page is never applied.

### Root Cause

The issue occurs on iOS and macCatalyst because a recent Shell lifecycle
update moved the _tracker.Page assignment to run before the navigation
animation completes. As a result, the old page’s Disappearing event was
unsubscribed prematurely, preventing it from firing. This
left _isVisiblePage stuck in the true state.

When the new page appeared, SetAppeared() exited early due to the
stale _isVisiblePage value, causing UpdateShellToMyPage() to never
execute. This disrupted the normal Shell page lifecycle and prevented
the toolbar from updating. As a result, the SearchHandler, TitleView,
and ToolbarItems from the previous tab remained visible instead of being
replaced with the new page’s toolbar state.

**Regression PR:** dotnet#33195

### Description of Change

The fix restores the correct lifecycle state by invoking
SetDisappeared() at the beginning of the if (oldPage != null) block in
OnPageSet. This call is additionally guarded with if (newPage != null)
to ensure it does not run during Dispose, where Page is set to null and
cleanup is handled separately.
 
When a tab switch assigns _tracker.Page before the animation completes,
the call to SetDisappeared() explicitly resets _isVisiblePage to false
and unsubscribes Toolbar.PropertyChanged for the outgoing page. After
that, the subsequent CheckAppeared() detects that Shell.CurrentPage ==
newPage and triggers SetAppeared(). With _isVisiblePage now correctly
reset, SetAppeared() runs its full logic: updating the SearchHandler,
TitleView, and ToolbarItems for the incoming page and re-subscribing to
Toolbar.PropertyChanged.
 
SetDisappeared() is already protected by if (!_isVisiblePage) return;,
so it becomes a no-op for normal lifecycle flows where the page already
disappeared correctly. No other navigation behavior is affected:
push/pop navigation creates a new tracker for each page (meaning oldPage
is always null), and app foreground/background cycles do not pass
through OnPageSet at all.

Validated the behavior in the following platforms
 
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac
 
### Issues Fixed
  
Fixes dotnet#34693

### Output  ScreenShot

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/43966d7f-ff6f-45b0-be04-a540a03c00fe"
>| <video
src="https://github.com/user-attachments/assets/c6936dde-f766-40cf-a37b-24cc3b738486">|

---------
Ahamed-Ali pushed a commit that referenced this pull request Apr 22, 2026
…itching top tabs (#34735)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!


<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Issue Details

When navigating between top-level Shell tabs, the SearchHandler does not
update to match the currently selected page. Instead, the SearchHandler
from the previously selected tab remains visible and active, showing
outdated placeholder text, stale search results, and incorrect
interaction state.

This issue occurs specifically on iOS and MacCatalyst and is caused by a
regression introduced in a recent Shell lifecycle update. The page
lifecycle events (Appearing / Disappearing) no longer fire in the
correct order, preventing the toolbar from refreshing when a new
ShellContent becomes active. As a result, the SearchHandler associated
with the new page is never applied.

### Root Cause

The issue occurs on iOS and macCatalyst because a recent Shell lifecycle
update moved the _tracker.Page assignment to run before the navigation
animation completes. As a result, the old page’s Disappearing event was
unsubscribed prematurely, preventing it from firing. This
left _isVisiblePage stuck in the true state.

When the new page appeared, SetAppeared() exited early due to the
stale _isVisiblePage value, causing UpdateShellToMyPage() to never
execute. This disrupted the normal Shell page lifecycle and prevented
the toolbar from updating. As a result, the SearchHandler, TitleView,
and ToolbarItems from the previous tab remained visible instead of being
replaced with the new page’s toolbar state.

**Regression PR:** #33195

### Description of Change

The fix restores the correct lifecycle state by invoking
SetDisappeared() at the beginning of the if (oldPage != null) block in
OnPageSet. This call is additionally guarded with if (newPage != null)
to ensure it does not run during Dispose, where Page is set to null and
cleanup is handled separately.
 
When a tab switch assigns _tracker.Page before the animation completes,
the call to SetDisappeared() explicitly resets _isVisiblePage to false
and unsubscribes Toolbar.PropertyChanged for the outgoing page. After
that, the subsequent CheckAppeared() detects that Shell.CurrentPage ==
newPage and triggers SetAppeared(). With _isVisiblePage now correctly
reset, SetAppeared() runs its full logic: updating the SearchHandler,
TitleView, and ToolbarItems for the incoming page and re-subscribing to
Toolbar.PropertyChanged.
 
SetDisappeared() is already protected by if (!_isVisiblePage) return;,
so it becomes a no-op for normal lifecycle flows where the page already
disappeared correctly. No other navigation behavior is affected:
push/pop navigation creates a new tracker for each page (meaning oldPage
is always null), and app foreground/background cycles do not pass
through OnPageSet at all.

Validated the behavior in the following platforms
 
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac
 
### Issues Fixed
  
Fixes #34693

### Output  ScreenShot

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/43966d7f-ff6f-45b0-be04-a540a03c00fe"
>| <video
src="https://github.com/user-attachments/assets/c6936dde-f766-40cf-a37b-24cc3b738486">|

---------
PureWeen pushed a commit that referenced this pull request Apr 22, 2026
…itching top tabs (#34735)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!


<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Issue Details

When navigating between top-level Shell tabs, the SearchHandler does not
update to match the currently selected page. Instead, the SearchHandler
from the previously selected tab remains visible and active, showing
outdated placeholder text, stale search results, and incorrect
interaction state.

This issue occurs specifically on iOS and MacCatalyst and is caused by a
regression introduced in a recent Shell lifecycle update. The page
lifecycle events (Appearing / Disappearing) no longer fire in the
correct order, preventing the toolbar from refreshing when a new
ShellContent becomes active. As a result, the SearchHandler associated
with the new page is never applied.

### Root Cause

The issue occurs on iOS and macCatalyst because a recent Shell lifecycle
update moved the _tracker.Page assignment to run before the navigation
animation completes. As a result, the old page’s Disappearing event was
unsubscribed prematurely, preventing it from firing. This
left _isVisiblePage stuck in the true state.

When the new page appeared, SetAppeared() exited early due to the
stale _isVisiblePage value, causing UpdateShellToMyPage() to never
execute. This disrupted the normal Shell page lifecycle and prevented
the toolbar from updating. As a result, the SearchHandler, TitleView,
and ToolbarItems from the previous tab remained visible instead of being
replaced with the new page’s toolbar state.

**Regression PR:** #33195

### Description of Change

The fix restores the correct lifecycle state by invoking
SetDisappeared() at the beginning of the if (oldPage != null) block in
OnPageSet. This call is additionally guarded with if (newPage != null)
to ensure it does not run during Dispose, where Page is set to null and
cleanup is handled separately.
 
When a tab switch assigns _tracker.Page before the animation completes,
the call to SetDisappeared() explicitly resets _isVisiblePage to false
and unsubscribes Toolbar.PropertyChanged for the outgoing page. After
that, the subsequent CheckAppeared() detects that Shell.CurrentPage ==
newPage and triggers SetAppeared(). With _isVisiblePage now correctly
reset, SetAppeared() runs its full logic: updating the SearchHandler,
TitleView, and ToolbarItems for the incoming page and re-subscribing to
Toolbar.PropertyChanged.
 
SetDisappeared() is already protected by if (!_isVisiblePage) return;,
so it becomes a no-op for normal lifecycle flows where the page already
disappeared correctly. No other navigation behavior is affected:
push/pop navigation creates a new tracker for each page (meaning oldPage
is always null), and app foreground/background cycles do not pass
through OnPageSet at all.

Validated the behavior in the following platforms
 
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac
 
### Issues Fixed
  
Fixes #34693

### Output  ScreenShot

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/43966d7f-ff6f-45b0-be04-a540a03c00fe"
>| <video
src="https://github.com/user-attachments/assets/c6936dde-f766-40cf-a37b-24cc3b738486">|

---------
PureWeen pushed a commit that referenced this pull request Apr 28, 2026
…itching top tabs (#34735)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!


<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Issue Details

When navigating between top-level Shell tabs, the SearchHandler does not
update to match the currently selected page. Instead, the SearchHandler
from the previously selected tab remains visible and active, showing
outdated placeholder text, stale search results, and incorrect
interaction state.

This issue occurs specifically on iOS and MacCatalyst and is caused by a
regression introduced in a recent Shell lifecycle update. The page
lifecycle events (Appearing / Disappearing) no longer fire in the
correct order, preventing the toolbar from refreshing when a new
ShellContent becomes active. As a result, the SearchHandler associated
with the new page is never applied.

### Root Cause

The issue occurs on iOS and macCatalyst because a recent Shell lifecycle
update moved the _tracker.Page assignment to run before the navigation
animation completes. As a result, the old page’s Disappearing event was
unsubscribed prematurely, preventing it from firing. This
left _isVisiblePage stuck in the true state.

When the new page appeared, SetAppeared() exited early due to the
stale _isVisiblePage value, causing UpdateShellToMyPage() to never
execute. This disrupted the normal Shell page lifecycle and prevented
the toolbar from updating. As a result, the SearchHandler, TitleView,
and ToolbarItems from the previous tab remained visible instead of being
replaced with the new page’s toolbar state.

**Regression PR:** #33195

### Description of Change

The fix restores the correct lifecycle state by invoking
SetDisappeared() at the beginning of the if (oldPage != null) block in
OnPageSet. This call is additionally guarded with if (newPage != null)
to ensure it does not run during Dispose, where Page is set to null and
cleanup is handled separately.
 
When a tab switch assigns _tracker.Page before the animation completes,
the call to SetDisappeared() explicitly resets _isVisiblePage to false
and unsubscribes Toolbar.PropertyChanged for the outgoing page. After
that, the subsequent CheckAppeared() detects that Shell.CurrentPage ==
newPage and triggers SetAppeared(). With _isVisiblePage now correctly
reset, SetAppeared() runs its full logic: updating the SearchHandler,
TitleView, and ToolbarItems for the incoming page and re-subscribing to
Toolbar.PropertyChanged.
 
SetDisappeared() is already protected by if (!_isVisiblePage) return;,
so it becomes a no-op for normal lifecycle flows where the page already
disappeared correctly. No other navigation behavior is affected:
push/pop navigation creates a new tracker for each page (meaning oldPage
is always null), and app foreground/background cycles do not pass
through OnPageSet at all.

Validated the behavior in the following platforms
 
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac
 
### Issues Fixed
  
Fixes #34693

### Output  ScreenShot

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/43966d7f-ff6f-45b0-be04-a540a03c00fe"
>| <video
src="https://github.com/user-attachments/assets/c6936dde-f766-40cf-a37b-24cc3b738486">|

---------
PureWeen added a commit that referenced this pull request Apr 29, 2026
## Blazor
- Fix: Filter precompressed RCL assets from MAUI Blazor Hybrid APKs by
@mattleibow in #33917
  <details>
  <summary>🔧 Fixes</summary>

- [.NET MAUI Blazor Hybrid App should not precompress
assets](#33773)
  </details>

- [Windows] Fix for Runtime error when closing external window with WPF
Webview Control by @BagavathiPerumal in
#34006
  <details>
  <summary>🔧 Fixes</summary>

- [Runtime error when closing external window with WPF Webview
Control](#32944)
  </details>

## Button
- [Android] ImageButton CornerRadius not being applied - fix by @kubaflo
in #30074
  <details>
  <summary>🔧 Fixes</summary>

- [ImageButton CornerRadius not being applied on
Android](#23854)
  </details>

- Fix Disabled visual state ignored when Button has locally-set
BackgroundColor/TextColor by @Dhivya-SF4094 in
#34444
  <details>
  <summary>🔧 Fixes</summary>

- [[regression/9.0] VisualState "Disabled" is not properly applied for
Button with custom
appearance](#34363)
  </details>

## CollectionView
- Fix CollectionView grid spacing updates for first row and column by
@KarthikRajaKalaimani in #34527
  <details>
  <summary>🔧 Fixes</summary>

- [[MAUI] I2_Vertical grid for horizontal Item Spacing and Vertical Item
Spacing - horizontally updating the spacing only applies to the second
column](#34257)
  </details>

- Fix CollectionView record struct selection on Windows by
@jeremy-visionaid in #33488

- [Android] Ensure disconnected ItemsViewHandler doesn't hold onto the
items source by @filipnavara in
#24610
  <details>
  <summary>🔧 Fixes</summary>

- [Crash on NullReferenceException with measurement cells in
CollectionView](#24304)
  </details>

- [Windows] Fixed VisualState Setters not working properly for
CollectionView by @Dhivya-SF4094 in
#27230
  <details>
  <summary>🔧 Fixes</summary>

- [VisualState Setters not working properly on Windows for a
CollectionView](#27086)
- [[regression/8.0.3] [Windows][CollectionView]Label Disappear when set
Style in
ContentPage.Resources](#19209)
- [[Windows] Label style defined as ContentPage Resource doesn't
propagate to
CollectionView](#18701)
  </details>

- [Windows] Fixed Margin doesn't work inside CollectionView EmptyView by
@Dhivya-SF4094 in #29897
  <details>
  <summary>🔧 Fixes</summary>

- [Margin doesn't work inside CollectionView
EmptyView](#8494)
  </details>

- [Android, Windows] Fix CarouselView PreviousPosition/PreviousItem
incorrect during animated ScrollTo() by @praveenkumarkarunanithi in
#34570
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] CurrentItemChangedEventArgs.PreviousItem and
PositionChangedEventArgs.PreviousPosition Not Updating Correctly When
Using ScrollTo or Setting
Position](#29544)
  </details>

- [iOS] CarouselView2: Update internal scroll indicators for
compositional layout by @SubhikshaSf4851 in
#33639
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Horizontal Scroll Bar Not Visible on CarouselView
(CV2)](#29390)
  </details>

- [CarouselViewHandler2] Fir fox CurrentItem does not work when
ItemSpacing is set by @SyedAbdulAzeemSF4852 in
#32135
  <details>
  <summary>🔧 Fixes</summary>

- [[CarouselViewHandler2] CurrentItem does not work when ItemSpacing is
set](#32048)
  </details>

- [iOS] Fix for Incorrect Scroll in Loop Mode When CurrentItem Is Not
Found in ItemsSource by @SyedAbdulAzeemSF4852 in
#32141
  <details>
  <summary>🔧 Fixes</summary>

- [[Android & iOS] Setting an invalid CurrentItem causes scroll to last
item in looped
CarouselView](#32139)
  </details>

- [Android] IndicatorView: Add TalkBack accessibility descriptions for
indicators by @praveenkumarkarunanithi in
#31775
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] IndicatorView does not convey correct accessibility
information](#31446)
  </details>

- [iOS, macOS] Fixed CollectionView KeepLastItemInView Not Updating
Correctly When Items Are Added Dynamically by @NanthiniMahalingam in
#32191
  <details>
  <summary>🔧 Fixes</summary>

- [[.NET10] I9 - Scroll_Position - "KeepLastItemInView" does not keep
the last item at the end of the displayed list when adding new
items.](#31825)
  </details>

- [Windows, Android] Resolved issue with dynamic Header/Footer
reassignment in CollectionView. by @prakashKannanSf3972 in
#28403
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows, Android] Toggling Header/Footer in CollectionView
Dynamically is not working](#27959)
- [CollectionView HeaderTemplate and FooterTemplate are not displayed
when ItemsSource is initially set to
null](#28337)
- [[Android] Header and Footer Not Visible in CollectionView When
EmptyView is Selected
First](#28351)
  </details>

- [Android] Fix CollectionView inside disabled RefreshView blocks scroll
by @Vignesh-SF3580 in #34702
  <details>
  <summary>🔧 Fixes</summary>

- [C6-The C6 page cannot scroll on Windows and Android
platforms.](#34666)
  </details>

- [Android] CollectionView: Fix SelectedItem visual state not applying
when re-selecting same item by @KarthikRajaKalaimani in
#31591
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView - SelectedItem visual state manager not
working](#20062)
  </details>

- [Windows] Fixed CollectionView.EmptyView can not be removed by setting
it to Null by @Dhivya-SF4094 in
#29487
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] CollectionView.EmptyView can not be removed by setting it
to Null](#18657)
- [[Windows] EmptyViewTemplate Not Working in
CarouselView](#29463)
- [EmptyViewTemplate does not do
anything](#18551)
- [[MAUI] I5_EmptyView - The data template selector cannot display the
correct string.](#23330)
  </details>

- [iOS] Support for IsSwipeEnabled on CarouselView2 by @kubaflo in
#29996
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] IsSwipeEnabled Not Working on CarouselView
(CV2)](#29391)
  </details>

- [iOS, MacOS] Fixed FlowDirection not working on Header/Footer in
CollectionView by @Dhivya-SF4094 in
#32775
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, MacOS] FlowDirection not working on Header/Footer in
CollectionView](#32771)
  </details>

- [iOS] CollectionView: Fix drag-and-drop reordering into empty groups
by @SuthiYuvaraj in #34151
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView Drag and Drop Reordering Can't Drop in Empty
Group](#12008)
  </details>

- [Android] CollectionView: Fix drag-and-drop reordering into empty
groups by @SuthiYuvaraj in #31867
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView Drag and Drop Reordering Can't Drop in Empty
Group](#12008)
  </details>

- [iOS] Fix vertical CarouselView MandatorySingle snapping on iOS by
@Vignesh-SF3580 in #34700
  <details>
  <summary>🔧 Fixes</summary>

- [CarouselView vertical snap points ignored on iOS with
Microsoft.Maui.Controls v10.0.20 (regression from
v9.0.120)](#33308)
  </details>

- [iOS26] Fix CarouselView scrolling to wrong item when navigating to
last item by @Vignesh-SF3580 in
#34013
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS 26] CarouselView does not scroll to the correct last
item](#33770)
  </details>

- Fixed the OnPlatform does not work for header property in Collection
view by @NanthiniMahalingam in #28935
  <details>
  <summary>🔧 Fixes</summary>

- [OnPlatform does not work in Header of
CollectionView](#25124)
  </details>

- [Android] [Candidate branch] Fix
VerifySelectedItemClearsOnNullAssignment,
CollectionViewSelectionShouldClear, SelectedItemVisualIsCleared UI test
failure on Android by @KarthikRajaKalaimani in
#34928

## DateTimePicker
- [iOS] Fix for DatePicker FlowDirection Not Working on iOS by
@SyedAbdulAzeemSF4852 in #30193
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] DatePicker FlowDirection Not Working on
iOS](#30065)
  </details>

## Drawing
- [Shapes] Line: Fix asymmetric Stretch.None path translation when
right/bottom edge overflows by @NirmalKumarYuvaraj in
#34385
  <details>
  <summary>🔧 Fixes</summary>

- [Line coordinates not computed
correctly](#11404)
- [Lines not drawing
correctly](#26961)
  </details>

- [Android] Fixed GraphicsView drawable is visible outside the canvas by
@NirmalKumarYuvaraj in #28353
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] GraphicsView, The drawn image can also be visible outside
the canvas](#20834)
  </details>

- Fixed Custom Drawable does not support binding by @NirmalKumarYuvaraj
in #29442
  <details>
  <summary>🔧 Fixes</summary>

- [Custom IDrawable control does not databind to a model property when
used inside a CollectionView
ItemTemplate](#20991)
  </details>

- Added a support for GradientBrushes on Shape.Stroke by @kubaflo in
#22208
  <details>
  <summary>🔧 Fixes</summary>

- [GradientBrushes are not supported on
Shape.Stroke](#21983)
  </details>

## Editor
- Fixed Editor HorizontalTextAlignment does not update at run time by
@NirmalKumarYuvaraj in #25129
  <details>
  <summary>🔧 Fixes</summary>

- [Editor HorizontalTextAlignment Does not
Works.](#10987)
- [[iOS/MacOs] Right-To-Left (RTL) alignment is not applied to Editor
placeholder](#30052)
  </details>

- [Windows] Fixed Entry Editor placeholder Text CharacterSpacing by
@SubhikshaSf4851 in #30324
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] CharacterSpacing not applied to Placeholder text in Entry
and Editor controls](#30071)
  </details>

## Entry
- [Windows] Fix fo setting an Entry's Keyboard to Date causes it to be
interpreted as a password input by @SyedAbdulAzeemSF4852 in
#29344
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] Entry Keyboad-Type "Date" results in
Password-Entry](#28975)
  </details>

- [Android] Exception thrown when give more than 5000 characters to the
Text property of Entry. by @KarthikRajaKalaimani in
#30242
  <details>
  <summary>🔧 Fixes</summary>

- [Android crash when Entry has >5000
characters](#30144)
  </details>

## Essentials
- Bump MonoApiToolsMSBuildTasksPackageVersion to 0.5.0 and ship
Essentials.AI public APIs by @mattleibow via @Copilot in
#34574

- [Mac] DeviceDisplay.KeepScreenOn not being respected on Mac OS by
@HarishwaranVijayakumar in #32708
  <details>
  <summary>🔧 Fixes</summary>

- [[Mac Catalyst] DeviceDisplay.KeepScreenOn not being respected on Mac
OS](#26059)
  </details>

## Flyoutpage
- [Windows] FlyoutPage: update CollapseStyle at runtime by
@devanathan-vaithiyanathan in #29927
  <details>
  <summary>🔧 Fixes</summary>

- [Flyout Page SetCollapseStyle doesn't have any
change](#18200)
  </details>

## Gestures
- [Android] Fix for TapGestureRecognizer doesn't fire by
@HarishwaranVijayakumar in #34497
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] TapGestureRecognizer doesn't
fire](#5825)
  </details>

## Image
- [Android] Fix Share.RequestAsync SecurityException on Android 10+
caused by missing ClipData by @HarishwaranVijayakumar in
#34417
  <details>
  <summary>🔧 Fixes</summary>

- [[Bug] Share.RequestAsync throws java.lang.SecurityException
(uid=1000) on Android 10+ due to missing
intent.ClipData](#34370)
  </details>

- [Windows]Fixed the MauiImage with logical name containing path issue
by @sheiksyedm in #32864
  <details>
  <summary>🔧 Fixes</summary>

- [MauiImage with LogicalName containing path - is not working on
Windows](#32356)
  </details>

- [Android, Windows & iOS] Fix Downsize/ScaleImage to maintain aspect
ratio and prevent upscaling by @SyedAbdulAzeemSF4852 in
#30808
  <details>
  <summary>🔧 Fixes</summary>

- [[Android & Windows] In GraphicsView, the aspect ratio is not
maintained when Downsize is called with both maxWidth and
maxHeight](#30803)
  </details>

## Label
- [iOS , macOS] Fixed Label text cropping when a width request is
specified on the label inside a VerticalStackLayout with specified width
request by @NanthiniMahalingam in
#29166
  <details>
  <summary>🔧 Fixes</summary>

- [Label text gets cropped when a width request is specified on the
label inside a
VerticalStackLayout](#28660)
- [[iOS] Label with a fixed WidthRequest has wrong
height](#26644)
  </details>

- [Android] Fix Label word wrapping clips text depending on alignment
and layout options by @Dhivya-SF4094 in
#34533
  <details>
  <summary>🔧 Fixes</summary>

- [Bug: Android Label word wrapping clips text depending on alignment
and layout options](#34459)
  </details>

- LineHeight and decorations for HTML Label - fix by @kubaflo in
#31202
  <details>
  <summary>🔧 Fixes</summary>

- [LineHeight with HTML Label not
working](#22193)
  - [lineheight is broken ](#22197)
  </details>

- [iOS] Fix Label with TailTruncation not rendering after
empty-to-non-empty text transition by @kubaflo in
#34812
  <details>
  <summary>🔧 Fixes</summary>

- [Label with LineBreakMode="TailTruncation" does not render text if
initial Text is null or empty on first render
(iOS)](#34591)
  </details>

## Layout
- [Android] Fix overflowing children clipped when parent Opacity < 1 by
@SyedAbdulAzeemSF4852 in #34565
  <details>
  <summary>🔧 Fixes</summary>

- [Maui Android parent view inappropriately creates clipping mask when
its opacity is less than 1, cropping out
children](#22038)
  </details>

- Fixed the FlexLayout reverse issue with the AlignContent by
@Ahamed-Ali in #32134
  <details>
  <summary>🔧 Fixes</summary>

- [FlexLayout alignment issue when Wrap is set to Reverse and
AlignContent is set to SpaceAround, SpaceBetween or
SpaceEvenly](#31565)
  </details>

- [iOS/Mac] Fixed BoxView in AbsoluteLayout did not return to its
default AutoSize for Height and Width after reset by @Dhivya-SF4094 in
#31648
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, Catalyst] BoxView in AbsoluteLayout does not return to default
AutoSize for Height/Width after
reset](#31496)
  </details>

## Map
- [Windows] Implement WinUI 3 MapControl handler using Azure Maps by
@jfversluis in #34138

## Modal
- [Android] PopToRootAsync for modal pages - improvements by @kubaflo in
#26851
  <details>
  <summary>🔧 Fixes</summary>

- [Shell PopToRootAsync doesn't happen instantly - previous pages flash
quickly. Only happens in NET
9](#26846)
  </details>

- [Android] Fix HideSoftInputOnTapped doesn't work on Modal Pages by
@HarishwaranVijayakumar in #34770
  <details>
  <summary>🔧 Fixes</summary>

- [HideSoftInputOnTapped doesn't work on Modal
Pages](#34730)
  </details>

## Navigation
- [iOS] Alert popup may be displayed on wrong window when modal page
navigation is in progress - fix by @kubaflo in
#31016
  <details>
  <summary>🔧 Fixes</summary>

- [Alert popup may be displayed on wrong window when modal page
navigation is in progress on
iOS/MacOS](#30970)
  </details>

- [Android] Page: Fix OnNavigatedTo called twice when NavigationPage is
FlyoutPage Detail by @KarthikRajaKalaimani in
#31931
  <details>
  <summary>🔧 Fixes</summary>

- [NavigationPage and FlyoutPage both call OnNavigatedTo, so it is
called twice](#23902)
  </details>

## Picker
- Fixed the Picker didn't dismiss it when tapping outside on iOS and
MacCatalyst platform. by @KarthikRajaKalaimani in
#30067
  <details>
  <summary>🔧 Fixes</summary>

- [[regression/8.0.3] iOS Picker dismiss does not work when clicking
outside of the Picker](#19168)
  </details>

- [Windows] Fixed Picker items width wont resize back by
@SubhikshaSf4851 in #33042
  <details>
  <summary>🔧 Fixes</summary>

- [Picker items width won't resize back when its container window gets
resized down.](#32984)
  </details>

## RadioButton
- Fix TalkBack not correctly narrating RadioButtons with Content by
@SubhikshaSf4851 in #34521
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] TalkBack does not correctly narrate RadioButtons with
Content](#34322)
  </details>

## SafeArea
- [Android] Fix SafeAreaShouldWorkOnAllShellTabs test failure on API 36
by @praveenkumarkarunanithi in #34239

## ScrollView
- [iOS] Preserve ScrollView offsets when Orientation changes to Neither
by @Vignesh-SF3580 in #34672
  <details>
  <summary>🔧 Fixes</summary>

- [Incorrect implementation of
ScrollView.Orientation](#34583)
  </details>

## Searchbar
- [Android] Fix SearchBar text bleeding between instances after
navigation by @SyedAbdulAzeemSF4852 in
#34703
  <details>
  <summary>🔧 Fixes</summary>

- [MAUI Android: SearchBar copies content from one to the
other](#20348)
  </details>

- Fixed SearchBar CursorPosition and SelectionLength not updating when
typing by @Dhivya-SF4094 in #34347
  <details>
  <summary>🔧 Fixes</summary>

- [SearchBar - CursorPosition and SelectionLength are not updated when
the user types](#30779)
  </details>

## SearchBar
- [Windows] Fixed SearchHandler issues by @Tamilarasan-Paranthaman in
#29520
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] SearchHandler APIs are not functioning
properly](#29493)
  </details>

## Shell
- [iOS, Mac] Fix for Background set to Transparent doesn't have the same
behavior as BackgroundColor Transparent by @HarishwaranVijayakumar in
#32245
  <details>
  <summary>🔧 Fixes</summary>

- [Background set to Transparent doesn't have the same behavior as
BackgroundColor =
Transparent](#22769)
  </details>

- [iOS] Fix App crash with NullReferenceException in
ShellSectionRenderer by @devanathan-vaithiyanathan in
#32109
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] App crash with NullReferenceException in
ShellSectionRenderer](#31961)
  </details>

- [Android] Fixed back button icon selection logic in
ShellToolbarTracker by @kubaflo in
#32080
  <details>
  <summary>🔧 Fixes</summary>

- [IconOverride in Shell.BackButtonBehavior does not
work.](#32050)
  </details>

- Fix TabBarIsVisible Not Updating Dynamically When Set on ShellContent
by @Vignesh-SF3580 in #33090
  <details>
  <summary>🔧 Fixes</summary>

- [Shell.TabBarIsVisible is not updated dynamically at
runtime](#32994)
  </details>

- [iOS, macOS] Shell: Fix RTL flow direction for flyout, menu cells, tab
bar, and Locked flyout position by @NanthiniMahalingam in
#32701
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, Mac Catalyst] Shell Flyout and Content Do Not Fully Support
RightToLeft (RTL)](#32419)
  </details>

- [IOS] Inconsistent Resize Behavior for Header/Footer - fix by @kubaflo
in #28713
  <details>
  <summary>🔧 Fixes</summary>

- [[IOS, Mac] Inconsistent Resize Behavior for
Header/Footer](#26397)
- [Enable Shell Flyout Header/Footer resize tests on
iOS/Catalyst](#33501)
  </details>

- [Android] Fix for SearchHandler retaining previous page SearchView
data in pages within Shell sections by @BagavathiPerumal in
#29545
  <details>
  <summary>🔧 Fixes</summary>

- [[Shell][Android] The truth is out there...but not on top tab search
handlers](#8716)
  </details>

- [Android] Fix empty space above TabBar after navigating back when
TabBar visibility is toggled by @praveenkumarkarunanithi in
#34324
  <details>
  <summary>🔧 Fixes</summary>

- [Empty space appears above TabBar after navigating back when TabBar
visibility is toggled](#33703)
- [Grid with SafeAreaEdges=Container has incorrect size when tab bar
appears](#34256)
  </details>

## SwipeView
- [Android] SwipeView: Use MeasureSpecMode.Exactly for SwipeItem layout
to fix text visibility by @Ahamed-Ali in
#27399
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Right SwipeView items are not visible in the
SwipeView.](#27367)
  </details>

- [Android] Prevent the tap that closes an open SwipeView from being
propagated to children by @sjordanGSS in
#24275
  <details>
  <summary>🔧 Fixes</summary>

- [Tapping to close a SwipeView will activate TapGestureRecognizers on
.Content](#23921)
  </details>

## Switch
- [iOS & Mac] Fix for SearchHandler retains previous page state when
switching top tabs by @BagavathiPerumal in
#34735
  <details>
  <summary>🔧 Fixes</summary>

- [[Shell] [iOS & Mac] SearchHandler retains previous page state when
switching top tabs](#34693)
  </details>

## TabbedPage
- [Android] Fixed NullReferenceException in app with TabBar after
returning from minimized state by @NirmalKumarYuvaraj in
#34779
  <details>
  <summary>🔧 Fixes</summary>

- [NullReferenceException in app with TabBar after returning from
minimized state](#34720)
  </details>

## Titlebar
- Fixed BindingContext of the Window TitleBar is not being passed on to
its child content. by @NirmalKumarYuvaraj in
#30080
  <details>
  <summary>🔧 Fixes</summary>

- [The BindingContext of the Window TitleBar is not being passed on to
its child content.](#24831)
  </details>

- [Windows/Mac] Fix RTL FlowDirection causes overlap with native window
control buttons in TitleBar by @devanathan-vaithiyanathan in
#30400
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows, Mac] RTL FlowDirection causes overlap with native window
control buttons in
TitleBar](#30399)
  </details>

## WebView
- [Windows] Fix WebView background color not being applied by
@SubhikshaSf4851 in #34599
  <details>
  <summary>🔧 Fixes</summary>

- [WebView background color has changed after update, can't
override.](#34518)
  </details>

- [Android] Fix for WebView/HybridWebView briefly flashes full screen
before layout completes by @praveenkumarkarunanithi in
#33207
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] HybridWebView briefly resizes to full screen when page is
opened before snapping back to correct
size](#31475)
  </details>

## Xaml
- Improved style inheritance by @kubaflo in
#31317
  <details>
  <summary>🔧 Fixes</summary>

- [Styles based on a style that is based on another style that uses
AppThemeBinding do not inherit properties
correctly.](#31280)
  </details>

- Fix for VisualStateManager Setter.TargetName failing when
ControlTemplate is applied by @BagavathiPerumal in
#33208
  <details>
  <summary>🔧 Fixes</summary>

- [Setter.TargetName + ControlTemplate
crash](#26977)
  </details>


<details>
<summary>🧪 Testing (4)</summary>

- [Testing] Additional Feature Matrix Event Test Cases for Slider and
ScrollView by @nivetha-nagalingam in
#34352
- [Testing] Fixed Build error on inflight/ candidate PR 34885 by
@NafeelaNazhir in #34891
- [Testing] Fixed UI test image failure in PR 34885 - [13/4/2026] by
@NafeelaNazhir in #34933
- Fixed test failure - CursorPositionUpdatesWhenSearchBarGainsFocus by
@Dhivya-SF4094 in #34938

</details>

<details>
<summary>📦 Other (3)</summary>

- Fix Loaded event not called for MAUI View added to native View by
@NirmalKumarYuvaraj in #34345
  <details>
  <summary>🔧 Fixes</summary>

- [Loaded event not called for MAUI View added to native
View](#34310)
  </details>
- Add public IAlertManager and IAlertManagerSubscription interfaces by
@Redth in #34228
  <details>
  <summary>🔧 Fixes</summary>

- [Alert/Dialog system (`DisplayAlert`, `DisplayActionSheet`,
`DisplayPromptAsync`) needs a public extensibility
point](#34104)
  </details>
- Fix crash when displaying alerts on unloaded pages by @kubaflo in
#33288

</details>

<details>
<summary>📝 Issue References</summary>

Fixes #5825, Fixes #8494, Fixes #8716, Fixes #10987, Fixes #11404, Fixes
#12008, Fixes #18200, Fixes #18551, Fixes #18657, Fixes #18701, Fixes
#19168, Fixes #19209, Fixes #20062, Fixes #20348, Fixes #20834, Fixes
#20991, Fixes #21983, Fixes #22038, Fixes #22193, Fixes #22197, Fixes
#22769, Fixes #23330, Fixes #23854, Fixes #23902, Fixes #23921, Fixes
#24304, Fixes #24831, Fixes #25124, Fixes #26059, Fixes #26397, Fixes
#26644, Fixes #26846, Fixes #26961, Fixes #26977, Fixes #27086, Fixes
#27367, Fixes #27959, Fixes #28337, Fixes #28351, Fixes #28660, Fixes
#28975, Fixes #29390, Fixes #29391, Fixes #29463, Fixes #29493, Fixes
#29544, Fixes #30052, Fixes #30065, Fixes #30071, Fixes #30144, Fixes
#30399, Fixes #30779, Fixes #30803, Fixes #30970, Fixes #31280, Fixes
#31446, Fixes #31475, Fixes #31496, Fixes #31565, Fixes #31825, Fixes
#31961, Fixes #32048, Fixes #32050, Fixes #32139, Fixes #32356, Fixes
#32419, Fixes #32771, Fixes #32944, Fixes #32984, Fixes #32994, Fixes
#33308, Fixes #33501, Fixes #33703, Fixes #33770, Fixes #33773, Fixes
#34104, Fixes #34256, Fixes #34257, Fixes #34310, Fixes #34322, Fixes
#34363, Fixes #34370, Fixes #34459, Fixes #34518, Fixes #34583, Fixes
#34591, Fixes #34666, Fixes #34693, Fixes #34720, Fixes #34730

</details>

**Full Changelog**:
main...inflight/candidate
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2026
@kubaflo kubaflo added the s/agent-gate-passed AI verified tests catch the bug (fail without fix, pass with fix) label May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/ios s/agent-approved AI agent recommends approval - PR fix is correct and optimal s/agent-fix-implemented PR author implemented the agent suggested fix s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates s/agent-gate-passed AI verified tests catch the bug (fail without fix, pass with fix) s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) shell-search-handler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Shell] [iOS & Mac] SearchHandler retains previous page state when switching top tabs

8 participants