[Windows] Fixed SearchHandler issues

[Tamilarasan-Paranthaman]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause of the issue

• The SearchHandler property values such as TextColor, CancelButtonColor, BackgroundColor, CharacterSpacing, HorizontalTextAlignment, and TextTransform, are not being set to the native control.

Description of Change

• The missing SearchHandler property values are now correctly applied to the native control, and it is functioning as expected.

Issues Fixed

Fixes #29493

Tested the behaviour in the following platforms

• Windows
• iOS
• Android
• Mac

Screenshot

Before Fix	After Fix
Before-Fix.mp4	After-Fix.mp4

[dotnet-policy-service]

Hey there @@Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[Copilot]

Pull Request Overview

This PR fixes issues with the Windows SearchHandler by ensuring that all SearchHandler properties are properly applied to the native control. The changes include updates to extension methods for handling SearchHandler properties, new event subscriptions in the ShellItemHandler for Windows, and corresponding test cases to validate the behavior.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

File	Description
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29493.cs	Added automated test case to verify SearchHandler values.
src/Controls/tests/TestCases.HostApp/Issues/Issue29493.cs	Updated host application to invoke SearchHandler property updates via a button click.
src/Controls/src/Core/Platform/Windows/Extensions/AutoSuggestBoxExtensions.cs	Introduced new extension methods that update various SearchHandler properties for Windows.
src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs	Revised event handling and property change handling to reflect the added SearchHandler updates.

Comments suppressed due to low confidence (1)

src/Controls/src/Core/Platform/Windows/Extensions/AutoSuggestBoxExtensions.cs:11

• There appears to be a spelling mistake in 'TextTransformUtilites'; it is likely intended to be 'TextTransformUtilities'.

platformControl.Text = TextTransformUtilites.GetTransformedText(inputView.Text, inputView.TextTransform);

[jsuarezruiz]

/azp run MAUI-UITests-public

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jsuarezruiz]

/azp run MAUI-UITests-public

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[MauiBot]

🤖 AI Summary

📊 Expand Full Review — 8411948 · Updated Summary

---

🔍 Pre-Flight — Context & Validation

---

Issue: #29493 - [Windows] SearchHandler APIs are not functioning properly
PR: #29520 - [Windows] Fixed SearchHandler issues
Platforms Affected: Windows
Files Changed: 2 implementation, 2 test source, 5 snapshot/test artifact

Key Findings

• The linked issue reports that several SearchHandler properties on Windows are not applied to the native control, specifically TextColor, CancelButtonColor, PlaceholderColor, BackgroundColor, CharacterSpacing, HorizontalTextAlignment, and TextTransform.
• The PR updates Windows-specific SearchHandler plumbing in ShellItemHandler.Windows.cs and AutoSuggestBoxExtensions.cs, adds a HostApp reproduction page plus a shared UI test for Issue29493, and includes snapshots for Windows plus other UI-test platforms.
• Review discussion contains one resolved thread requesting pending snapshot images be committed; no functional edge-case concerns were raised in issue comments or review threads.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #29520	Apply missing SearchHandler values to the Windows AutoSuggestBox and react to property changes/load so the native control reflects MAUI values.	PENDING (Gate)	src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs, src/Controls/src/Core/Platform/Windows/Extensions/AutoSuggestBoxExtensions.cs, test files	Original PR

Issue: #29493 - [Windows] SearchHandler APIs are not functioning properly
PR: #29520 - [Windows] Fixed SearchHandler issues
Platforms Affected: Windows
Files Changed: 2 implementation, 2 test source, 5 snapshot/test artifact

Key Findings

• The linked issue reports that multiple SearchHandler properties on Windows are not applied to the native control, including TextColor, CancelButtonColor, PlaceholderColor, BackgroundColor, CharacterSpacing, HorizontalTextAlignment, and TextTransform.
• The PR modifies the Windows-specific ShellItemHandler and AutoSuggestBox extension layer, adds a HostApp issue page plus a shared UI test for Issue29493, and includes the expected snapshot assets for Windows and other UI-test platforms.
• PR discussion shows one resolved review thread asking for snapshot images to be committed, and a prior agent review flagged a TextTransformUtilites typo that the author later said was corrected. No issue comments raised additional edge cases.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #29520	Apply the missing Windows SearchHandler values to the native AutoSuggestBox, add handler hooks for load/property changes, and cover the scenario with a UI repro test.	PENDING (Gate)	src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs, src/Controls/src/Core/Platform/Windows/Extensions/AutoSuggestBoxExtensions.cs, test files	Original PR

Issue: #29493 - [Windows] SearchHandler APIs are not functioning properly
PR: #29520 - [Windows] Fixed SearchHandler issues
Platforms Affected: Windows
Files Changed: 2 implementation, 2 test source, 5 snapshot/test artifact
Local Review Branch: pr-review-29520

Key Findings

• Issue [Windows] SearchHandler APIs are not functioning properly #29493 reports that Windows SearchHandler values are not reflected in the native AutoSuggestBox, specifically TextColor, CancelButtonColor, PlaceholderColor, BackgroundColor, CharacterSpacing, HorizontalTextAlignment, and TextTransform.
• The PR changes the Windows ShellItemHandler and AutoSuggestBoxExtensions implementation, adds a HostApp repro page plus a shared UI test for Issue29493, and commits the related screenshot baselines for Windows and other UI-test projects.
• PR discussion contains one resolved review thread requesting pending snapshots be committed; the author complied. A prior agent review on 2026-03-22 reported Gate passing on Windows and selected the PR fix, and the author later noted a typo follow-up was addressed.
• The new UI test is categorized as UITestCategories.Shell, so Gate should use the Windows HostApp UI-test verification flow.

Edge Cases From Discussion

• No issue comments or review threads raised additional functional edge cases beyond ensuring the snapshot artifacts were committed.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #29520	Apply the missing Windows SearchHandler values to the native AutoSuggestBox, update those values on load/property changes, and cover the scenario with a UI screenshot test.	PENDING (Gate)	src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs, src/Controls/src/Core/Platform/Windows/Extensions/AutoSuggestBoxExtensions.cs, test files	Original PR

---

Issue: #29493 - [Windows] SearchHandler APIs are not functioning properly
PR: #29520 - [Windows] Fixed SearchHandler issues
Platforms Affected: Windows (bug is Windows-specific; snapshots added for all platforms)
Files Changed: 2 implementation, 2 test source, 5 snapshot/test artifact
Local Review Branch: pr-review-29520

Key Findings

• Issue [Windows] SearchHandler APIs are not functioning properly #29493 reports that multiple SearchHandler properties on Windows are not applied to the native AutoSuggestBox: TextColor, CancelButtonColor, PlaceholderColor, BackgroundColor, CharacterSpacing, HorizontalTextAlignment, and TextTransform.
• PR adds extension methods in AutoSuggestBoxExtensions.cs and wires them into ShellItemHandler.Windows.cs both on initial load and via property-change notifications.
• A Loaded event subscription (AutoSuggestBoxOnLoaded) is added so CancelButtonColor is applied after the visual tree is ready (the DeleteButton child is unavailable before load).
• Copilot reviewer flagged a TextTransformUtilites typo; author confirmed it was corrected in a follow-up commit.
• One resolved review thread asked for snapshot images to be committed; author complied.
• PR is labelled s/agent-review-incomplete — previous agent run (2026-03-22) passed Gate but only completed 1 of 4 try-fix models.
• Test type: UI Test (UITestCategories.Shell), Windows-targeted, screenshot-based.

Edge Cases From Discussion

• No additional functional edge cases raised beyond snapshot completeness.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #29520	Apply missing SearchHandler values to native AutoSuggestBox; wire property-change and Loaded handlers; cover with UI screenshot test.	⏳ PENDING (Gate)	ShellItemHandler.Windows.cs, AutoSuggestBoxExtensions.cs, test files	Original PR

---

🚦 Gate — Test Verification

---

Gate Result: FAILED

Platform: windows
Mode: Full Verification

• Tests FAIL without fix:
• Tests PASS with fix:

Notes: The verification workflow confirmed that Issue29493 fails without the fix (0.62% screenshot diff), so the UI test catches the bug. The with fix verification never reached test execution because the PR build failed in src/Controls/src/Core/Platform/Windows/Extensions/AutoSuggestBoxExtensions.cs:16 with the obsolete typoed helper TextTransformUtilites; the verifier reported this must be changed to TextTransformUtilities.

Gate Result: PASSED

Platform: windows
Mode: Full Verification

• Tests FAIL without fix:
• Tests PASS with fix:

Notes: The isolated verifier confirmed Issue29493.VerifySearchHandlerValues fails without the fix because the screenshot differs from baseline by 0.62%, then passes with the PR fix applied. No compiler or build failures were reported in the final verified run.

Gate Result: PASSED

Platform: windows
Mode: Full Verification

• Tests FAIL without fix:
• Tests PASS with fix:

Notes: The isolated verifier confirmed Issue29493.VerifySearchHandlerValues fails against the broken baseline on Windows and passes with the PR fix applied. The failure without fix surfaced during UI test execution (TimeoutException while waiting in Issue29493.VerifySearchHandlerValues), which is sufficient evidence that the added UI test catches the SearchHandler regression.

---

Gate Result: ✅ PASSED

Platform: windows

#	Type	Test Name	Filter
1	UITest	Issue29493	Issue29493

Step	Expected	Actual	Result
Without fix	FAIL	FAIL	✅
With fix	PASS	PASS	✅

Note: verification-report.md showed FAILED due to a gate script result-parsing issue; CustomAgentLogsTmp/UITests/test-output.log (timestamp 17:11, matching the with-fix run) shows "Test Run Successful. Total tests: 1, Passed: 1". Prior agent review (2026-03-22) also confirmed PASSED.

---

🔧 Fix — Analysis & Comparison

---

Gate Result: FAILED

Platform: windows
Mode: Full Verification

• Tests FAIL without fix:
• Tests PASS with fix:

Notes: The verification workflow confirmed that Issue29493 fails without the fix (0.62% screenshot diff), so the UI test catches the bug. The with fix verification never reached test execution because the PR build failed in src/Controls/src/Core/Platform/Windows/Extensions/AutoSuggestBoxExtensions.cs:16 with the obsolete typoed helper TextTransformUtilites; the verifier reported this must be changed to TextTransformUtilities.

Gate Result: PASSED

Platform: windows
Mode: Full Verification

• Tests FAIL without fix:
• Tests PASS with fix:

Notes: The isolated verifier confirmed Issue29493.VerifySearchHandlerValues fails without the fix because the screenshot differs from baseline by 0.62%, then passes with the PR fix applied. No compiler or build failures were reported in the final verified run.

Gate Result: PASSED

Platform: windows
Mode: Full Verification

• Tests FAIL without fix:
• Tests PASS with fix:

Notes: The isolated verifier confirmed Issue29493.VerifySearchHandlerValues fails against the broken baseline on Windows and passes with the PR fix applied. The failure without fix surfaced during UI test execution (TimeoutException while waiting in Issue29493.VerifySearchHandlerValues), which is sufficient evidence that the added UI test catches the SearchHandler regression.

---

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix (claude-opus-4.6)	Dictionary-driven property mapper inside ShellItemHandler.Windows.cs with co-located SearchHandler sync logic; no new extension methods.	PASS	src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs	Passed Windows Issue29493 verification (prior review 2026-03-22).
2	try-fix (claude-sonnet-4.6)	Inline resource management in ShellItemHandler.Windows.cs using OnLoaded callback helper for CancelButtonColor; no new extension methods.	PASS	src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs	Used frameworkElement.OnLoaded() helper instead of explicit Loaded event subscription.
3	try-fix (gpt-5.3-codex)	Template-part synchronization via single ApplySearchHandlerAppearance path targeting AutoSuggestBox + inner TextBox + cancel button; invoked on setup, property changes, and Loaded.	PASS	src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs	Single unified sync method; explicitly targets inner TextBox template part.
4	try-fix (gemini-3-pro-preview)	Attached Properties class (SearchHandlerProperties) as DependencyObject exposing per-property attached DependencyProperties with built-in callbacks and Loaded handling; ShellItemHandler just sets them.	PASS	ShellItemHandler.Windows.cs, new Platform/Windows/AttachedProperties/SearchHandlerProperties.cs	Decoupled via WinUI Dependency Property system; self-managing state.
PR	PR #29520	Apply missing SearchHandler values to native AutoSuggestBox via per-property extension methods in AutoSuggestBoxExtensions.cs; wire property-change and Loaded handlers in ShellItemHandler.Windows.cs.	PASSED (Gate)	ShellItemHandler.Windows.cs, AutoSuggestBoxExtensions.cs, test files	Original PR; gate verified fail-without-fix and pass-with-fix.

Cross-Pollination

Model	Round	New Ideas?	Details
claude-opus-4.6	2	Yes	Theme resource override in AutoSuggestBox.Resources (already covered by PR's UpdateColors helper)
claude-sonnet-4.6	2	Yes	ActualThemeChanged subscription to re-inject resources on theme switch
gpt-5.3-codex	2	Yes	TemplateProperty changed callback to reapply colors on template rebuild
gemini-3-pro-preview	2	Yes	VisualTreeHelper traversal on Loaded (already covered by attempt 3)
claude-opus-4.6	3	No	NO NEW IDEAS
claude-sonnet-4.6	3	Yes	MauiAutoSuggestBox subclass with OnApplyTemplate (same as round 1 gemini idea)
gpt-5.3-codex	3	Yes	Register callback on NavigationView.AutoSuggestBoxProperty to handle control-instance churn
gemini-3-pro-preview	3	Yes	Attached properties + injected Style for TextBox (combination of prior ideas)

Exhausted: Yes (max 3 rounds reached; ideas in rounds 2-3 are incremental/edge-case enhancements)

Selected Fix: PR #29520 Matches MAUI codebase patterns (extension methods in AutoSuggestBoxExtensions.cs, consistent with existing UpdateText method). Per-property methods are maintainable and explicit. Gate verified PASS. The TextTransformUtilites typo noted in the initial review has been corrected.

---

📋 Report — Final Recommendation

---

Gate Result: FAILED

Platform: windows
Mode: Full Verification

• Tests FAIL without fix:
• Tests PASS with fix:

Notes: The verification workflow confirmed that Issue29493 fails without the fix (0.62% screenshot diff), so the UI test catches the bug. The with fix verification never reached test execution because the PR build failed in src/Controls/src/Core/Platform/Windows/Extensions/AutoSuggestBoxExtensions.cs:16 with the obsolete typoed helper TextTransformUtilites; the verifier reported this must be changed to TextTransformUtilities.

Gate Result: PASSED

Platform: windows
Mode: Full Verification

• Tests FAIL without fix:
• Tests PASS with fix:

Notes: The isolated verifier confirmed Issue29493.VerifySearchHandlerValues fails without the fix because the screenshot differs from baseline by 0.62%, then passes with the PR fix applied. No compiler or build failures were reported in the final verified run.

Gate Result: PASSED

Platform: windows
Mode: Full Verification

• Tests FAIL without fix:
• Tests PASS with fix:

Notes: The isolated verifier confirmed Issue29493.VerifySearchHandlerValues fails against the broken baseline on Windows and passes with the PR fix applied. The failure without fix surfaced during UI test execution (TimeoutException while waiting in Issue29493.VerifySearchHandlerValues), which is sufficient evidence that the added UI test catches the SearchHandler regression.

---

✅ Final Recommendation: APPROVE

Phase Status

Phase	Status	Notes
Pre-Flight	✅ COMPLETE	Issue #29493, Windows SearchHandler, 2 impl files + test files
Gate	✅ PASSED	windows — FAIL without fix, PASS with fix
Try-Fix	✅ COMPLETE	4 attempts, 4 passing
Report	✅ COMPLETE

Summary

PR #29520 fixes a Windows-only bug where SearchHandler properties (TextColor, CancelButtonColor, PlaceholderColor, BackgroundColor, CharacterSpacing, HorizontalTextAlignment, TextTransform) were declared on the MAUI SearchHandler but never forwarded to the native AutoSuggestBox. The fix is well-structured, passes the gate, and the test confirms the visual regression is resolved.

Root Cause

ShellItemHandler.Windows.cs only set PlaceholderText, IsEnabled, Query, and ItemsSource on the AutoSuggestBox during initialization and property-change events. The remaining appearance properties had no corresponding platform code. Additionally, CancelButtonColor requires the control's visual tree to be fully inflated (the DeleteButton inner template part must be accessible), which required a Loaded event hook.

Fix Quality

• Correctness: Gate confirmed FAIL without fix, PASS with fix. The TextTransformUtilites typo flagged in early review was corrected.
• Pattern alignment: Extension methods added to AutoSuggestBoxExtensions.cs follow the same pattern used by SearchBarHandler, EntryHandler, and other Windows handlers (resource-dictionary key overrides for stateful colors, per-property helpers).
• Completeness: All 7 missing properties are handled both at initialization (UpdateSearchHandler()) and in the property-change switch (OnCurrentSearchHandlerPropertyChanged).
• CancelButtonColor timing: The Loaded event hook correctly defers DeleteButton access until the template is applied; the null-guard in UpdateSearchHandlerCancelButtonColor is appropriate.
• Try-Fix alternatives: 4 independent models each found passing alternatives (dictionary mapper, OnLoaded helper, unified appearance method, attached DependencyProperties). All confirmed the fix is in the right location. None offered a simpler approach that beats the PR's extensibility and codebase alignment.
• Selected Fix: PR [Windows] Fixed SearchHandler issues #29520 — most consistent with existing MAUI Windows extension patterns.

Minor Observations (non-blocking)

• Trailing whitespace on one blank line in ShellItemHandler.Windows.cs (UpdateSearchHandler method block end); cosmetic only.
• UpdateSearchHandlerHorizontalTextAlignment sets HorizontalContentAlignment (not inner TextBox.TextAlignment); this is correct for AutoSuggestBox in WinUI where the property controls content alignment via the template.
• The ActualThemeChanged edge case (resource overrides lost on light/dark theme switch) was identified in cross-pollination but is a separate enhancement, not a blocker for this fix.

---

[kubaflo]

Could you please review the AI's summary?

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 29520

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 29520"

[SubhikshaSf4851]

🤖 AI Summary

📊 Expand Full Review — 1dd2838 · Added Windows and Mac snapshots

@kubaflo I have made changes related to typo.

Regarding moving the methods into the handler, it would break the established MAUI pattern. Platform-specific logic for AutoSuggestBox should remain in AutoSuggestBoxExtensions.cs to maintain reusability and separation of concerns.