Nullability checks for ShellPageRendererTracker#27160
Closed
PureWeen wants to merge 4 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs:365
- The variable 'image' should be checked for null before calling 'LoadImage'.
image.LoadImage(mauiContext, result => { ... })
PureWeen
force-pushed
the
add_null_checking_page_renderer_tracker
branch
from
40beaf2 to
2fa5e85
Compare
Contributor
|
Needs retarget to net10.0 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This contains all the code fixes made to #27159 but we can't modify the public nullability of this file until .NET 10
These changes were motivated by the following PR #26786
We modified the ViewController property to be a weak reference so we need to account for scenarios where it might become null without us realizing it.
Follow up work here #27162