net10_nullability_page_renderer_tracker#27159
Closed
PureWeen wants to merge 1 commit into
Closed
Conversation
PureWeen
force-pushed
the
null_ref_checks_ShellPageRendererTracker
branch
from
8ab6626 to
4b3d01f
Compare
PureWeen
commented
Feb 3, 2025
| ~Microsoft.Maui.Controls.Platform.Compatibility.ShellNavBarAppearanceTracker.SetAppearance(UIKit.UINavigationController controller, Microsoft.Maui.Controls.ShellAppearance appearance) -> void | ||
| ~Microsoft.Maui.Controls.Platform.Compatibility.ShellNavBarAppearanceTracker.UpdateLayout(UIKit.UINavigationController controller) -> void | ||
| ~Microsoft.Maui.Controls.Platform.Compatibility.ShellPageRendererTracker.Page.get -> Microsoft.Maui.Controls.Page | ||
| ~Microsoft.Maui.Controls.Platform.Compatibility.ShellPageRendererTracker.Page.set -> void |
Member
Author
There was a problem hiding this comment.
This is probably wrong but I haven't figured out how to do this correctly
Member
There was a problem hiding this comment.
There used to be a ~ character at the beginning of the line, what does that do?
It also seems like the getter should change to a nullable Microsoft.Maui.Controls.Page?, right?
Member
There was a problem hiding this comment.
You can also file an issue on this repo, if it's a bug, here is their doc:
Member
Author
There was a problem hiding this comment.
I also noticed we're on version 3.3.4 and they are up to 3.11.0-beta*
I tried the beta one but that just started causing a whole bunch of new warnings to address.
So probably pause on this for now
PureWeen
changed the title
PureWeen
force-pushed
the
null_ref_checks_ShellPageRendererTracker
branch
from
6adba36 to
3dbf546
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Fixed
Fixes #