Skip to content

[runtime] Complete support for exception marshalling on CoreCLR.#11734

Merged
rolfbjarne merged 3 commits into
dotnet:mainfrom
rolfbjarne:coreclr-exception-marshalling
May 31, 2021
Merged

[runtime] Complete support for exception marshalling on CoreCLR.#11734
rolfbjarne merged 3 commits into
dotnet:mainfrom
rolfbjarne:coreclr-exception-marshalling

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member
  • This also required an empty implementation of the toggle ref machinery,
    because the ObjectiveCMarshal.Initialize call to initialize unhandled
    exception support requires passing toggle ref callbacks as well. The
    complete implementation is more complex, and will come in an uncoming PR.

  • The TestConstrainedGenericType test can now be re-enabled, after a few
    updates.

We need this to use the unhandled exception handler support in CoreCLR,
because the ObjectiveCMarshal.Initialize call to initialize unhandled
exception support requires passing toggle ref callbacks as well.
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels May 28, 2021
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 170 tests passed.

Failed tests

  • monotouch-test/Mac [dotnet]/Debug (CoreCLR) [dotnet]: Failed (Test run failed.
    Tests run: 2444 Passed: 2355 Inconclusive: 7 Failed: 3 Ignored: 86)
  • monotouch-test/Mac [dotnet]/Debug (CoreCLR, static registrar) [dotnet]: Failed (Test run failed.
    Tests run: 2441 Passed: 2355 Inconclusive: 7 Failed: 1 Ignored: 85)

Pipeline on Agent XAMBOT-1099.BigSur'
Merge 11df830 into 51c9364

@rolfbjarne

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants