[dynamic registrar] Free the return value from mono_signature_get_params and mono_signature_get_return_type.#11730
Merged
rolfbjarne merged 1 commit intoMay 31, 2021
Conversation
…ams and mono_signature_get_return_type.
Before:
There were 258042 MonoObjects created, 235166 MonoObjects freed, so 22876 were not freed. (dynamic registrar)
There were 205804 MonoObjects created, 204219 MonoObjects freed, so 1585 were not freed. (static registrar)
After:
There were 258066 MonoObjects created, 246781 MonoObjects freed, so 11285 were not freed. (dynamic registrar)
There were 205804 MonoObjects created, 204491 MonoObjects freed, so 1313 were not freed. (static registrar)
rolfbjarne
added
not-notes-worthy
Collaborator
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. GitHub pagesResults can be found in the following github pages (it might take some time to publish): |
Member
Author
|
🥳 |
spouliot
reviewed
May 28, 2021
| } else { | ||
| for (int i = 0; i < index + 1; i++) | ||
| for (int i = 0; i < index + 1; i++) { | ||
| xamarin_mono_object_release (&p); |
Contributor
There was a problem hiding this comment.
I assume it's fine if the first iteration points to NULL, right ?
Member
Author
There was a problem hiding this comment.
Correct, a pointer to NULL will be ignored.
| for (int i = 0; i < index + 1; i++) { | ||
| xamarin_mono_object_release (&p); | ||
| p = mono_signature_get_params (msig, &iter); | ||
| } |
Contributor
There was a problem hiding this comment.
what will release the last p assigned in the loop ?
Member
Author
There was a problem hiding this comment.
It will be returned from this function, and the caller will have to release it.
spouliot
approved these changes
May 28, 2021
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 106 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur |
Member
Author
|
Test failures are unrelated
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: