Skip to content

Avoid boxing/unboxing in VBufferDataFrameColumn #6864

Description

@asmirnov82

VBufferDataFrameColumn stores public readonly struct Vbuffer items.
This column is implemented based on current StringDataFrame column implementation, however any string is a reference type and any Vbuffer is a value type, so there are several issues with current implementation. One is boxing/unboxing that happens on ever access by row index, another - unability to store null elements (#6852)

The goal of this issue is to avoid boxing/unboxing on indexing and throw NotSupported exception with clear explanation instead of null reference exception

Activity

  1. ghost added
    untriagedNew issue has not been triaged
    on Oct 16, 2023
  2. ghost added
    in-prA pull request is open to resolve this issue
    on Oct 16, 2023
  3. ghost removed
    in-prA pull request is open to resolve this issue
    on Oct 16, 2023
  4. ghost removed
    untriagedNew issue has not been triaged
    on Oct 16, 2023
  5. ghost added
    in-prA pull request is open to resolve this issue
    on Oct 17, 2023
  6. ghost removed
    in-prA pull request is open to resolve this issue
    on Oct 17, 2023
  7. ghost locked as resolved and limited conversation to collaborators on Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions