Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update ApiCompatBaseline for uapaot for System.Runtime#29230

Merged
jkotas merged 1 commit into
dotnet:masterfrom
ahsonkhan:UpdateAPICompatBase
Apr 24, 2018
Merged

Update ApiCompatBaseline for uapaot for System.Runtime#29230
jkotas merged 1 commit into
dotnet:masterfrom
ahsonkhan:UpdateAPICompatBase

Conversation

@ahsonkhan

Copy link
Copy Markdown

Leftover from #29138.

cc @jkotas, @morganbr

@ahsonkhan

Copy link
Copy Markdown
Author

D:\GitHub\Fork\corefx\Tools\ApiCompat.targets(58,5): error : MembersMustExist : Member 'System.ReadOnlySpan.GetPinnableReference()' does not exist in the implementation but it does exist in the contract. [D:\GitHub\Fork\corefx\src\System.Runtime\src\System.Runtime.csproj]
D:\GitHub\Fork\corefx\Tools\ApiCompat.targets(58,5): error : MembersMustExist : Member 'System.Span.GetPinnableReference()' does not exist in the implementation but it does exist in the contract. [D:\GitHub\Fork\corefx\src\System.Runtime\src\System.Runtime.csproj]
D:\GitHub\Fork\corefx\Tools\ApiCompat.targets(72,5): error : ApiCompat failed for 'D:\GitHub\Fork\corefx\bin\Windows_NT.AnyCPU.Debug\System.Runtime\uapaot\System.Runtime.dll' [D:\GitHub\Fork\corefx\src\System.Runtime\src\System.Runtime.csproj]

We have GetPinnabeleReference in corert but I think we have to wait until the ProjectN build update is through: #29202

@jkotas

jkotas commented Apr 20, 2018

Copy link
Copy Markdown
Member

You need to first wait for the change to be integrated into https://github.com/dotnet/corert/tree/nmirror

@ahsonkhan

Copy link
Copy Markdown
Author

@morganbr

Copy link
Copy Markdown

I've confirmed they're in TFS as well. We'll have to wait for the next official build there, which I think will be Sunday night.

@karelz karelz added this to the 2.2.0 milestone Apr 21, 2018
@ahsonkhan

Copy link
Copy Markdown
Author

@dotnet-bot test this please

@ahsonkhan

Copy link
Copy Markdown
Author

@jkotas jkotas merged commit ade27b6 into dotnet:master Apr 24, 2018
@ahsonkhan ahsonkhan deleted the UpdateAPICompatBase branch April 24, 2018 18:45
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants