This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-02719-03, preview1-26420-01, preview3-26420-01, preview1-26420-05, beta-26420-00, beta-26420-00, servicing-26419-02, respectively (master)#29202
Merged
stephentoub merged 6 commits intoApr 20, 2018
Conversation
Author
|
Discarded CI Status: 2:hourglass: 12:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
20f5b97 to
d1a3803
Compare
Author
|
Discarded CI Status: 9:hourglass: 5:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
d1a3803 to
cc5a78c
Compare
Author
|
Discarded CI Status: 4:x: 10:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
cc5a78c to
d4f90f3
Compare
Member
|
@jkotas, tests are failing all over the place. Bad JIT or runtime change? |
Author
|
Discarded CI Status: 4:x: 10:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
d4f90f3 to
a6e5168
Compare
Author
|
Discarded CI Status: 3:x: 1:hourglass: 10:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
a6e5168 to
7911627
Compare
Member
|
Looks like a problem with dotnet/coreclr#17639 @atsushikan Do you prefer to fix it quickly or rollback? |
|
I can repro it locally - I can't do a quick fix right now, though. Rolling back. |
|
PR for rollback: dotnet/coreclr#17671 |
Author
|
Discarded CI Status: 4:x: 10:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
7911627 to
998111f
Compare
Author
|
Discarded CI Status: 1:x: 5:hourglass: 8:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
998111f to
b134d43
Compare
Author
|
Discarded CI Status: 11:hourglass: 3:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
b134d43 to
4ba2a62
Compare
Author
|
Discarded CI Status: 4:x: 1:hourglass: 9:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
4ba2a62 to
d4d3bad
Compare
Author
|
Discarded CI Status: 5:x: 1:hourglass: 8:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
d4d3bad to
4021a7d
Compare
Author
|
Discarded CI Status: 5:x: 7:heavy_check_mark: (click to expand)
|
…fsTestILC, Standard to preview1-02719-03, preview1-26420-01, preview3-26420-01, preview1-26420-05, beta-26420-00, beta-26420-00, servicing-26419-02, respectively
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
4021a7d to
7ff287c
Compare
Workaround issue where a local build of packages will have a lower version than the closure of NETCore.App
Member
|
Tests are now failing due to dotnet/coreclr#17668... I'll fix up the tests... |
…fsTestILC, Standard to preview1-02719-03, preview1-26420-01, preview3-26420-01, preview1-26420-05, beta-26420-00, beta-26420-00, servicing-26419-02, respectively
Member
|
I'm fixing the packaging build. Are you fixing tests in this PR or in a separate PR? I will do the same for packaging build. |
Member
|
@ericstj, I was going to do it in this PR. Is that going to cause problems for you? |
Member
|
Nope, not at all. I didn't want to be the cause for blocking up maestro if we needed newer builds (I wasn't sure about those test failures). Thanks Steve. |
We now consider netcoreapp2.2 for validation and the ingested NETCore.App package is from 2.2. Make sure we can use the current CLI for testing on 2.2, and move the 2.1 tests to use a release branch package.
stephentoub
force-pushed
the
master-UpdateDependencies
branch
from
7ff287c to
1d79991
Compare
…-maestro-bot/corefx into master-UpdateDependencies
Author
|
Couldn't update this pull request: Head commit author 'Eric St. John' is not 'dotnet-maestro-bot' |
1 similar comment
Author
|
Couldn't update this pull request: Head commit author 'Eric St. John' is not 'dotnet-maestro-bot' |
Member
|
Thanks, Eric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.