Skip to content

PyPy support - #749

Closed
funkyfuture wants to merge 3 commits into
docker:masterfrom
funkyfuture:pypy-support
Closed

PyPy support#749
funkyfuture wants to merge 3 commits into
docker:masterfrom
funkyfuture:pypy-support

Conversation

@funkyfuture

Copy link
Copy Markdown
Contributor

this adds tests against PyPy2 and PyPy3.

i couldn't test locally due to networking problems, but once already tested successfully against both interpreters. let's see what travis says.

sits on top of #747

@funkyfuture

Copy link
Copy Markdown
Contributor Author

make test also passes.

@shin-

shin- commented Aug 31, 2015

Copy link
Copy Markdown
Contributor

So, merging that PR comes with the expectation that we'll support Pypy specific issues in the future. I'm not sure I want to commit to that.

Of course, that doesn't mean that we'll intentionally break it, or that we won't make a reasonable effort to help fix it if it's broken.

@funkyfuture

Copy link
Copy Markdown
Contributor Author

of course one could explicitly formulate in the README that there's no guarantee that PyPy will be supported, but efforts are made (and thus it should be tested).

i wouldn't anticipate any changes to a rest-adapter that still could break compatibility. you'll mainly extend the interfaces according to Docker's evolvement, right?

@funkyfuture

Copy link
Copy Markdown
Contributor Author

afaik, compatibility issues with PyPy are expected when using C-extensions and the inspect-module.

shin- and others added 3 commits March 20, 2017 21:08
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Frank Sachsenheim <funkyfuture@riseup.net>
@funkyfuture

Copy link
Copy Markdown
Contributor Author

rebased on master and the tests still pass with PyPy, i added a config that allows them to fail on travis anyway.

@funkyfuture
funkyfuture deleted the pypy-support branch October 5, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants