Skip to content

Integration test improvements - #747

Merged
shin- merged 1 commit into
docker:masterfrom
aanand:integration-test-fixes
Aug 31, 2015
Merged

Integration test improvements#747
shin- merged 1 commit into
docker:masterfrom
aanand:integration-test-fixes

Conversation

@aanand

@aanand aanand commented Aug 27, 2015

Copy link
Copy Markdown
Contributor
  • Fix the setup step (the process has changed now that we're using pytest)
  • Skip tests that are unstable
  • Make better use of build caching

Comment thread tests/integration_test.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using a list to store a single value? Am I missing something?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A hack caused by my misunderstanding of what features existed in Python 2 and 3. Updated to use global.

- Fix the setup step (the process has changed now that we're using
  pytest)

- Skip tests that are unstable

- Make better use of build caching

Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
@aanand
aanand force-pushed the integration-test-fixes branch from 1088b8d to 6c0f718 Compare August 31, 2015 19:06
shin- added a commit that referenced this pull request Aug 31, 2015
@shin-
shin- merged commit ad608ba into docker:master Aug 31, 2015
@shin- shin- added this to the 1.4.0 milestone Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants