Add codecov badge#69
Conversation
bachand
left a comment
There was a problem hiding this comment.
Approving though it sounds like we're still having some issues with codecov (see #67 (comment)) so it may be best if we feel more confident before we add the badge.
Separately, would it be expected that this PR itself has a codecov comment?
Yup. Going to try to get the other PR working before I merge this.
That we would! Working on it in #68 |
|
Now that #68 is merged, I'll get this in once CI goes green again. |
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 14 14
Lines 562 562
=======================================
Hits 541 541
Misses 21 21 |
|
@dfed I'm wondering how we can avoid this codecov warning? It seems like when you pushed bb99592 we somehow didn't update codecov with the necessary information to recompute code coverage? I came to that conclusion since that I see that codecov added this warning later, and the original message is comparing ea12b06, the previous commit, to the base branch. |
|
If you'd prefer I can file an issue on this too. Not trying to add more work. You've already done some amazing KTLO work on this repo this week :) |
|
Oh I know what happened here @bachand. I merged My guess is that codecov doesn't update posts on closed/merged PRs, so we never got to see the update for the latest commit. I guess that teaches me not to take shortcuts 😅 |
|
Ah OK I'm relieved we have a good theory 👍 |


As title