Get codecov working again

[dfed]

PRs are no longer getting code coverage reports. It looks like we stopped successfully uploading code coverage reports when we moved to Github Actions:

I'm not sure how that PR broke things, but running locally I see that test runs utilizing swift packages have a .framework suffix, and test runs utilizing a generated xcodeproj do not. Fixing this seems to have fixed codecov.

[codecov]

Codecov Report

Merging #67 (8920426) into main (aa680f4) will increase coverage by 96.14%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main      #67       +/-   ##
=========================================
+ Coverage      0   96.14%   +96.14%     
=========================================
  Files         0       26       +26     
  Lines         0     1996     +1996     
=========================================
+ Hits          0     1919     +1919     
- Misses        0       77       +77     

Impacted Files	Coverage Δ
Sources/SwiftTryCatch/SwiftTryCatch.m	84.61% <0.00%> (ø)
Tests/SwiftTryCatchTests/SwiftTryCatchTests.swift	95.74% <0.00%> (ø)
Sources/CacheAdvance/FileHandleExtensions.swift	57.14% <0.00%> (ø)
Sources/CacheAdvance/BigEndianHostSwappable.swift	100.00% <0.00%> (ø)
Sources/CacheAdvance/BoolExtensions.swift	100.00% <0.00%> (ø)
...sts/CacheAdvanceTests/CacheHeaderHandleTests.swift	100.00% <0.00%> (ø)
Tests/CacheAdvanceTests/TestableMessage.swift	100.00% <0.00%> (ø)
Sources/CADCacheAdvance/CADCacheAdvance.swift	70.45% <0.00%> (ø)
Sources/CacheAdvance/CacheReader.swift	93.15% <0.00%> (ø)
...s/CacheAdvance/UInt64+BigEndianHostSwappable.swift	100.00% <0.00%> (ø)
... and 16 more

[dfed]

This change works, and only affects (improves!) CI. I'm going to merge it prior to review.

[dfed]

So, while this is getting us some coverage information, this fix does not seem to be working terribly well.

Here's the run for this job on main: https://github.com/dfed/CacheAdvance/actions/runs/3229766624
This job shows "no coverage report found" on every "Upload Coverage Report" job.

However, there is a coverage job for this merge commit on main: https://app.codecov.io/gh/dfed/CacheAdvance/commit/2bfee6c0f668735368bf8337cd726928002b1194

Weirder yet, I'm not seeing coverage information for other branches that branched from this sha.

[bachand]

I'm not sure how that PR broke things, but running locally I see that test runs utilizing swift packages have a .framework suffix, and test runs utilizing a generated xcodeproj do not. Fixing this seems to have fixed codecov.

Can you help me connect how this ^ comment relates to the change we made in #53.

In that PR it seems like we're still testing via the generated Xcode project:

CacheAdvance/Scripts/build.swift

Line 135 in e32e993

"-project", "generated/CacheAdvance.xcodeproj",

[dfed]

Honestly, I have no idea how #53 broke us. And unfortunately the CI logs are no longer available that far back. I'm trying to fix forward with #68 but may have to try to reverse engineer what went wrong.

[dfed]

Note that Valet is still working, which has a similar config (see square/Valet#256). So... at least we know something that works.