[devswha]

What it does for the user

A chat message sent to an omp that is still starting now waits for herdr's omp integration to report the session wherever omp actually loads that integration from, not only from ~/.omp/agent/extensions. Before, an omp that loaded it from the project, from a file on its command line or from another agent directory got the message while it was still starting, so the message could stay typed in the half-started input box. An omp started with --no-extensions or --trusted-extension loads no installed integration, so it now gets the message at once instead of after the full 30 s wait for a report that never comes. A wait that runs out without a report now leaves one line in the server log.

Why

The startup wait (#1475, #1825) only sends early when the integration is not loaded, and it decided that by looking in the default (or --profile) agent directory. I read omp 18.8.7's bundled code to see where it really loads extensions from:

• It discovers them in <cwd>/.omp/extensions (skipped when cwd is the home directory) and in <agentDir>/extensions.
• The agent directory follows --profile, OMP_PROFILE, PI_PROFILE, PI_CONFIG_DIR and PI_CODING_AGENT_DIR. These are the same rules ompStoreLayout already encodes, so that resolution is now shared (ompAgentDirectory).
• -e/--extension/--hook files load too, even under --no-extensions, which turns discovery off.
• --trusted-extension loads only its own files and also turns discovery off.

Changes

• server/omp.ts: ompLaunch now reads the extension files and --no-extensions. ompConfigDir resolves the agent directory from the environment. The new ompLoadsIntegration answers whether the integration is loaded.
• server/core/composer.ts: the wait uses ompLoadsIntegration with the cwd herdr reports for the process. A wait that times out logs [omp] <pane>: … reported no session within 30 s …, after the replacement check, so the line never appears for a send that is refused.

Refs #1486. That issue also listed these:

• A post-wait lookup that finds no omp now has a regression test: it sends and does not cancel.
• The timeout is now logged.

How it was verified

• bun test server/core/omp-submit.test.ts server/omp.test.ts: 62 pass. New startup cases: the integration in the project's .omp/extensions, a file named by -e, a file named by --hook under --no-extensions, and PI_CODING_AGENT_DIR (Linux only, where the server can read another process's environment). Each waits for the report and then sends once. --no-extensions and --trusted-extension /opt/other.ts send at once. A timed-out wait logs exactly one line.
• With origin/main's composer.ts and omp.ts restored, 7 of the new cases fail. With the --trusted-extension change taken out, 3 cases fail.
• bun run check fast: all green on the head (workflow syntax, generated files, typecheck, build, unit tests).
• Reviews: omo-native-code-reviewer and Codex Sol 6.1 Fast xhigh. Round 1 found a MEDIUM (--trusted-extension did not disable discovery; both reviewers), a MEDIUM (the PI_CODING_AGENT_DIR case would fail on macOS, where processEnviron is null) and a LOW (the timeout line logged before the replacement check). All three are fixed in 2272ef4, and Codex's re-review of that commit is PASS.
• Known limits, left as documented (both LOW):
  • Extensions listed in a settings.json are not seen.
  • A Windows -e path with unquoted spaces is split by omp's argv and not recognized.
  • The macOS environment is not read, as before.

No workflow change.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: devswha/ovis
• Branch: fix/omp-startup-wait-paths
• File: .coderabbit.yaml
• Commit: 2272ef4
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: d36f1064-f161-401b-8dc2-ed392ac89355

Commits

Reviewing files that changed from the base of the PR and between 99547b0 and 2272ef4.

Files selected for processing: 5

• changelog.d/omp-startup-wait-extension-paths.md
• server/core/composer.ts
• server/core/omp-submit.test.ts
• server/omp.test.ts
• server/omp.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[devswha]

Merging 2272ef4: omo-native-code-reviewer and Codex both pass this head. The new location cases fail on main and pass here, and the argv model matches omp 18.8.7's own parser. The required checks are green, and CodeRabbit did not review this head. Codex found two MEDIUMs, which go to a follow-up issue with the LOW notes:

• A project integration disabled in config.yml now waits out the 30 s startup limit. Rare, and it logs one line.
• A directory or package passed with -e is not recognized, so the send goes at once, as on main.