Repository navigation
fix(composer): show the translated note for a held copy's capabilities_unknown resend - #1811
Conversation
…age's language (#1809) PendingMessages lists the codes whose row note comes from submitNote. capabilities_unknown (#1808) was missing, so a held copy sent again before the bridge's snapshot said what it supports showed the translated "Not sent:" prefix with the English reason, not the note #1808 translated.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Translated note selection and regression coverage src/components/PendingMessages.tsx, src/components/PendingMessages.test.tsx |
PendingMessages routes capabilities_unknown through submitNote. The test checks the translated note, the Send now control, and omission of the raw English refusal reason. |
Priority:
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Bug fix · Severity of issue fixed: Low
Possibly related PRs
- devswha/ovis#1808: Adds the
capabilities_unknownresult and translated note used by this change. - devswha/ovis#1805: Changes the resend-before-snapshot path that leads to the refusal handled here.
Merge Risk: 
a2a85
-
The translation fix is covered for Korean, Japanese, and Chinese with no unresolved merge-blocking risk.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly identifies the primary change: displaying the translated note for a held copy with a capabilities_unknown resend failure. Description check The description explains the cause, symptom, fix, scope, regression test, validation results, and known limitations. It uses Summary and Verification headings instead of the template's Change and Vali… Linked Issues check Issue [ #1809] requirescapabilities_unknownto usesubmitNotefor a held-copy resend and requires a regression test for translated output.PendingMessages.tsxadds the code to thesubmitNotes…Out of Scope Changes check The pull request changes only the required note-selection branch and its focused regression test. The test changes support issue [ #1809]. No unrelated source, translation, or release changes are prese…Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Full details: Description check
-
Explanation
The description explains the cause, symptom, fix, scope, regression test, validation results, and known limitations. It uses Summary and Verification headings instead of the template's Change and Validation headings, but it provides the required information.
Full details: Linked Issues check
-
Explanation
Issue [
#1809] requirescapabilities_unknownto usesubmitNotefor a held-copy resend and requires a regression test for translated output.PendingMessages.tsxadds the code to thesubmitNoteselection.PendingMessages.test.tsxrenders a held row for Korean, Japanese, and Chinese, checks the translated note, checkspending-message-send, and rejects the English refusal reason. The component keeps the row non-uncertain for this error code.
Full details: Out of Scope Changes check
-
Explanation
The pull request changes only the required note-selection branch and its focused regression test. The test changes support issue [
#1809]. No unrelated source, translation, or release changes are present in the reviewed diff.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Merge pass: review-work report. Overall: PASSED.
Manual QA
Gate review
Outside PR #1795. It shares both files. It merges cleanly onto main but conflicts with this head in All required checks are green and no review thread is open. |
Fixes #1809.
Summary
src/components/PendingMessages.tsxlists the error codes whose held-copy note comes fromsubmitNote.capabilities_unknown(from fix(composer): name a late capability snapshot, not a dropped connection, in the not-sent note #1808) was not in that list.t("Not sent: {message}")with the result's English reason. A Korean, Japanese or Chinese page showed the English sentence after its translated "Not sent:", not the note fix(composer): name a late capability snapshot, not a dropped connection, in the not-sent note #1808 translated."capabilities_unknown"to that list, as the issue prescribes. The row now shows "Not sent: this PC has not said yet what it supports. Send it again." in the page's language. Send now stays, and the row is still not marked uncertain.src/components/PendingMessages.test.tsxrenders a held row that failed withcapabilities_unknownin ko, ja and zh. It asserts that the translated note is shown, that Send now stays, and that the English reason is absent.No new i18n keys. The note is already in
src/lib/i18n/composer.{ko,ja,zh}.ts, from #1808.No changelog fragment. #1808 is not released yet (it came after 0.4.13). Before #1808 this case returned
not_transmitted, which the list already translates, so released users never saw the English reason. #1808's fragment (changelog.d/submit-snapshot-note.md) already describes the corrected note.Overlap: open PR #1795 edits line 79 of
PendingMessages.tsx, right above the changed line 80, and also edits the test file. A rebase there may need a small manual merge.Not changed (follow-up note from the gate review):
agent_blocked,read_only,submit_timeoutandpending_input_unsupportedalso have their ownsubmitNotetexts.agent_blocked.Design precedent
None applies. This shows an existing translated note in one more case. There is no new UI.
Verification
보내지 않음: this PC has not said yet what it supports; nothing was sent, not the translated note.src/components/PendingMessages.test.tsx,src/lib/compose.test.tsandsrc/conventions.test.tsgive 64 pass;bun run check fastpasses: 6331 pass, 0 fail.agentstill reachessubmitNote.