Skip to content

check fast is red on main: @legendapp/list types omit scrollAdjust, and install-herdr-core pick_runtime leaks ambient PATH #2791

Closed

Description

@szymonqzx

bun run check fast does not pass on main (b2d9e5d7). Both failures reproduce on a pristine checkout of that commit with a fresh bun install, so they are not branch-specific.

1. Typecheck: src/components/ChatTimeline.tsx(394,57)

error TS2345: Argument of type '"scrollAdjust"' is not assignable to parameter of type 'LegendListListenerType'.

Root cause is a typing gap in the dependency, not a bug in the call site: @legendapp/list@3.3.5 does emit scrollAdjust at runtime, but its bundled LegendListListenerType is a hardcoded Extract<ListenerType, ...> union that omits it.

$ grep -o 'type LegendListListenerType.*' node_modules/@legendapp/list/animated.d.ts
type LegendListListenerType = Extract<ListenerType, "activeStickyIndex" | ... | "totalSize">;
$ grep -rn '"scrollAdjust"' node_modules/@legendapp/list/*.js | head -1
node_modules/@legendapp/list/react-native.js:358:    "scrollAdjust",

ChatTimeline listens for it deliberately ("the list's adjust scrolls in its own frame callback"), so the runtime behaviour is wanted; only the type is missing.

Suggested fix, pick one:

  • extend the existing patch (patches/@legendapp%2Flist@3.3.5.patch) to add "scrollAdjust" to LegendListListenerType, or
  • cast at the call site in ChatTimeline.tsx and leave a comment naming the upstream gap.

2. Unit test: scripts/install-herdr-core.test.ts > pick_runtime

pick_runtime > picks herdr-core where there is no herdr and herdr-core answers
  expected "RUNTIME herdr-core", got "RUNTIME herdr"

23 pass / 1 fail for that file on b2d9e5d7. The fixture appears to inherit a herdr binary from the ambient PATH rather than from the test sandbox, so it will pass or fail depending on what the machine has installed (this host has ~/.local/bin/herdr-core and ~/.local/bin/hc).


Environment: Linux, bun 1.4.4, bun install from the committed bun.lock. Everything after typecheck in check fast was run by hand on the branch that hit this: bun run build succeeds, and bun run test:unit reports 11256 pass / 1 fail / 45 skip with the single failure above.

Activity

  1. added a commit that references this issue on Nov 5, 2026
    029780f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions