Repository navigation
OmO holder late window: tie it to the host, not only the boot time #2425
Description
Follow-up from the merge-pass review of #2424 (fix for #2281).
MEDIUM (reproduced in a fixture): server/omo.ts:269-271 accepts an OmO session-holder record from another host when the two hosts booted within about 2 s of each other and the holder has the same PID and cwd, with its start up to 60 s late. The pane then shows the other host's OmO transcript. This needs one OmO session store shared by two machines (for example a shared NFS home; the default store is per user, ~/.omo/agent, and a shared store is not a documented setup), plus a boot-time, PID and cwd collision, so it is rare. Fix idea: record a host identity (machine id or hostname) in the holder and require it to match before the late window applies.
LOW (reproduced): server/omo.ts:242-246,269-271: the late window requires the holder's boot time to equal this host's within a small tolerance; a boot-time reading that drifts by about 10 s (clock step, suspend/resume) rejects a valid late holder and brings back the empty chat. A ±2 s drift is still accepted.
Activity
devswha commentedon Nov 4, 2026
Closing for now: OmO's holder records carry no host identity (only pid, boot time, process start and cwd), so Ovis can't tell a record from another host apart without loosening the boot check that guards against pid reuse. A store shared across hosts isn't a supported setup. Reopen if OmO starts writing a host or boot id; Ovis can then require a match when present. Repro is in the lane notes.