Fixed the colon problem#13
Conversation
Replaced all ":" with "." for compatibility
|
Have you tested this on your systems with both local+remote mode? |
|
It's untested right now. I couldn't test it because my home server needs a fresh reinstall. Will test it tomorrow. |
|
Awesome, thanks. |
|
Note that any scripts in Remote that are updated need to go into the 'gpx-remote-latest.tar.gz' tarball as well as the bin directory. |
|
couldn't finish my test yesterday, my internet connection was very slow and the setup of my test environment took ages. Will test it today! |
|
Cool. Let me know, then I will test on my end. |
|
I have been testing the colonfix for the remote and the servers will now start and stop as the user that server is assigned to without issues. However it does make the WebGUI's FTP tab not work however the colonfix works. |
|
Ahh - yes. These game server directory structures are hardcoded here: https://github.com/devryan/GamePanelX-V3/blob/master/includes/classes/files.php#L149 So the master code will need to be updated. On my local dev setup I've already addressed most of those issues so I will get that committed out. We ought to develop on a branch for all this stuff. I think you have to pay for that on github, but I will look into it. |
|
Nice one bud. I nice to see people helping one another out thats for sure. |
|
whoops... thought i had commented here already. I couldn't test this fix on my testserver 'cause the mainboard is broken. (It's a very old desktop pc). Sorry, that I'm late in answering. @devryan You don't have to pay for branches... just for private repos. |
|
@siasur, @hacktrix2006 I have created a dev branch on GPX Master and Remote repos. Let's submit pull requests and dev/test there. https://github.com/devryan/GamePanelX-V3/tree/dev |
|
Can you guys submit your pull requests to the dev branch? I can't seem to move them. |
|
My commit was already put into the remote's master as it was the #!/bin/bash bit so only the commit from siasur is needed |
|
Cool. I am usually in #gamepanelx on irc.freenode.net fyi. |
|
Roger that have to fix router first like though LOL using mobile atm. |
|
will move it... |
Replaced all ":" with "." for compatibility