Skip to content

Fixed the colon problem#13

Merged
devryan merged 2 commits into
devryan:masterfrom
siasur:colonfix
Jan 2, 2016
Merged

Fixed the colon problem#13
devryan merged 2 commits into
devryan:masterfrom
siasur:colonfix

Conversation

@siasur
Copy link
Copy Markdown
Contributor

@siasur siasur commented Oct 20, 2015

Replaced all ":" with "." for compatibility

Replaced all ":" with "." for compatibility
@devryan
Copy link
Copy Markdown
Owner

devryan commented Oct 20, 2015

Have you tested this on your systems with both local+remote mode?

@siasur
Copy link
Copy Markdown
Contributor Author

siasur commented Oct 20, 2015

It's untested right now. I couldn't test it because my home server needs a fresh reinstall. Will test it tomorrow.

@devryan
Copy link
Copy Markdown
Owner

devryan commented Oct 20, 2015

Awesome, thanks.

@devryan devryan self-assigned this Oct 20, 2015
@devryan
Copy link
Copy Markdown
Owner

devryan commented Oct 20, 2015

Note that any scripts in Remote that are updated need to go into the 'gpx-remote-latest.tar.gz' tarball as well as the bin directory.

@siasur
Copy link
Copy Markdown
Contributor Author

siasur commented Oct 22, 2015

couldn't finish my test yesterday, my internet connection was very slow and the setup of my test environment took ages.

Will test it today!

@devryan
Copy link
Copy Markdown
Owner

devryan commented Oct 26, 2015

Cool. Let me know, then I will test on my end.

@solidus1983
Copy link
Copy Markdown
Contributor

I have been testing the colonfix for the remote and the servers will now start and stop as the user that server is assigned to without issues. However it does make the WebGUI's FTP tab not work however the colonfix works.

@devryan
Copy link
Copy Markdown
Owner

devryan commented Oct 26, 2015

Ahh - yes. These game server directory structures are hardcoded here:

https://github.com/devryan/GamePanelX-V3/blob/master/includes/classes/files.php#L149
https://github.com/devryan/GamePanelX-V3/blob/master/includes/classes/network.php#L300

So the master code will need to be updated. On my local dev setup I've already addressed most of those issues so I will get that committed out.

We ought to develop on a branch for all this stuff. I think you have to pay for that on github, but I will look into it.

@solidus1983
Copy link
Copy Markdown
Contributor

Nice one bud. I nice to see people helping one another out thats for sure.

@siasur
Copy link
Copy Markdown
Contributor Author

siasur commented Oct 26, 2015

whoops... thought i had commented here already. I couldn't test this fix on my testserver 'cause the mainboard is broken. (It's a very old desktop pc).

Sorry, that I'm late in answering.

@devryan You don't have to pay for branches... just for private repos.
@hacktrix2006 Thanks for your testing :)

@devryan
Copy link
Copy Markdown
Owner

devryan commented Oct 28, 2015

@siasur, @hacktrix2006 I have created a dev branch on GPX Master and Remote repos. Let's submit pull requests and dev/test there.

https://github.com/devryan/GamePanelX-V3/tree/dev
https://github.com/devryan/GamePanelX-V3-Remote/tree/dev

@devryan
Copy link
Copy Markdown
Owner

devryan commented Oct 28, 2015

Can you guys submit your pull requests to the dev branch? I can't seem to move them.

@solidus1983
Copy link
Copy Markdown
Contributor

My commit was already put into the remote's master as it was the #!/bin/bash bit so only the commit from siasur is needed

@devryan
Copy link
Copy Markdown
Owner

devryan commented Oct 28, 2015

Cool. I am usually in #gamepanelx on irc.freenode.net fyi.

@solidus1983
Copy link
Copy Markdown
Contributor

Roger that have to fix router first like though LOL using mobile atm.

@siasur
Copy link
Copy Markdown
Contributor Author

siasur commented Oct 28, 2015

will move it...
I'm currently a little bit busy, so sorry for my late answers every time.

@siasur siasur mentioned this pull request Oct 28, 2015
@devryan devryan merged commit a2992ea into devryan:master Jan 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants