Skip to content

Changed the colon in the path to fix a srcds_run related bug#11

Closed
siasur wants to merge 19 commits into
devryan:masterfrom
siasur:patch-1
Closed

Changed the colon in the path to fix a srcds_run related bug#11
siasur wants to merge 19 commits into
devryan:masterfrom
siasur:patch-1

Conversation

@siasur
Copy link
Copy Markdown
Contributor

@siasur siasur commented Oct 19, 2015

I continued the "fix" from ExGamers. It's completed now.

@devryan
Copy link
Copy Markdown
Owner

devryan commented Oct 20, 2015

Wow. Thanks for the updates. I had this about half-way done, though I had used a "." (like netstat does) instead of a - or a _ for the ip/port combo. I'd say we should make it a dot instead of hyphen, in case any other games hate those characters.

@devryan
Copy link
Copy Markdown
Owner

devryan commented Oct 20, 2015

Also, why are you changing the ip:port to service$tplid? If $tplid is the template ID, then you effectively couldn't have multiple servers of the same template under a user account. This simply needs to be fixed to $ip.$port, just like netstat shows ip/port combinations.

@siasur
Copy link
Copy Markdown
Contributor Author

siasur commented Oct 20, 2015

Also, why are you changing the ip:port to service$tplid?

I was not the one who made this change. @ExGamers did it initially, but then changed it to $ip-$port. But he changed it in just one file. That's why I took his "fix" and completed it.

Give me some time and I'll create a new Pullrequest with a "." instead of a "-"

@devryan
Copy link
Copy Markdown
Owner

devryan commented Oct 20, 2015

Ok awesome. Thanks!

On Tue, Oct 20, 2015 at 11:02 AM, Mischa Behrend notifications@github.com
wrote:

Also, why are you changing the ip:port to service$tplid?

I was not the one who made this change. @ExGamers
https://github.com/ExGamers did it initially, but then changed it to
$ip-$port. But he changed it in just one file. That's why I took his
"fix" and completed it.

Give me some time and I'll create a new Pullrequest with a "." instead of
a "-"


Reply to this email directly or view it on GitHub
#11 (comment)
.

@siasur
Copy link
Copy Markdown
Contributor Author

siasur commented Oct 20, 2015

You can close this now :)
see #13

@siasur siasur closed this Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants