Skip to content

Performance improvement for Mocking many large classes #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzu merged 1 commit into from
Feb 18, 2025
+11 −3
Merged

Performance improvement for Mocking many large classes #1530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/Moq/Interception/CastleProxyFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
// All rights reserved. Licensed under the BSD 3-Clause License; see License.txt.

using System;
using System.Collections.Concurrent;
using System.Diagnostics;
using System.Reflection;

#if FEATURE_DEFAULT_INTERFACE_IMPLEMENTATIONS
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Linq;
using System.Reflection.Emit;
Expand All @@ -28,11 +28,19 @@ sealed class CastleProxyFactory : ProxyFactory
{
ProxyGenerationOptions generationOptions;
ProxyGenerator generator;
ConcurrentDictionary<string, ProxyGenerator> classGenerators;

public CastleProxyFactory()
{
this.generationOptions = new ProxyGenerationOptions { Hook = new IncludeObjectMethodsHook(), BaseTypeForInterfaceProxy = typeof(InterfaceProxy) };
this.generator = new ProxyGenerator();
this.classGenerators = new ConcurrentDictionary<string, ProxyGenerator>();
}

ProxyGenerator GetClassGenerator(Type mockType)
{
var ns = mockType.Namespace ?? string.Empty;
return classGenerators.GetOrAdd(ns, _ => new ProxyGenerator());
}

/// <inheritdoc />
Expand All @@ -53,13 +61,13 @@ public override object CreateProxy(Type mockType, Moq.IInterceptor interceptor,
{
var options = new ProxyGenerationOptions();
options.AddDelegateTypeMixin(mockType);
var container = generator.CreateClassProxy(typeof(object), additionalInterfaces, options, new Interceptor(interceptor));
var container = GetClassGenerator(mockType).CreateClassProxy(typeof(object), additionalInterfaces, options, new Interceptor(interceptor));
return Delegate.CreateDelegate(mockType, container, container.GetType().GetMethod("Invoke"));
}

try
{
return generator.CreateClassProxy(mockType, additionalInterfaces, this.generationOptions, arguments, new Interceptor(interceptor));
return GetClassGenerator(mockType).CreateClassProxy(mockType, additionalInterfaces, this.generationOptions, arguments, new Interceptor(interceptor));
}
catch (TypeLoadException e)
{
Expand Down