Performance improvement for Mocking many large classes - #1530
Merged
Merged
Conversation
…ace for performance improvement
|
|
crinksdr
changed the title
kzu
enabled auto-merge (rebase)
February 18, 2025 05:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mocking many large classes across multiple assemblies causes a huge performance slow down as more classes get mocked. The AbstractTypeEmitter::CreateType in Castle.Core gets slower for each method on each class over time. Seeing up to 10 times slower as more and more classes get mocked.
By having a ProxyGenerator for each namespace it means less data in each ProxyGenerator and faster loading.
In my test case the large classes each had ~400 methods and there were 100s of these classes all being mocked across all the tests. Test time went from 6 min down to 30 seconds with this change.