feat: show app version in Privacy tab (RFC 0016) - #18
Closed
willwade wants to merge 1 commit into
Closed
Conversation
One quiet 'Dasher <version>' line at the bottom of Settings -> Privacy, reading AnalyticsService.appVersion (BuildConfig.VERSION_NAME) - the same value analytics already reports, so UI and telemetry cannot disagree. appVersion() collapses into a public val as the single source. Interim home pending the About section (RFC 0006). Fixes #17. Signed-off-by: will wade <willwade@gmail.com>
willwade
added a commit
that referenced
this pull request
Aug 22, 2026
Supersedes #16 (squash-merged into its stacked base by mistake) and #18 (auto-closed by the same). One PR, two commits, net diff identical to those two combined. ## 1. Real text metrics for label layout ([DasherCore #56](dasher-project/DasherCore#56) / v0.2.4) The engine laid out node labels using a `codepoints × fontSize/2` estimate whose error compounds down the label shunting chain — deep-zoom text degenerates into jumbles (user-visible on Windows; same engine path here). Wires `dasher_set_text_size_callback` end to end: - JNI `textSizeCallback` marshals into `NativeBridge.onTextSize` (same cached-methodID pattern as the other callbacks); new `nativeSetTextSizeCallback` / `nativeTextMetricsChanged`. - `DasherCanvasView.measureGlyphText` measures with the same Paint + size transform (`×2.5, floor 8`) the canvas draws opcode-5 text with, so layout and drawing agree; font changes invalidate cached metrics. - MainActivity **and** the IME install their own measurement (static listeners — the IME must not inherit the Activity's canvas). - Submodule → DasherCore v0.2.4. ## 2. App version line in Settings → Privacy ([RFC 0016](https://github.com/dasher-project/governance/blob/main/rfcs/0016-version-in-settings.md), fixes #17) Quiet `Dasher <version>` line reading `AnalyticsService.appVersion` (`BuildConfig.VERSION_NAME`) — same value analytics reports; UI and telemetry cannot disagree. ## Testing `:app:compileDebugKotlin`, `:app:testDebugUnitTest`, `:app:assembleDebug` (native vs v0.2.4, arm64-v8a + x86_64) green locally; CI green on the superseded PRs (same code). DCO signed (both commits carried it). --------- Signed-off-by: will wade <willwade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements governance RFC 0016 (accepted). Fixes #17.
Stacked on #16 ← #14 — merge in that order.
One quiet
Dasher <version>line at the bottom of Settings → Privacy, readingAnalyticsService.appVersion(BuildConfig.VERSION_NAME) — the same value analytics already reports, so UI and telemetry cannot disagree. The privateappVersion()collapses into a publicvalas the single source (callers updated). Interim home pending RFC 0006's About section.Sibling issues: Dasher-Windows #29, Dasher-Apple #35, Dasher-GTK #54 (implementing in Dasher-GTK #55), dasher-web #151.
:app:compileDebugKotlin+:app:testDebugUnitTestgreen.Dasher 0.1.0(currentversionName) under the Reset anonymous ID button.DCO signed.