Skip to content

Copy Path, Paste Path (Bookmarking?)#34

Merged
culmat merged 1 commit into
culmat:masterfrom
paulvi:patch-8
Aug 13, 2014
Merged

Copy Path, Paste Path (Bookmarking?)#34
culmat merged 1 commit into
culmat:masterfrom
paulvi:patch-8

Conversation

@paulvi
Copy link
Copy Markdown
Contributor

@paulvi paulvi commented Aug 13, 2014

rename to Copy Path, Paste Path as icons may be confused with file operations

rename to Copy Path, Paste Path as icons may be confused with file operations
@paulvi
Copy link
Copy Markdown
Contributor Author

paulvi commented Aug 13, 2014

Eureka!

At first I did not like key binding with Alt.

But now if I hold Alt, and press up, up when within deep directory,
and can press C to bookmark current dir, then up, up... and then press V to return to bookmarked directory.

This is like new feature in itself.
Propose to rename to

  • Copy Path / Bookmark
  • Paste Path / Go back to Bookmark

@paulvi paulvi changed the title #32 Copy Path, Paste Path #32 Copy Path, Paste Path (Bookmarking?) Aug 13, 2014
@paulvi paulvi changed the title #32 Copy Path, Paste Path (Bookmarking?) Copy Path, Paste Path (Bookmarking?) Aug 13, 2014
paulvi pushed a commit to paulvi/eExplorer that referenced this pull request Aug 13, 2014
culmat added a commit that referenced this pull request Aug 13, 2014
rename to copy path / paste path
@culmat culmat merged commit 9cb60fa into culmat:master Aug 13, 2014
culmat added a commit that referenced this pull request Aug 13, 2014
@paulvi paulvi deleted the patch-8 branch August 13, 2014 10:39
@paulvi
Copy link
Copy Markdown
Contributor Author

paulvi commented Aug 13, 2014

I looked at code, and noticed that there are String constants in respective Action Java class.
Can that be an issue?

@culmat
Copy link
Copy Markdown
Owner

culmat commented Aug 13, 2014

I thought it would. Must admit I merged in the browser without testing.
Fixing it now.

culmat added a commit that referenced this pull request Aug 13, 2014
@paulvi
Copy link
Copy Markdown
Contributor Author

paulvi commented Aug 14, 2014

Thank you.

What a contrast to msysgit style of communicating

msysgit/git#223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants