Initial support for Cryptomator Hub #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including: - Dependency updates - Build error fixes
- resolved some todos related to error throwing - removed commented code
tobihagemann
force-pushed
the
feature/hub-poc
branch
from
004a2d9 to
16c4017
Compare
tobihagemann
force-pushed
the
feature/hub-poc
branch
from
af8e138 to
eb74a14
Compare
# Conflicts: # Cryptomator.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # CryptomatorCommon/Package.swift
Active Hub subscription unlocks full version for corresponding vault
|
|
- moved business logic out of the coordinators - show ProgressHUD instead of custom loading screen - removed unnecessary login screen - show navigation bar title for all hub authentication screens
Improve Cryptomator Hub Authentication Flow
tobihagemann
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Cryptomator Hub.
Note that most of the newly added screens are not really beautiful as they will improve at a later stage in the future.
Also you need the full version of Cryptomator in order to have write access to the Hub vault.
We are currently depending on a separate branch of cloud-access-swift as we need to use a fork of JOSESwift.
Furthermore, the min. iOS version was bumped from 13 to 14 as we need some API from CryptoKit. I guess as every iOS 13 device can be updated to iOS 14 this should have no drawbacks.