Active Hub subscription unlocks full version for corresponding vault #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always unlock all the read / write permissions for Cryptomator Hub vaults as long as there is a active subscription for this vault.
This unlocks the following cases:
Small implementation details:
We check for the subscription state on each unlock.
We expect that we always get a header field
hub-subscription-stateif this is not the case we fail the entire unlock flow.The latest hub subscription state is stored in the database so that it can easily be retrieved later.
Note:
Since I changed the table scheme a bit it's needed to remove all previously configured hub vaults from the iOS app as I did not want to add a migration just so that we can test it easier 🙈