Repository navigation
Add publishing, newsletter, authorization and Chrome regression coverage - #92
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postcard had little coverage of authoring, subscriber permissions, or actual newsletter delivery. Add 42 Rails regressions and four real Chrome editor tests, with both SOLO and MULTIUSER runs in CI.
The tests exercise draft/save/review/publish/edit/archive flows, guest and cross-account requests, sitemap and discovery visibility, rendered mail and signed tracking redirects, unsubscribe isolation and queued consent changes, CSV normalization, repeat imports, and import/export authorization. Chrome loads the production Stimulus controller and checks literal titles, autosave, Enter handling, reconnect cleanup, and cancelled pending saves.
Fix the defects exposed by these tests: published draft URLs looped, invalid direct publication raised, empty public archives crashed, sitemap entries contained multiple locations, unauthorized import approval raised instead of returning 403, queued imports ignored revoked approval, and the title editor interpreted HTML and leaked listeners/pending saves.
Add
bin/testto initialize coverage and block unexpected HTTP before Rails boots. Publish separate HTML/JSON line and branch coverage reports per application mode. CI uses locked npm dependencies and Node 24 for Chrome tests. Document focused runs and test conventions indocs/testing.md.Validation:
8edfbdb7bfbd304c3cb7534ab64a6d747dd941e9.This branch starts from main and remains independent of the other audit PRs. Durable newsletter retry/idempotency (#81), live provider behavior, and payment integration are still separate work.
Fixes #33. Fixes #34.