Repository navigation
Upgrade supported runtimes and strengthen security and image checks - #78
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35ef908f05
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postcard's Ruby 3.2, Rails 7.2, Node 18 and CI PostgreSQL 10 releases are outside their upstream support windows. This updates the application to Ruby 3.4.10, Rails 8.1.3.1, Node 24.20.0 and PostgreSQL 16 CI, while retaining the existing Rails defaults and billing schema.
Validation: 100 Rails tests / 679 assertions pass in each application mode, with no failures, errors, or skips, using the isolated local test database and coverage-aware bin/test entry point. All six real Chrome tests pass locally, including the editor lifecycle, Trix sanitization, and image checks. Zeitwerk eager loading and asset compilation pass; Brakeman reports zero unignored warnings (seven existing suppressions retained); the refreshed dependency audit passes with the two documented Pay exceptions. Synced with main through eabfc6d, retaining the merged #92 regressions, #94 Ghost retirement and serialized-job compatibility tests, and #93 Solid Cache fix. All three current-head checks pass on 7b53e9c: SOLO, MULTIUSER, and the production Docker smoke job, including default startup, PID, health, cold/warm homepage, persisted cache, and browser execution. Both mode-specific coverage artifacts are uploaded: https://github.com/contraptionco/postcard/actions/runs/33989181954.
The Pay major-version migration is tracked in #79 and remains separate because upstream requires subscription-column backfills, STI conversion and association changes. No production services or payment data were changed.
Upstream references: Ruby support, Rails support, Node release schedule, PostgreSQL support, Pay upgrade requirements, Pay return-link fix.
Trix references: upstream patched release, paste sanitization advisory.