Skip to content

The required check's checks job may run 25 minutes, not 15 - #307

Merged
don-petry merged 2 commits into
mainfrom
ci/checks-timeout-25
Oct 22, 2026
Merged

don-petry merged 2 commits into
mainfrom
ci/checks-timeout-25

Conversation

@don-petry

@don-petry don-petry commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

The Maintainer raised the checks job's timeout from 15 to 25 minutes.

Why

On 2026-10-21, make verify on the runner (its simulators on 300 seeds) took 11 to 14.5 minutes in the runs that finished. Six runs were cancelled at 15:00 with the tests still running:

The mutation shards run the same suite on 40 seeds and pass, so the cancelled runs are slow, not broken.

What changes

  • .github/workflows/verify.yml: checks gets timeout-minutes: 25. The head comment gains one line with the measured times.
  • examples/workflows/verify.yml and the first yaml block of docs/standards/workflows.md change the same way. They hold the workflow word for word, and tools/check_workflows.py and tools/check_context.py compare them.
  • tests/test_tools.py: the tests that removed or changed timeout-minutes: 15 to make a drift or a fault now use 25. Each still fails loudly if its replacement stops matching.

Nothing else changes: no permission, trigger, secret, pin or step.

Gates

  • PATH=/usr/bin:/bin SIM_SEEDS=40 make verify: 973 tests, OK.
  • Claude review with a security pass: no blockers or majors. Its two wording nits are fixed in 0c5bf91.
  • Argon (AGY, gemini-4-argon-high): no findings.
  • Muse: not run (Maintainer, 2026-10-20: Kernel/hook only).
  • No decision record, by the Maintainer's instruction.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

don-petry and others added 2 commits October 21, 2026 21:04
…runs whose tests were still running

On 2026-10-21 `make verify` on the runner, its simulators on 300 seeds,
took 11 to 14.5 minutes, and six runs in three pull requests were
cancelled at the 15-minute timeout with the tests still running. The
Maintainer raised it to 25. The workflow, its example and the standard
change together, with the measured times in the head comment, and the
tests that broke the old value to show drift now break the new one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…at finished, and which timeout to raise before

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner October 22, 2026 02:11
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-22T02:11:57.915749Z
We couldn’t complete this review. Comment @codex review to try again.
0c5bf91 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: combsmith/software-factory/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 33c4e797-bf5e-4e40-a256-ad612b82b89c
📥 Commits

Reviewing files that changed from the base of the PR and between bb4694f and 0c5bf91.

📒 Files selected for processing: 4
  • .github/workflows/verify.yml
  • docs/standards/workflows.md
  • examples/workflows/verify.yml
  • tests/test_tools.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 9e927b4 Oct 22, 2026
19 checks passed
@don-petry
don-petry deleted the ci/checks-timeout-25 branch October 22, 2026 02:43
don-petry added a commit that referenced this pull request Oct 22, 2026
Main now holds the 25-minute checks timeout (#307).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
don-petry added a commit that referenced this pull request Oct 22, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
don-petry added a commit that referenced this pull request Oct 22, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
don-petry added a commit that referenced this pull request Oct 22, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
don-petry added a commit that referenced this pull request Oct 22, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant