[Fleet Monitor] petry-projects/markets — .github/workflows/pr-review.yml #276

Activity

1. don-petry

   added

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   fleet-trackerTracked by the Actions Fleet MonitorTracked by the Actions Fleet Monitor

   health-checkAutomated health check resultAutomated health check result

   on Jun 18, 2026
2. don-petry commented on Jun 18, 2026

   

   don-petry

   on Jun 18, 2026

   ContributorAuthor

   More actions

   Dev-Lead Implementation Plan

   Issue: #276 — [Fleet Monitor] petry-projects/markets — .github/workflows/pr-review.yml

   Root-cause analysis

   I inspected the last 15 runs of pr-review.yml:

   • All failure runs (e.g. 27731937315, 27551012935) are pull_request events from the already-open PR feat: implement issue #252 — [Fleet Monitor] petry-projects/markets — pr-review.yml #261 (the prior fix attempt for the duplicate issue [Fleet Monitor] petry-projects/markets — pr-review.yml #252). They fail at the reusable's "Verify auth scopes" step because PR feat: implement issue #252 — [Fleet Monitor] petry-projects/markets — pr-review.yml #261 changed agent_ref: pr-review/stable → agent_ref: main. main's actual pr-review.yml succeeds on every check_suite run — the workflow itself is healthy.
   • All cancelled runs are check_suite completions firing near-simultaneously for the same PR head (redundant overlapping runs).

   Scope

   Make main's caller robust by adopting PR #261's good ideas (dedup overlapping runs, skip no-PR check_suite events) without its breaking change — i.e. keep agent_ref: pr-review/stable. This reduces the cancellations/contention and supersedes the broken PR #261 with a correct config.

   Implementation Checklist

   • .github/workflows/pr-review.yml: add a per-PR concurrency group (falls back to github.run_id for batch/dispatch/no-PR runs so they are never cancelled).
   • .github/workflows/pr-review.yml: add a job-level if: guard to skip check_suite completions with no associated PR.
   • Keep agent_ref: pr-review/stable and the uses: ...@pr-review/stable pin unchanged (do NOT repeat feat: implement issue #252 — [Fleet Monitor] petry-projects/markets — pr-review.yml #261's agent_ref: main mistake).
   • Leave trigger event types and the permissions: block unchanged (thin-caller stub rules).

   Tests to Write

   • No executable test framework exists for workflow YAML in this repo (CI ecosystem-detects Go/Node, neither present; .dev-lead/.github tests cover shell scripts only). Per the Phase 2 documentation/config exception, verification is via YAML parse + actionlint (if available) + the repo lint script. This exception will be noted in the Phase 6 report.

   Test Command

   bash ".dev-lead/scripts/dev-lead-lint.sh" (plus YAML parse + actionlint on the workflow)
3. don-petry commented on Jun 18, 2026

   

   don-petry

   on Jun 18, 2026

   ContributorAuthor

   More actions

   Dev-Lead: Implementation Complete

   Root cause (confirmed from run history)

   • Every failure run in the monitored window was a pull_request event from the open PR feat: implement issue #252 — [Fleet Monitor] petry-projects/markets — pr-review.yml #261 (the prior fix attempt for the duplicate issue [Fleet Monitor] petry-projects/markets — pr-review.yml #252). Those runs fail at the reusable's "Verify auth scopes" step because feat: implement issue #252 — [Fleet Monitor] petry-projects/markets — pr-review.yml #261 changed agent_ref: pr-review/stable → agent_ref: main. main's pr-review.yml succeeds on every check_suite run — the workflow itself is healthy.
   • The cancelled runs are overlapping check_suite completions for the same PR head spawning concurrent duplicate reviews.

   Plan Execution

   • Added a per-PR concurrency group (falls back to github.run_id for batch/dispatch/no-PR runs so they are never cancelled).
   • Added a job-level if: guard to skip check_suite completions with no associated PR.
   • Kept agent_ref: pr-review/stable and the @pr-review/stable pin unchanged — deliberately NOT repeating feat: implement issue #252 — [Fleet Monitor] petry-projects/markets — pr-review.yml #261's agent_ref: main change that causes the failures.
   • Left trigger event types and the permissions: block unchanged (thin-caller stub rules).

   Test Results

   No executable test framework exists for workflow YAML in this repo (CI ecosystem-detects Go/Node — neither is present; .dev-lead/.github tests cover shell scripts only). Per the Phase 2 config/documentation exception, verification was done via:

   $ python3 -c "import yaml; yaml.safe_load(open('.github/workflows/pr-review.yml'))"
   OK: YAML parses
   
   $ actionlint .github/workflows/pr-review.yml
   OK: actionlint clean   # validates expression contexts (inputs, github.event.*, github.run_id)
   
   $ bash .dev-lead/scripts/dev-lead-lint.sh
     [lint] shellcheck: no .sh files found — skipping
     [lint] all checks passed
   

   Files Changed

   • .github/workflows/pr-review.yml: added per-PR concurrency dedup + check_suite null-PR job guard; agent_ref and reusable pin unchanged.

   diff --git a/.github/workflows/pr-review.yml b/.github/workflows/pr-review.yml
   index 0c1377c..8f07c5a 100644
   --- a/.github/workflows/pr-review.yml
   +++ b/.github/workflows/pr-review.yml
   @@ -43,8 +43,30 @@ permissions:
      pull-requests: write
      checks: read
    
   +# Collapse redundant overlapping runs for the same PR. The high-frequency
   +# triggers (synchronize + the resulting check_suite completions) fire several
   +# times for one PR head; without this they spawn concurrent duplicate reviews
   +# (the source of the cancelled runs). Group per PR when one is identifiable;
   +# fall back to a unique run id for batch/dispatch/no-PR runs so those are never
   +# cancelled against each other.
   +concurrency:
   +  group: >-
   +    pr-review-${{
   +      github.event.pull_request.number
   +      || github.event.check_suite.pull_requests[0].number
   +      || inputs.pr_url
   +      || github.event.client_payload.pr_url
   +      || github.run_id
   +    }}
   +  cancel-in-progress: true
   +
    jobs:
      review:
   +    # Skip check_suite completions with no associated PR (e.g. pushes to main):
   +    # there is nothing to review, so the run would be pure waste.
   +    if: >-
   +      github.event_name != 'check_suite'
   +      || github.event.check_suite.pull_requests[0] != null
        uses: petry-projects/.github-private/.github/workflows/pr-review.yml@pr-review/stable
        with:
          agent_ref: pr-review/stable

   Notes

   • This corrects the recurring warning at the source: the failures stem from PR feat: implement issue #252 — [Fleet Monitor] petry-projects/markets — pr-review.yml #261's broken agent_ref: main. Once this lands, PR feat: implement issue #252 — [Fleet Monitor] petry-projects/markets — pr-review.yml #261 should be closed/superseded — recommend opening a follow-up to close feat: implement issue #252 — [Fleet Monitor] petry-projects/markets — pr-review.yml #261 and the duplicate issue [Fleet Monitor] petry-projects/markets — pr-review.yml #252.
   • cancel-in-progress: true only cancels runs within the same per-PR group; different PRs and batch/dispatch runs are isolated, so no legitimate review is cancelled by an unrelated trigger.
4. don-petry

   closed this as completedin #277on Jun 20, 2026
5. don-petry

   added a commit that references this issue on Jun 20, 2026

   feat: implement issue #276 — [Fleet Monitor] petry-projects/markets —…

   ...

   ef621ff