[Fleet Monitor] petry-projects/markets — pr-review.yml #252

Activity

1. don-petry

   added

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   fleet-trackerTracked by the Actions Fleet MonitorTracked by the Actions Fleet Monitor

   health-checkAutomated health check resultAutomated health check result

   and removed

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   on Jun 4, 2026
2. don-petry commented on Jun 9, 2026

   

   don-petry

   on Jun 9, 2026

   ContributorAuthor

   More actions

   Dev-Lead Implementation Plan

   Issue: #252 — [Fleet Monitor] petry-projects/markets — pr-review.yml

   Root Cause

   markets/.github/workflows/pr-review.yml has permissions: {} at the workflow level with no job-level permissions override. It calls pr-review-reusable.yml@commit, which in turn calls pr-review.yml@main. GitHub Actions validates at startup that the calling job's permissions are a superset of what the reusable workflow declares (contents: read, pull-requests: write, checks: read). Since the caller grants no permissions, GitHub raises a startup_failure before any job runs — explaining the 0s p50/p95 duration and 100% failure rate.

   Additionally, pr-review.yml@main in .github-private was recently refactored to be reusable-only (#497/#506), and a new pr-review-trigger.yml template was introduced as the canonical thin-caller pattern. The markets workflow needs to be updated to follow this pattern.

   Scope

   Update .github/workflows/pr-review.yml to follow the new pr-review-trigger.yml pattern: call pr-review.yml@pr-review/stable directly (bypassing the pr-review-reusable.yml indirection), add proper permissions, update triggers, and forward inputs including agent_ref.

   Implementation Checklist

   • .github/workflows/pr-review.yml: Update to follow pr-review-trigger.yml pattern — call pr-review.yml directly at pr-review/stable SHA, add permissions, update triggers, forward inputs

   Tests to Write

   TDD Exception: This is a CI configuration fix with no application code to unit-test. GitHub Actions workflows cannot be unit-tested locally. The observable behavior being fixed is the startup_failure conclusion — the "test" is the workflow's next run completing without startup_failure. Pre-flight validation: YAML lint via python3 -c "import yaml; yaml.safe_load(open('.github/workflows/pr-review.yml'))".

   • YAML syntax validation of updated pr-review.yml
   • Verify the referenced reusable workflow exists at the pinned SHA

   Test Command

   python3 -c "import yaml; yaml.safe_load(open('.github/workflows/pr-review.yml'))" && echo OK
3. don-petry commented on Jun 9, 2026

   

   don-petry

   on Jun 9, 2026

   ContributorAuthor

   More actions

   Dev-Lead: Implementation Complete

   Plan Execution

   • Identified root cause: permissions: {} at workflow level with no job-level override caused GitHub to fail startup_failure at parse time — the calling job had no permissions but the reusable pr-review.yml declares contents: read, pull-requests: write, checks: read
   • Updated .github/workflows/pr-review.yml to follow the new pr-review-trigger.yml pattern from .github-private
   • Removed pr-review-reusable.yml indirection — now calls pr-review.yml directly
   • Pinned to pr-review/stable SHA (1bd8975a9c83bca376082f0b507c89b3743d5e3f)
   • Added proper permissions block mirroring the reusable's own declaration
   • Updated triggers and forwarded inputs including agent_ref
   • YAML syntax validation passed
   • Dev-lead lint passed

   Test Results (TDD Exception noted in plan)

   YAML syntax OK
   [lint] shellcheck: no .sh files found — skipping
   [lint] all checks passed
   

   Verified the pinned SHA exists and accepts agent_ref, pr_url, dry_run, force_review inputs.

   Files Changed

   • .github/workflows/pr-review.yml: Fixed startup_failure by adding permissions, removing pr-review-reusable.yml indirection, calling pr-review.yml@pr-review/stable directly, updating triggers to match new pr-review-trigger.yml pattern, forwarding inputs

   Notes

   • issue_comment and pull_request_review_comment triggers were intentionally removed — those are already handled by the separate pr-review-mention.yml workflow, which dispatches repository_dispatch: pr-review-mention events that this workflow now handles
   • The old workflow_dispatch: pr_numbers input was replaced with pr_url, dry_run, force_review to match the new reusable's interface
   • Concurrency group updated to be PR-URL-based (matching the reusable) rather than PR-number-based
4. don-petry

   added a commit that references this issue on Jun 10, 2026

   feat: implement issue #252 — [Fleet Monitor] petry-projects/markets —…

   ...

   bc0e068
5. don-petry commented on Jul 15, 2026

   

   don-petry

   on Jul 15, 2026

   ContributorAuthor

   More actions

   ✅ Auto-resolved by Fleet Monitor. This workflow's failure rate has been below the 10% threshold (or the workflow was removed) since 2026-06-10 (35 days) — the monitor stopped flagging it. Closing. It will reopen automatically if the workflow crosses the threshold again.
6. don-petry

   closed this as completedon Jul 15, 2026