Skip to content

fix(seed): mirror repo-template#255 BOOTSTRAP.md/AGENTS.md into seed-repo-template.sh heredocs - #2374

Merged
don-petry merged 1 commit into
mainfrom
chore/mirror-repo-template-255
Oct 20, 2026
Merged

don-petry merged 1 commit into
mainfrom
chore/mirror-repo-template-255

Conversation

@don-petry

@don-petry don-petry commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

combsmith/repo-template#255 (merged to main at e648a2eb) fixed the seven runbook defects that review bots raised on #2370 and that were deferred to #2047. scripts/seed-repo-template.sh still emits the previous text, so the next seed run against combsmith/repo-template would propose reverting those fixes (would UPDATE AGENTS.md: 56 → 58 lines, would UPDATE BOOTSTRAP.md: 368 → 436 lines on a pre-change dry run).

This PR re-mirrors the two changed files byte-for-byte:

File Change
scripts/seed-repo-template.sh BOOTSTRAP.md and AGENTS.md heredoc bodies regenerated from repo-template main@e648a2eb. README.md heredoc untouched (that file did not change; blob e1a5424d on both sides).
tests/fixtures/seed-repo-template/repo-template-BOOTSTRAP.md, …-AGENTS.md Refreshed, trailing newline stripped (the seeder's $() capture form).
tests/test_seed_repo_template.bats REPO_TEMPLATE_BOOTSTRAP_BLOB → bcea59b3…, REPO_TEMPLATE_AGENTS_BLOB → 1c5e6cb3…; REPO_TEMPLATE_README_BLOB unchanged; commit reference 68eb6a18 (#252) → e648a2eb (#255) in the fixture comment and the two blob-identity test names.

Refs #2047 (closes the "mirror upstream fixes" half; the repo-template half landed in combsmith/repo-template#255).

Risk

Low. Content-only change inside <<'EOF' heredocs (no expansion; neither file contains a bare EOF line) and test pins. Seeder control flow is untouched. If the pins were wrong, tests/test_seed_repo_template.bats would fail rather than the seeder misbehaving.

Test plan

  • PATH=/opt/homebrew/bin:$PATH bats tests/test_seed_repo_template.bats → 100/101 pass. The one failure is test 60 (sed -i -e … on BSD sed: sed: -e: No such file or directory), a pre-existing macOS-only incompatibility on a line this PR does not touch; CI runs GNU sed.
  • Blob-identity tests for BOOTSTRAP.md and AGENTS.md pass against the new pins (fixture hash and --emit-baseline output both equal the pinned blob).
  • DRY_RUN=true bash scripts/seed-repo-template.sh --repo combsmith/repo-template after the upstream merge: would SKIP AGENTS.md, would SKIP README.md, would SKIP BOOTSTRAP.md, [seed] PASS (dry-run).
  • CI green.

Rollback

git revert of the single commit restores the #252-era heredocs and pins. No external state; the seeder only writes when run.

Monitoring

Next scheduled or manual seed of combsmith/repo-template should report SKIP for README.md, BOOTSTRAP.md, AGENTS.md. A seed PR touching any of those three means repo-template changed again upstream and needs another mirror.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

…repo-template.sh heredocs

combsmith/repo-template#255 (main e648a2eb) fixed the runbook defects that
review bots raised on #2370 and that were deferred to #2047: sonar example
without trailing comments, STACK-derived instruction-file language list,
step-8 deletion set matching the STACK=none exception, placeholder grep that
fails loudly on a missing file, fullstack-without-pip note, and the AGENTS.md
brew list and lint line.

Re-mirror so the next seed does not propose reverting them:
- scripts/seed-repo-template.sh: BOOTSTRAP.md and AGENTS.md heredoc bodies
  regenerated byte-for-byte from repo-template main e648a2eb (README.md
  heredoc unchanged; that file did not change).
- tests/fixtures/seed-repo-template/repo-template-{BOOTSTRAP,AGENTS}.md
  refreshed (trailing newline stripped, as the seeder writes them).
- tests/test_seed_repo_template.bats: REPO_TEMPLATE_BOOTSTRAP_BLOB and
  REPO_TEMPLATE_AGENTS_BLOB repinned; commit reference 68eb6a18 (#252) ->
  e648a2eb (#255).

Refs #2047.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner October 20, 2026 16:40
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T16:47:58.023658Z 493f102 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Validation results (local, macOS, Homebrew bash 5.3.20; commit 493f102):

$ PATH=/opt/homebrew/bin:$PATH bats tests/test_seed_repo_template.bats
1..101
100 ok
not ok 60 #2233: README.md section is read from the standard, not a copy in the script
#   sed -i -e ... failed — sed: -e: No such file or directory   (BSD sed; line untouched by this PR, GNU sed in CI)

Blob pins (all three equal git hash-object of the newline-stripped repo-template main@e648a2eb content and of --emit-baseline output):

File Blob
BOOTSTRAP.md bcea59b3be30f4cc3273b8de22212f826615db82 (was 28647673…)
AGENTS.md 1c5e6cb3b131037b7a103ebf33c243fac9facd0c (was 081d3599…)
README.md c3fd7433e1b962846e569f3f2a9988a3a47967b4 (unchanged)

Dry run against the merged upstream:

$ DRY_RUN=true bash scripts/seed-repo-template.sh --repo combsmith/repo-template
  [dry-run] would SKIP AGENTS.md — unchanged (AC #3) (no change)
  [dry-run] would SKIP README.md — unchanged (AC #3) (no change)
  [dry-run] would SKIP BOOTSTRAP.md — unchanged (AC #3) (no change)
[seed] PASS (dry-run) — combsmith/repo-template

Before the upstream merge the same command reported would UPDATE AGENTS.md / would UPDATE BOOTSTRAP.md, confirming the pins track main.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a1a27a97-9c4e-4afd-8885-19b6bf0da895
📥 Commits

Reviewing files that changed from the base of the PR and between fdf6993 and 493f102.

📒 Files selected for processing: 4
  • scripts/seed-repo-template.sh
  • tests/fixtures/seed-repo-template/repo-template-AGENTS.md
  • tests/fixtures/seed-repo-template/repo-template-BOOTSTRAP.md
  • tests/test_seed_repo_template.bats
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #2374
No changes were committed, but the PR still can't be marked done: required check SonarCloud is still pending. The retry cron will re-attempt automatically. Next attempt after: 2026-10-20T17:11:46Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required check SonarCloud is still pending. I'll re-check automatically.
Next attempt after: 2026-10-20T17:11:46Z

@don-petry
don-petry enabled auto-merge October 20, 2026 16:41
@sonarqubecloud

Copy link
Copy Markdown

@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-20T17:42:28Z.

@don-petry

Copy link
Copy Markdown
Collaborator Author

QA Lead — test-risk advisory

Risk tier: LOW. The change only touches text inside quoted heredocs and the test pins. The seeder's logic is untouched, the change is reverted in one commit, and no external state is involved.

What I'd shore up (highest leverage first):

  • The pins only check themselves. The heredoc, the fixture and the pin are all regenerated in the same PR, so the blob-identity tests prove the three agree with each other. They don't prove they match upstream. I checked them independently: upstream BOOTSTRAP.md and AGENTS.md at e648a2eb, with the trailing newline stripped, hash to bcea59b3… and 1c5e6cb3…. Both match. Write that derivation as a one-line recipe in the fixture comment, e.g. printf '%s' "$(gh api …/contents/X.md?ref=SHA -H 'Accept: application/vnd.github.raw')" | git hash-object --stdin, so the next mirror can be reproduced instead of trusted.
  • Drift is caught too late. Right now drift only shows up when someone notices a seed run proposing an update. Add a scheduled check that compares --emit-baseline output with upstream main and doesn't block merges. Keep that network call out of the PR test suite, where it would be a flaky live dependency.
  • Test 60 already fails on macOS. sed -i -e on BSD sed fails on a line this PR doesn't touch. Switch to a portable sed … > tmp && mv, so local runs pass 101/101 and people don't get used to ignoring one red test.
  • Merge only once CI is green. That box is still unticked.

Escalate? no

Advisory only — I comment, I do not change code. Ground: BMAD Test Architecture
(bmad-tea v1.19.0). Opt out on this item with the qa-lead:hands-off label.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 493f1023c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/seed-repo-template.sh
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-reviews (no-changes)

Agent reasoning
Addressed 1 thread, by deferring it. I made no code changes and no commits.
- Thread `PRRT_kwDOR9SdIs6ubaJj` (language detection scanning `.venv` and `node_modules`): deferred, replied with `<!-- dev-lead:deferred ref=#2047 -->`. The finding is valid. But the block at `scripts/seed-repo-template.sh:833-839` is a verbatim mirror of repo-template's `BOOTSTRAP.md`. `tests/test_seed_repo_template.bats` (the #2233 test) requires the emission to be blob-identical to upstream. Editing it here would break that test. The fix, such as using `git ls-files` instead of `find`, has to land in repo-template first. I logged it in the deferred-findings issue #2047 with a link to the thread.
Phase 0: no CI check has failed, and there are no `CHANGES_REQUESTED` reviews. `bats` and some `dev-lead` jobs were still running or pending at the time of the snapshot.
Phase 1b: I didn't check PR issue comments or disposition any.
Test verification: not run, since nothing changed.
Files changed: none.

@don-petry
don-petry enabled auto-merge October 20, 2026 16:49
@don-petry
don-petry merged commit 2887ea6 into main Oct 20, 2026
73 of 82 checks passed
@don-petry
don-petry deleted the chore/mirror-repo-template-255 branch October 20, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants