feat: implement issue #1765 — Personas post as don-petry, not donpetry-bot — record as ADR-0008 and apply across the fleet (fixes #1734, reverses #1650)

[don-petry]

User description

Closes #1765

Implemented by dev-lead agent. Please review.

---

CodeAnt-AI Description

Restore advisory comments to the owner account so they are published successfully

What Changed

• Advisory personas now post as don-petry using GH_PAT_DON_PETRY instead of the bot account whose credential could not write comments.
• The change applies across the advisory persona fleet while keeping pr-review on the separate bot identity.
• Workflow-enforced markers remain required on every advisory comment, preserving the available recursion protection.
• Added ADR-0008 to document the identity decision, its trade-offs, and the boundary between advisory comments and PR approvals.
• Updated tests to verify the owner account and credential.

Impact

✅ Fewer discarded advisory comments
✅ Consistent advisory bylines across personas
✅ Documented protection against persona comment loops

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[qodo-code-review]

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

[codeant-ai]

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Reviewed your PR	7be6a21	Sep 12, 2026 · 17:47	17:49

[codeant-ai]

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[coderabbitai]

Warning

Review limit reached

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3875649c-8933-45a4-986a-a1734b287c8d

📥 Commits

Reviewing files that changed from the base of the PR and between fd5c58f and 3b54840.

📒 Files selected for processing (10)

• .github/workflows/persona-runner-reusable.yml
• docs/architecture/adr/0008-personas-post-as-the-owner-account.md
• personas/business-analyst/persona.yml
• personas/devops-lead/persona.yml
• personas/qa-lead/persona.yml
• personas/scrum-master/persona.yml
• personas/security-lead/persona.yml
• personas/solution-architect/persona.yml
• personas/sre-lead/persona.yml
• tests/resolve_persona_identity.bats

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request introduces ADR-0008, which establishes that advisory personas will post comments using the owner account "don-petry" with the credential "GH_PAT_DON_PETRY" instead of the bot account "donpetry-bot". This resolves a live regression (#1734) where the bot account lacked write permissions for issue comments. Corresponding updates have been made to the persona manifests and bats tests. The feedback points out a minor typographical issue in the ADR document where a space is missing after a section symbol.

[donpetry-bot]

CI checks on this PR are still running. Once they complete, re-mention @donpetry-bot to trigger a fresh review.

Posted by the donpetry-bot PR-review cascade.

[don-petry]

The guard check ("Flag deleted test files") verifies that no PR removes a regression test without a maintainer's explicit ack-test-deletion acknowledgement — the invariant from #655, where a stale-base PR silently reverted a fix and dropped its guarding test in one diff. It failed here not because this PR deletes anything, but because the branch was stale: main advanced to d8394f68 (#1764), which added tests/agent_ingress_if_filter.bats, tests/agent_ingress_reference.bats, and tests/fixtures/agent-ingress/if-filter-rulings.tsv. The guard diffs main-tip→PR-HEAD, so those files appeared 'deleted' only because this branch predated them.

This diff makes the invariant true at its root: I merged origin/main into the branch (clean, no conflicts), so HEAD now contains those agent-ingress test files and the base→HEAD diff shows zero test deletions. I did not apply the ack-test-deletion label — that would silence the guard by asserting an intentional deletion that isn't happening; bringing the branch current is the honest fix the guard is designed to force.

[don-petry]

Dev-Lead — review-changes (partial)

A commit was pushed, but not every requested change was applied. Per requested item:

• docs/architecture/adr/0008-personas-post-as-the-owner-account.md:17 — applied
• tests/resolve_persona_identity.bats:80 — not applied

The unaddressed items above still need work.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[don-petry]

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

Bot: `sonarqubecloud[bot]` + `gemini-code-assist[bot]`
**Issues addressed:** 0
The SonarCloud comment is a neutral quality gate summary with zero issues reported. The typographical issue mentioned by gemini-code-assist (missing space after §) does not exist in the current file—the correct spacing is already in place. Per the task guidelines, neutral overviews without specific, actionable defects tied to files/lines are not addressed.
**Files changed:** None
No concrete code issues require fixing.

[donpetry-bot]

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-09-12T19:06:55Z.